Page MenuHome

Cycles: make SessionParams a Node
AcceptedPublic

Authored by Kévin Dietrich (kevindietrich) on Aug 30 2020, 12:46 AM.

Details

Summary

This makes SessionParams a Node rather that Session as I think it
makes more sense given that the former has all the properties that we
want to expose and is used to check for modification.

This is part of T79131.

Depends on D8750.

Diff Detail

Repository
rB Blender
Branch
cycles_session_node (branched from master)
Build Status
Buildable 9877
Build 9877: arc lint + arc unit

Event Timeline

Kévin Dietrich (kevindietrich) requested review of this revision.Aug 30 2020, 12:46 AM

Sockets that correspond to timeout properties were changed to float type, perhaps a double socket type should be added instead. Although I do believe that for such properties we should rather use an integer count of milliseconds.

SessionParams::denoising_start should be removed as it does not seem to be doing anything.

Sockets that correspond to timeout properties were changed to float type, perhaps a double socket type should be added instead. Although I do believe that for such properties we should rather use an integer count of milliseconds.

I think float is fine, it has enough precision. I slightly prefer to have seconds as a unit instead of milliseconds as well, matching what we show in the Blender UI.

SessionParams::denoising_start should be removed as it does not seem to be doing anything.

Indeed can be removed.

This revision is now accepted and ready to land.Sep 10 2020, 1:42 PM