Page MenuHome

UI: Add icons for new face-set tools
AcceptedPublic

Authored by Rahul Chaudhary (RC12) on Sat, Sep 12, 11:41 AM.

Details

Reviewers
Hans Goudey (HooglyBoogly)
Group Reviewers
User Interface
Summary

This patch adds missing icons for the new sculpt face set tools, and updates the mask icons to be more consistent with the changes.

Currently draw face sets and draw mask icons are inconsistent and don't relate to drawing/painting masks or face-sets, this patch makes the icons consistent and can be reused for future tools like sculpt vertex colors.


Diff Detail

Repository
rB Blender
Branch
Icons (branched from master)
Build Status
Buildable 10225
Build 10225: arc lint + arc unit

Event Timeline

Rahul Chaudhary (RC12) requested review of this revision.Sat, Sep 12, 11:41 AM
Rahul Chaudhary (RC12) edited the summary of this revision. (Show Details)Sat, Sep 12, 11:46 AM
Rahul Chaudhary (RC12) edited the summary of this revision. (Show Details)

Thanks for making a patch! One thing I thought of was that face set edit and "draw face set" are now a bit hard to distinguish conceptually.
The "pencil" icon is usually used for drawing. Although combining it with a box helps a lot, I wonder if it's not as clear as it could be.
It might be necessary to modify the existing face sets icon?

Even still, this is obviously a great improvement over the current situation, so thanks for making these.

Changed face set draw icon
Updated mask tool icon to make it consistent with the new icons

Rahul Chaudhary (RC12) edited the summary of this revision. (Show Details)Wed, Sep 16, 9:29 AM

These look good to me. Face set edit is a hard concept to get across, I think this works fine though.

We'll have to get other's opinions though. @Pablo Vazquez (pablovazquez)?

This revision is now accepted and ready to land.Wed, Sep 16, 9:06 PM