Page MenuHome

Fix T53073: force destroys particles rotation
ClosedPublic

Authored by Jacques Lucke (JacquesLucke) on Mon, Sep 14, 3:59 PM.

Details

Summary

As @Germano Cavalcante (mano-wii) figured out, this has probably been introduced by rB666667bd8360: Fix #29846, Dynamic rotation of particles not affected by forcefields 2.61 64….
I couldn't figure out why zeroing the angular velocity there makes sense. My guess is that it was either committed accidentally, or there has been some missing initialization.

The rotation behaves much more as I'd expect with this change.

Diff Detail

Repository
rB Blender

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Mon, Sep 14, 3:59 PM
Jacques Lucke (JacquesLucke) created this revision.

In fact it looks like it was added by accident.
Below we still see the use of add_v3_v3 instead of copy_v3_v3.

And zeroing this point->ave seems to bring more problems than possible fixes.

This revision is now accepted and ready to land.Mon, Sep 14, 4:44 PM