Page MenuHome

Fix T79707, T79929: crashes with Cycles raytracing and denoising on older Macs
ClosedPublic

Authored by Brecht Van Lommel (brecht) on Mon, Sep 14, 7:16 PM.

Diff Detail

Repository
rB Blender

Event Timeline

Brecht Van Lommel (brecht) requested review of this revision.Mon, Sep 14, 7:16 PM
Brecht Van Lommel (brecht) created this revision.
Ray molenkamp (LazyDodo) requested changes to this revision.Mon, Sep 14, 7:28 PM
Ray molenkamp (LazyDodo) added inline comments.
build_files/build_environment/cmake/versions.cmake
296

i'd rather not do these kind of exceptions, just bump all platforms in one go, it's an relatively easy lib to build, the platform devs ought to be able to find some time to do this before bcon3.

298

It seems unlikely 1.2.3 and 1.2.1 share the hash.

This revision now requires changes to proceed.Mon, Sep 14, 7:28 PM

Build fixes, use same version on all platforms.

Still waiting on confirmation if this actually works.

small nit pick : all deps have this order

version
uri
hash

you messed up the order for oidn, beyond that, haven't build it but the changes look sensible to me.

This revision is now accepted and ready to land.Tue, Sep 15, 5:40 PM

Only update OIDN, Embree issue will be solved without library rebuild.