Page MenuHome

Fix buffer overflow in Cycles' system_cpu_brand_string helper.
ClosedPublic

Authored by Bastien Montagne (mont29) on Wed, Sep 16, 2:33 PM.

Details

Summary

C++ string expects a NULL-terminated C-string, which cannot be guaranteed with a char buff[48] filled from 12 integers…brech

Diff Detail

Repository
rB Blender

Event Timeline

Bastien Montagne (mont29) requested review of this revision.Wed, Sep 16, 2:33 PM
Bastien Montagne (mont29) created this revision.
This revision is now accepted and ready to land.Wed, Sep 16, 2:35 PM
Bastien Montagne (mont29) retitled this revision from Fix buffer overflow in Cycles' cpuid helper. to Fix buffer overflow in Cycles' system_cpu_brand_string helper..Wed, Sep 16, 2:36 PM

BLI_cpu_brand_string needs to be fixed as well.

BLI_cpu_brand_string needs to be fixed as well.

Ah indeed, thanks for noting that one!