Page MenuHome
Paste P453

gawain_refactor.py (see: T51219)
ActivePublic

Authored by Campbell Barton (campbellbarton) on Mar 11 2017, 9:22 AM.
See: https://developer.blender.org/D2678

Event Timeline

Campbell Barton (campbellbarton) changed the title of this paste from Conversation about exposing operators with undo to window-manager. to gawain_refactor.py.Apr 18 2017, 11:02 PM
Campbell Barton (campbellbarton) updated the paste's language from text to python.
Campbell Barton (campbellbarton) edited the content of this paste. (Show Details)
Campbell Barton (campbellbarton) edited the content of this paste. (Show Details)
Campbell Barton (campbellbarton) changed the title of this paste from gawain_refactor.py to gawain_refactor.py (see: T51219).Apr 25 2017, 7:32 PM

Some notes on specifics, so we can use this as a base for discussion.

I like GW_BATCH_READY_TO_DRAW and the other batch phase enums. The GW_FETCH names I'm mixed about -- neither set of names is perfect. At least with the FETCH prefix we get a short list of the options from autocomplete.

convert_prim_type_to_gl function should be private. I'll get on that.

GW_vertbuffer_attr_stride should be GW_vertbuffer_attr_fill_stride.

GW_batch_program_set
GW_batch_program_use_begin
GW_batch_program_use_end

^-- I like these

GW_elemlist_vert_add
GW_elemlist_line_verts_add
GW_elemlist_tri_verts_add

^-- these are worse than the names they replace
No autocompletion and the word "point" is meaningful here. Prefer these:

GW_elemlist_add_point_vert
GW_elemlist_add_line_verts
GW_elemlist_add_tri_verts (or triangle_verts)

There's a duplicate GW_PRIM_LINE_STRIP_ADJACENCY.