Shape Key mode of Dopesheet should show evaluation time #100115

New Issue

Sybren A. Stüvel · 2022-08-01T11:47:35+02:00

Sybren A. Stüvel commented

2022-08-01 11:47:35 +02:00

System Information
Operating system: Linux-5.4.0-122-generic-x86_64-with-glibc2.31 64 Bits
Graphics card: NVIDIA GeForce GTX 1080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 470.82.01

Blender Version
Broken: version: 3.4.0 Alpha, branch: master, commit date: 2022-08-01, hash: 3393b7137e
Worked: probably never, went back to 2.79, and even a relevant part of the code hasn't changed since Blender 2.5 was in development.

Short description of error
The Shape Key mode of the Dopesheet refuses to show the "evaluation time" animation. To get to the "evaluated time" shapekey property, un-check the "Relative" checkbox in the Shape Key properties panel.

{F13328976,size=full}

Exact steps for others to reproduce the error

Open the attached blend file.
See that the Dopsheet doesn't show any animation data, and also that the Action selector is empty.

{F13329006,size=full}

shapekey-nonrelative-mode.blend

Expected behaviour: Switching the shapekey to non-relative should

add an "evaluated time" row to the animation editor, and
hide the per-key row from the animation editor. Maybe this point should depend on whether they are keyed or not, and if they are, still show those rows.

Hiding the per-key rows is of less importance; I think it's a nice touch, as those won't be evaluated anyway. However, there is also a point to be made that in general FCurves are shown, even when they map to a property that's not evaluated. The most important aspect of this bug is that the evaluated time isn't shown in the shapekey mode of the dopesheet, and that Actions containing an FCurve for this property are not selectable.

The patch below is a nice place to start investigating this. Blender then does show the keys of the "evaluated time" in the Summary row.

diff --git a/source/blender/editors/animation/anim_filter.c b/source/blender/editors/animation/anim_filter.c
index d9eeed94868..913a69fea4e 100644
    - a/source/blender/editors/animation/anim_filter.c
+++ b/source/blender/editors/animation/anim_filter.c
@@ -134,9 +134,7 @@ static Key *actedit_get_shapekeys(bAnimContext *ac)

key = BKE_key_from_object(ob);

if (key) {

- if (key->type == KEY_RELATIVE) {
- return key;
- }
+    return key;

}

return NULL;

To see some more, possibly related, buggyness:

Try to select KeyAction in the Action selector, and see that Blender refuses to select it.
Click the New button of the Action selector, and see that Blender creates it but refuses to select it.

**System Information** Operating system: Linux-5.4.0-122-generic-x86_64-with-glibc2.31 64 Bits Graphics card: NVIDIA GeForce GTX 1080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 470.82.01 **Blender Version** Broken: version: 3.4.0 Alpha, branch: `master`, commit date: 2022-08-01, hash: `3393b7137e` Worked: probably never, went back to 2.79, and even a relevant part of the code hasn't changed since Blender 2.5 was in development. **Short description of error** The Shape Key mode of the Dopesheet refuses to show the "evaluation time" animation. To get to the "evaluated time" shapekey property, un-check the "Relative" checkbox in the Shape Key properties panel. {[F13328976](https://archive.blender.org/developer/F13328976/image.png),size=full} **Exact steps for others to reproduce the error** - Open the attached blend file. - See that the Dopsheet doesn't show any animation data, and also that the Action selector is empty. {[F13329006](https://archive.blender.org/developer/F13329006/image.png),size=full} [shapekey-nonrelative-mode.blend](https://archive.blender.org/developer/F13329010/shapekey-nonrelative-mode.blend) Expected behaviour: Switching the shapekey to non-relative should - add an "evaluated time" row to the animation editor, and - hide the per-key row from the animation editor. Maybe this point should depend on whether they are keyed or not, and if they are, still show those rows. Hiding the per-key rows is of less importance; I think it's a nice touch, as those won't be evaluated anyway. However, there is also a point to be made that in general FCurves are shown, even when they map to a property that's not evaluated. The most important aspect of this bug is that the evaluated time isn't shown in the shapekey mode of the dopesheet, and that Actions containing an FCurve for this property are not selectable. The patch below is a nice place to start investigating this. Blender then does show the keys of the "evaluated time" in the Summary row. ```lang=diff diff --git a/source/blender/editors/animation/anim_filter.c b/source/blender/editors/animation/anim_filter.c index d9eeed94868..913a69fea4e 100644 - a/source/blender/editors/animation/anim_filter.c +++ b/source/blender/editors/animation/anim_filter.c @@ -134,9 +134,7 @@ static Key *actedit_get_shapekeys(bAnimContext *ac) ``` key = BKE_key_from_object(ob); ``` ``` if (key) { ``` - if (key->type == KEY_RELATIVE) { - return key; - } + return key; ``` } ``` ``` return NULL; ``` ``` ------------ To see some more, possibly related, buggyness: - Try to select `KeyAction` in the Action selector, and see that Blender refuses to select it. - Click the New button of the Action selector, and see that Blender creates it but refuses to select it.

Sybren A. Stüvel commented

2022-08-01 11:47:35 +02:00

Added subscriber: @dr.sybren

Sybren A. Stüvel commented

2022-08-01 11:47:59 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Sybren A. Stüvel commented

2022-08-01 11:47:59 +02:00

Added subscriber: @ZedDB

Sybren A. Stüvel commented

2022-08-05 11:46:09 +02:00

I'm classifying this as "known issue", since it's been in Blender since 2.5 and at the moment there are more pressing tasks to deal with on shorter notice.

This was discussed in yesterday's #animation_rigging module meeting: https://devtalk.blender.org/t/2022-08-04-animation-rigging-module-meeting/25313

I'm classifying this as "known issue", since it's been in Blender since 2.5 and at the moment there are more pressing tasks to deal with on shorter notice. This was discussed in yesterday's #animation_rigging module meeting: https://devtalk.blender.org/t/2022-08-04-animation-rigging-module-meeting/25313

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Shape Key mode of Dopesheet should show evaluation time #100115