Rigidbody Physics Refactor #100442

New Issue

Sonny Campbell · 2022-08-16T16:47:44+02:00

Sonny Campbell commented

2022-08-16 16:47:44 +02:00

Goal
The goal is to simplify the rigidbody physics code.

This ticket is being raised after discussions with @ZedDB about this issue https://developer.blender.org/T91369 and the related tickets regarding rigidbody physics crashes. I attempted to resolve those crashes on their own, but really struggled to find a sensible way to resolve some of the memory management issues that were occuring. @ZedDB mentioned that this was an area of the code in need of a redesign for some time, and with comments like below predicting this could be an issue, we decided it could be a good time to start tackling it.

Approach
I want to start with some smaller low hanging fruit, that wouldn't change any logic but will improve the readability of the code.

There is some dead code that can be removed
BKE_rigidbody_calc_center_of_mass - probably worth keeping the logic but hiding with a #if 0
BKE_rigidbody_world_groups_relink is only used by BKE_scene_groups_relink which doesn't seem to be used anywhere else.
It would make things much easier to follow by separating the simulation logic from the rididbody creation/deletion logic, into a separate rigidbody_simulation.c file.
There is a lot of general tidy-up that would make the code more readable and easier to understand.

Once these tasks are completed we can start thinking about any larger design issues that need to be addressed - like with the memory management of the constraints. With more readable code, and a better understanding of the logic from the refactoring process, it should be a more solvable problem.

**Goal** The goal is to simplify the rigidbody physics code. This ticket is being raised after discussions with @ZedDB about this issue https://developer.blender.org/T91369 and the related tickets regarding rigidbody physics crashes. I attempted to resolve those crashes on their own, but really struggled to find a sensible way to resolve some of the memory management issues that were occuring. @ZedDB mentioned that this was an area of the code in need of a redesign for some time, and with comments like below predicting this could be an issue, we decided it could be a good time to start tackling it. ![image.png](https://archive.blender.org/developer/F13394253/image.png) **Approach** I want to start with some smaller low hanging fruit, that wouldn't change any logic but will improve the readability of the code. - [ ] There is some dead code that can be removed - `BKE_rigidbody_calc_center_of_mass` - probably worth keeping the logic but hiding with a `#if 0` - `BKE_rigidbody_world_groups_relink` is only used by `BKE_scene_groups_relink` which doesn't seem to be used anywhere else. - [ ] It would make things much easier to follow by separating the simulation logic from the rididbody creation/deletion logic, into a separate `rigidbody_simulation.c` file. - [ ] There is a lot of general tidy-up that would make the code more readable and easier to understand. Once these tasks are completed we can start thinking about any larger design issues that need to be addressed - like with the memory management of the constraints. With more readable code, and a better understanding of the logic from the refactoring process, it should be a more solvable problem.

Sonny Campbell self-assigned this 2022-08-16 16:47:44 +02:00

Sonny Campbell commented

2022-08-16 16:47:44 +02:00

Added subscribers: @ZedDB, @SonnyCampbell_Unity

Sebastian Parborg commented

2022-08-16 16:51:49 +02:00

Just to have it in writing here:
I'm fine with these steps. I don't think any of the other developers will have any issues with these either.

Just to have it in writing here: I'm fine with these steps. I don't think any of the other developers will have any issues with these either.

Sebastian Parborg commented

2022-08-16 16:52:14 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Iliya Katushenock commented

2022-08-16 20:50:23 +02:00

Added subscriber: @mod_moder

Pratik Borhade commented

2022-08-17 01:27:24 +02:00

Added subscriber: @PratikPB2123

Jonathan Benton commented

2022-08-20 22:25:59 +02:00

Added subscriber: @vinegarshots

Jonathan Benton commented

2022-08-20 22:27:03 +02:00

Glad to see this here. I'm working on a project that requires a rigid body chain with a bunch of rigid body constraints, and it's almost impossible to complete due to the nonstop crashing :(

Philipp Oeser commented

2022-08-22 14:53:47 +02:00

Added subscriber: @lichtwerk

Bastien Montagne added this to the Core project 2023-02-09 15:42:54 +01:00

Bastien Montagne removed this from the Core project 2023-02-09 18:20:30 +01:00

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Rigidbody Physics Refactor #100442