Line Art Thickness doesn't consider Render Resolution Percentage #100595

New Issue

Nick Alberelli · 2022-08-23T22:54:14+02:00

Nick Alberelli commented

2022-08-23 22:54:14 +02:00

System Information
Operating system: Windows-10-10.0.19044-SP0 64 Bits
Graphics card: Intel(R) UHD Graphics 620 Intel 4.5.0 - Build 30.0.101.1122

Blender Version
Broken: version: 3.2.2, branch: master, commit date: 2022-08-02 18:15, hash: bcfdb14560
Broken: version: 3.4.0 Alpha, branch: master, commit date: 2022-08-22 10:16, hash: ba74704c9a
Broken

Short description of error
When using Line Art Modifier, on a Grease Pencil Object in Screen Space Mode, Line Thickness doesn't scale with resolution as expected.

Exact steps for others to reproduce the error

Open new General Startup File
Create New Object>Grease Pencil>Scene Line Art
Under Object Data Properties>Strokes>Stroke Thickness and set to World Space
Set Render Resolution % to a factor. line thickness will be different than expected

**System Information** Operating system: Windows-10-10.0.19044-SP0 64 Bits Graphics card: Intel(R) UHD Graphics 620 Intel 4.5.0 - Build 30.0.101.1122 **Blender Version** Broken: version: 3.2.2, branch: master, commit date: 2022-08-02 18:15, hash: `bcfdb14560` Broken: version: 3.4.0 Alpha, branch: master, commit date: 2022-08-22 10:16, hash: `ba74704c9a` Broken **Short description of error** When using Line Art Modifier, on a Grease Pencil Object in Screen Space Mode, Line Thickness doesn't scale with resolution as expected. **Exact steps for others to reproduce the error** 1. Open new General Startup File 2. Create New Object>Grease Pencil>Scene Line Art 3. Under Object Data Properties>Strokes>Stroke Thickness and set to World Space 4. Set Render Resolution % to a factor. line thickness will be different than expected ![image.png](https://archive.blender.org/developer/F13414134/image.png) ![image.png](https://archive.blender.org/developer/F13414136/image.png)

Nick Alberelli commented

2022-08-23 22:54:14 +02:00

Added subscriber: @TinyNick

Germano Cavalcante commented

2022-08-24 17:44:37 +02:00

Added subscriber: @mano-wii

Germano Cavalcante commented

2022-08-24 17:44:37 +02:00

Changed status from 'Needs Triage' to: 'Needs User Info'

Germano Cavalcante commented

2022-08-24 17:44:37 +02:00

Under Object Data Properties>Strokes>Stroke Thickness and set to World Space

Did you mean Screen Space instead of World Space?
If so, I'm not sure it's a bug as in the case of Screen Space the line thickness seems to be measured in pixels.
So a higher resolution image is to be expected with relatively thinner lines.

> 3. Under Object Data Properties>Strokes>Stroke Thickness and set to World Space Did you mean `Screen Space` instead of `World Space`? If so, I'm not sure it's a bug as in the case of Screen Space the line thickness seems to be measured in pixels. So a higher resolution image is to be expected with relatively thinner lines.

Nick Alberelli commented

2022-08-25 01:33:14 +02:00

I did mean sceeen space, when i go to screen space mode theres the thickness still just reports as a value not a pixel value.

And if I am doing a render at a lower percentage usually as a user im trying to preview what 100% will look like so personally I would expect the thickness to scale relativly too,

But if this is the way it should be I will make my own addon to work around this :)

I did mean sceeen space, when i go to screen space mode theres the thickness still just reports as a value not a pixel value. And if I am doing a render at a lower percentage usually as a user im trying to preview what 100% will look like so personally I would expect the thickness to scale relativly too, But if this is the way it should be I will make my own addon to work around this :)

Philipp Oeser commented

2022-08-25 13:07:31 +02:00

Added subscribers: @filedescriptor, @ChengduLittleA, @ZedDB, @antoniov, @lichtwerk

Philipp Oeser commented

2022-08-25 13:07:31 +02:00

We could compensate with something like D15780: Fix #100595: Lineart screenspace thickness ignores Resolution Percentage, not 100% sure though if this desired in all scenarios (would assume so though).

CC @antoniov
CC @ChengduLittleA
CC @filedescriptor
CC @ZedDB

We could compensate with something like [D15780: Fix #100595: Lineart screenspace thickness ignores Resolution Percentage](https://archive.blender.org/developer/D15780), not 100% sure though if this desired in all scenarios (would assume so though). CC @antoniov CC @ChengduLittleA CC @filedescriptor CC @ZedDB

Germano Cavalcante commented

2022-08-25 23:07:57 +02:00

Changed status from 'Needs User Info' to: 'Needs Developer To Reproduce'

Philipp Oeser commented

2022-08-29 12:39:00 +02:00

Added subscriber: @fclem

Philipp Oeser commented

2022-08-29 12:39:00 +02:00

Just dropping a note from D15780:

In D15780 #429198, @fclem wrote:
But if that's something we want to fix for all screen space radii, we better put it in the ViewInfos instead and do the multiplication in the shader.

If that is the only way forward, there is probably no point in keeping D15780.
Might check on that solution as well, but for now, will abandon the patch and step down then (until doing it in ViewInfos proves to work on my side).

Just dropping a note from [D15780](https://archive.blender.org/developer/D15780): > In [D15780](https://archive.blender.org/developer/D15780)#429198, @fclem wrote: > But if that's something we want to fix for all screen space radii, we better put it in the `ViewInfos` instead and do the multiplication in the shader. If that is the only way forward, there is probably no point in keeping [D15780](https://archive.blender.org/developer/D15780). Might check on that solution as well, but for now, will abandon the patch and step down then (until doing it in `ViewInfos` proves to work on my side).

Sergey Sharybin added

and removed

labels 2023-02-13 18:06:15 +01:00

Sign in to join this conversation.