Geometry Attribute Convert crashes in sculpt mode #100687

New Issue

Campbell Barton · 2022-08-29T12:16:58+02:00

Campbell Barton commented

2022-08-29 12:16:58 +02:00

Caused by 35c601269b

The following script:

import bpy
bpy.ops.object.mode_set(mode='SCULPT')
bpy.ops.geometry.attribute_convert('EXEC_DEFAULT')

Asserts when run in background mode, e.g.

``./blender.bin --factory-startup -b --python test.py`

With: BLI_assert failed: source/blender/blenlib/BLI_span.hh:573, operator- [ ](), at 'index < this->size()'

Full back-trace.

backtrace.txt

Happens in master 28750bcf7e8b73d9da015898a3c0f21ef5d761f2
In v3.3 the operators poll function returns false.
Also crashes in release builds when done from the UI (since there is no Attribute to work on)
poll does not return false anymore, becuase since culprit commit, we always have a .hide_poly attribute

NOTE: this happens in weight-paint mode too,

Caused by 35c601269b The following script: ``` import bpy bpy.ops.object.mode_set(mode='SCULPT') bpy.ops.geometry.attribute_convert('EXEC_DEFAULT') ``` Asserts when run in background mode, e.g. ``./blender.bin --factory-startup -b --python test.py` With: `BLI_assert failed: source/blender/blenlib/BLI_span.hh:573, operator- [ ](), at 'index < this->size()'` Full back-trace. [backtrace.txt](https://archive.blender.org/developer/F13429969/backtrace.txt) ---- - Happens in `master` `28750bcf7e8b73d9da015898a3c0f21ef5d761f2` - In v3.3 the operators poll function returns false. - Also crashes in release builds when done from the UI (since there is no Attribute to work on) - poll does not return false anymore, becuase since culprit commit, we always have a `.hide_poly` attribute --- NOTE: this happens in weight-paint mode too,

Campbell Barton commented

2022-08-29 12:16:58 +02:00

Added subscriber: @ideasman42

Campbell Barton changed title from ~~Geometry Attribute Convert asserts in weight paint mode~~ to Geometry Attribute Convert asserts in sculpt mode

2022-08-29 12:23:46 +02:00

Philipp Oeser commented

2022-08-29 12:53:28 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2022-08-29 12:53:28 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser commented

2022-08-29 12:53:28 +02:00

Also crashes in release builds when done from the UI (since there is no Attribute to work on? -- this should be caught by BKE_id_attributes_active_get in the poll though, checking...)

Also crashes in release builds when done from the UI (since there is no Attribute to work on? -- this should be caught by `BKE_id_attributes_active_get` in the poll though, checking...)

Philipp Oeser commented

2022-08-29 13:37:36 +02:00

Added subscriber: @HooglyBoogly

Philipp Oeser commented

2022-08-29 13:37:36 +02:00

Change apparently came with 35c601269b

@HooglyBoogly : seems we now have an attribute (".hide_poly") and that messes with the poll.
Can these be marked internal or something along those lines?

Will set this to High prio since it involves crashes and is recent (feel free to lower again if unappropriate).

Change apparently came with 35c601269b @HooglyBoogly : seems we now have an attribute (`".hide_poly"`) and that messes with the poll. Can these be marked internal or something along those lines? Will set this to High prio since it involves crashes and is recent (feel free to lower again if unappropriate).

Philipp Oeser changed title from ~~Geometry Attribute Convert asserts in sculpt mode~~ to Geometry Attribute Convert crashes in sculpt mode

2022-09-01 09:04:19 +02:00

Philipp Oeser commented

2022-09-01 09:07:23 +02:00

I guess we could just poll for any attribute except the ones starting with "."?
Use allow_procedural_attribute_access in BKE_id_attributes_active_get?

I guess we could just poll for any attribute except the ones starting with "."? Use `allow_procedural_attribute_access` in `BKE_id_attributes_active_get`?

Philipp Oeser self-assigned this 2022-09-01 13:38:00 +02:00

Philipp Oeser commented

2022-09-01 13:38:00 +02:00

Think I got a fix

blender-admin commented

2022-09-01 13:55:20 +02:00

This issue was referenced by a50ca6a1cd

This issue was referenced by a50ca6a1cd72aa0556d74dd4a54de25bf2eeadcb

Philipp Oeser commented

2022-09-03 11:43:10 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Philipp Oeser closed this issue

2022-09-03 11:43:10 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Geometry Attribute Convert crashes in sculpt mode #100687