Outliner: Click on empty area next to View Layer name triggers object select #102357

New Issue

Pablo Vazquez · 2022-11-08T15:42:15+01:00

Pablo Vazquez commented

2022-11-08 15:42:15 +01:00

System Information
Operating system: Linux-5.15.11-76051511-generic-x86_64-with-glibc2.34 64 Bits
Graphics card: NVIDIA RTX A5000/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 510.73.05

Blender Version
Broken: version: 3.5.0 Alpha, branch: master, commit date: 2022-11-08 13:28, hash: 1d71f82033
Worked: I don't think it ever worked.

Short description of error

In the Outliner, with "All View Layers" filter turned on, when I click on the empty area next to the name of the View Layer, it selects the Camera, or Cube.

When there are many objects in the scene it triggers the object search.

{F13868667, size=full}

Mockup of what I think it's going on under the hood:
{F13868683, size=full}

Exact steps for others to reproduce the error

Go to the Outliner
Enable the filter "All View Layers"
Collapse the View Layer
Click on the empty area next to the name. In some cases it will select (and expand, that's a bug) the View Layer, you need to click a bit more to the right where the object type icons would be.

**System Information** Operating system: Linux-5.15.11-76051511-generic-x86_64-with-glibc2.34 64 Bits Graphics card: NVIDIA RTX A5000/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 510.73.05 **Blender Version** Broken: version: 3.5.0 Alpha, branch: master, commit date: 2022-11-08 13:28, hash: `1d71f82033` Worked: I don't think it ever worked. **Short description of error** In the Outliner, with "All View Layers" filter turned on, when I click on the empty area next to the name of the View Layer, it selects the Camera, or Cube. When there are many objects in the scene it triggers the object search. {[F13868667](https://archive.blender.org/developer/F13868667/sc_-2022-11-08_15.26.26.mp4), size=full} Mockup of what I think it's going on under the hood: {[F13868683](https://archive.blender.org/developer/F13868683/image.png), size=full} **Exact steps for others to reproduce the error** * Go to the Outliner * Enable the filter "All View Layers" * Collapse the View Layer * Click on the empty area next to the name. In some cases it will select (and expand, that's [a bug](https://developer.blender.org/T102317)) the View Layer, you need to click a bit more to the right where the object type icons would be.

Pablo Vazquez commented

2022-11-08 15:42:15 +01:00

Added subscriber: @pablovazquez

Richard Antalik commented

2022-11-08 22:33:47 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Dalai Felinto was assigned by Pablo Vazquez

2022-11-10 17:16:17 +01:00

Pablo Vazquez commented

2022-11-10 17:16:18 +01:00

Talked with Dalai and he will look into it since he worked in this area before.

Philipp Oeser commented

2022-11-14 16:34:40 +01:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2022-11-14 16:34:40 +01:00

Question: do we

(a) wont to see the iconrow in case of a ViewLayer? (I mean why not list the contents?) see P3309
(b) keep hiding the contents, but correct the clicking behavior of outliner_find_item_at_x_in_row see P3310
- note this will still expand the viewlayer (might need a bit more work to keep it closed), but does not select or activate its contents

(a) looks like this:

Question: do we - (a) wont to see the iconrow in case of a ViewLayer? (I mean why not list the contents?) see [P3309](https://archive.blender.org/developer/P3309.txt) - (b) keep hiding the contents, but correct the clicking behavior of `outliner_find_item_at_x_in_row` see [P3310](https://archive.blender.org/developer/P3310.txt) - note this will still expand the viewlayer (might need a bit more work to keep it closed), but does not select or activate its contents (a) looks like this: ![image.png](https://archive.blender.org/developer/F13913327/image.png)

Pablo Vazquez commented

2022-11-15 15:52:41 +01:00

In #102357#1445768, @lichtwerk wrote:
Question: do we

(a) wont to see the iconrow in case of a ViewLayer?

(b) keep hiding the contents, but correct the clicking behavior

Thanks for looking into it! It's a valid question, since it's already working, why not? Thing is, all ViewLayers have the same content (by design, all they do is define visibility of Collections). So on one side yes why not, on the other side it'll look duplicate and add noise to the scene.

What would be useful to display is info such as:

If the ViewLayer is marked as "Render Single Layer"

{F13917698, size=full}

The passes for that ViewLayer, which when expanded could be an item "Passes" and a tree inside containing each pass with a checkbox to turn it on/off. When collapsed it'd be tricky since passes don't have icons, but at least showing the total number of passes enabled would be helpful.

This could be interesting to investigate but it's a task on itself, so in order to fix and close this task I would go with (b), to not show the icons row and simply fix the fact that all ViewLayers get expanded.

> In #102357#1445768, @lichtwerk wrote: > Question: do we > - (a) wont to see the iconrow in case of a ViewLayer? > - (b) keep hiding the contents, but correct the clicking behavior Thanks for looking into it! It's a valid question, since it's already working, why not? Thing is, all ViewLayers have the same content (by design, all they do is define visibility of Collections). So on one side yes why not, on the other side it'll look duplicate and add noise to the scene. What **would** be useful to display is info such as: * If the ViewLayer is marked as "Render Single Layer" ``` {F13917698, size=full} ``` * The passes for that ViewLayer, which when expanded could be an item "Passes" and a tree inside containing each pass with a checkbox to turn it on/off. When collapsed it'd be tricky since passes don't have icons, but at least showing the total number of passes enabled would be helpful. This could be interesting to investigate but it's a task on itself, so in order to fix and close this task I would go with (b), to not show the icons row and simply fix the fact that all ViewLayers get expanded.

Dalai Felinto was unassigned by Philipp Oeser

2022-11-19 13:12:51 +01:00

Philipp Oeser self-assigned this 2022-11-19 13:12:51 +01:00

Philipp Oeser commented

2022-11-19 13:12:51 +01:00

Added subscriber: @dfelinto