Grease Pencil: Crash when trying to sculpt on object with Dot Dash modifier #102684

New Issue

Sun Kim · 2022-11-22T08:12:15+01:00

Sun Kim commented

2022-11-22 08:12:15 +01:00

System Information
Operating system: Windows-10-10.0.19045-SP0 64 Bits
Graphics card: Radeon RX 570 Series ATI Technologies Inc. 4.5.0 Core Profile Context 22.11.1.221110

Blender Version
Broken: version: 3.5.0 Alpha, branch: master, commit date: 2022-11-21 01:31, hash: 7a6cdeb242
Worked: 3.0?

I'm not sure I can say it worked. While it doesn't crash sculpting still doesn't work as expected.

Short description of error
Blender crashes when I try to sculpt on Grease Pencil object with Dot Dash modifier.

Stroke.crash.txt

Exact steps for others to reproduce the error

Add Grease Pencil Stroke, and add Dot Dash modifier to it
Switch to Sculpt mode
Try to sculpt on it

Stroke.blend

**System Information** Operating system: Windows-10-10.0.19045-SP0 64 Bits Graphics card: Radeon RX 570 Series ATI Technologies Inc. 4.5.0 Core Profile Context 22.11.1.221110 **Blender Version** Broken: version: 3.5.0 Alpha, branch: master, commit date: 2022-11-21 01:31, hash: `7a6cdeb242` Worked: 3.0? I'm not sure I can say it worked. While it doesn't crash sculpting still doesn't work as expected. **Short description of error** Blender crashes when I try to sculpt on Grease Pencil object with Dot Dash modifier. [Stroke.crash.txt](https://archive.blender.org/developer/F13959008/Stroke.crash.txt) **Exact steps for others to reproduce the error** * Add Grease Pencil Stroke, and add Dot Dash modifier to it * Switch to Sculpt mode * Try to sculpt on it [Stroke.blend](https://archive.blender.org/developer/F13959066/Stroke.blend)

Sun Kim commented

2022-11-22 08:12:15 +01:00

Added subscriber: @persun

Philipp Oeser commented

2022-11-22 09:16:24 +01:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2022-11-22 09:16:24 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser commented

2022-11-22 09:16:24 +01:00

Can confirm, will check

Antonio Vazquez commented

2022-11-22 10:00:58 +01:00

Added subscriber: @antoniov

Antonio Vazquez commented

2022-11-22 10:00:58 +01:00

Can confirm too... I guess is the orig pointer is not set to NULL... testing.

Antonio Vazquez self-assigned this 2022-11-22 10:04:53 +01:00

blender-admin commented

2022-11-22 10:47:58 +01:00

This issue was referenced by 17fd81fb9b

This issue was referenced by 17fd81fb9be6a3705f161a79427dd6754f949a97

blender-admin commented

2022-11-22 10:47:58 +01:00

This issue was referenced by 8c82d4cbf6

This issue was referenced by 8c82d4cbf61b78bb0a52148a15912b870ece9f47

Philipp Oeser commented

2022-11-22 10:48:56 +01:00

I'm not sure I can say it worked. While it doesn't crash sculpting still doesn't work as expected.

Sculpting only works if the Edit Mode / show_in_editmode option is disabled.

I think there is a general issue with generative GP modifiers with the Edit Mode / show_in_editmode option: these show evaluated points that can be edited (as if an On Cage option - like the one for generative mesh modifiers - was enabled) but also e.g. the Dot Dash modifier does not draw the original stroke edit points at all anymore > so you cant actually use editmode with that modifier (and the show_in_editmode option). This all seems very wrong.
Then we also have the Subdivide modifier (which draws a mixture of original points - which can be edited - and evaluated points - which cannot be edited and draw in a different color -). Think this needs a general design of some sort.

> I'm not sure I can say it worked. While it doesn't crash sculpting still doesn't work as expected. Sculpting only works if the `Edit Mode` / `show_in_editmode` option is disabled. I think there is a general issue with generative GP modifiers with the `Edit Mode` / `show_in_editmode` option: these show evaluated points that can be edited (as if an On Cage option - like the one for generative mesh modifiers - was enabled) but also e.g. the `Dot Dash` modifier does not draw the original stroke edit points at all anymore > so you cant actually use editmode with that modifier (and the `show_in_editmode` option). This all seems very wrong. Then we also have the `Subdivide` modifier (which draws a mixture of original points - which can be edited - and evaluated points - which cannot be edited and draw in a different color -). Think this needs a general design of some sort.

Antonio Vazquez commented

2022-11-22 10:49:26 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Antonio Vazquez closed this issue

2022-11-22 10:49:26 +01:00

Philipp Oeser commented

2022-11-22 10:51:29 +01:00

Regarding the crash: this broke between good e86c2f7288 and bad 7f4ee97b9e, will bisect if that helps.

Regarding the crash: this broke between good e86c2f728872 and bad 7f4ee97b9ef9, will bisect if that helps.

Antonio Vazquez commented

2022-11-22 10:52:55 +01:00

The generated points are always gray color, so these points are not editable. Anyway, this is something we want to revieww for GP 3.0.

Philipp Oeser commented

2022-11-22 10:59:15 +01:00

OK, 8c82d4cbf6 actually solved the issue of not being able to sculpt with the show_in_editmode option.
However, the following is not true (for the Dot Dash modifier):

In #102684#1449636, @antoniov wrote:
The generated points are always gray color, so these points are not editable. Anyway, this is something we want to revieww for GP 3.0.

These generated points are never drawn for this modifier.
In addition, using selection mask (of any type) is not working with this modifier.
@antoniov : want a new report?

OK, 8c82d4cbf6 actually solved the issue of not being able to sculpt with the `show_in_editmode` option. However, the following is not true (for the `Dot Dash` modifier): > In #102684#1449636, @antoniov wrote: > The generated points are always gray color, so these points are not editable. Anyway, this is something we want to revieww for GP 3.0. These generated points are never drawn for this modifier. In addition, using selection mask (of any type) is not working with this modifier. @antoniov : want a new report?

Antonio Vazquez commented

2022-11-22 11:40:34 +01:00

These generated points are never drawn for this modifier.

@lichtwerk This is a complex problem. The Modifier generates new points and we set the reference to the original points to allow the transformation, but to use Mask and to be drawn the point, it needs to be an original point. As the points are all evaluated, you cannot select them, so you cannot use any masking because its base in the selection.

> These generated points are never drawn for this modifier. @lichtwerk This is a complex problem. The Modifier generates new points and we set the reference to the original points to allow the transformation, but to use Mask and to be drawn the point, it needs to be an original point. As the points are all evaluated, you cannot select them, so you cannot use any masking because its base in the selection.

Philipp Oeser commented

2022-11-22 14:33:25 +01:00

In #102684#1449676, @antoniov wrote:
@lichtwerk This is a complex problem. The Modifier generates new points and we set the reference to the original points to allow the transformation, but to use Mask and to be drawn the point, it needs to be an original point. As the points are all evaluated, you cannot select them, so you cannot use any masking because its base in the selection.

It is not only an issue in sculptmode, editmode also does not draw any points to edit with this modifier (show_in_editmode ON)

> In #102684#1449676, @antoniov wrote: > @lichtwerk This is a complex problem. The Modifier generates new points and we set the reference to the original points to allow the transformation, but to use Mask and to be drawn the point, it needs to be an original point. As the points are all evaluated, you cannot select them, so you cannot use any masking because its base in the selection. It is not only an issue in sculptmode, editmode also does not draw any points to edit with this modifier (`show_in_editmode` ON)

Sun Kim commented

2022-12-09 02:13:03 +01:00

Looks like this is not included in 3.3 updates or marked for backport?