Dashed geometry nodes field link too hard to see on macOS #102919

New Issue

Kent Davis · 2022-12-02T18:11:53+01:00

Kent Davis commented

2022-12-02 18:11:53 +01:00

System Information
Operating system: macOS-13.1-x86_64-i386-64bit 64 Bits
Graphics card: AMD Radeon Pro 575 OpenGL Engine ATI Technologies Inc. 4.1 ATI-4.9.51

Blender Version
Broken: version: 3.5.0 Alpha, branch: master, commit date: 2022-11-30 21:55, hash: 4aac5b92c1
Worked: (newest version of Blender that worked as expected)

Short description of error
Break line (I don't know word) see picture

Exact steps for others to reproduce the error
Only for Mac. Do not use Windows.

See my picture on my iMac there.

Browser to show picture.
https://imgur.com/0q6NTJs

Theme on Nodes "Dashed Lines Opacity"

**System Information** Operating system: macOS-13.1-x86_64-i386-64bit 64 Bits Graphics card: AMD Radeon Pro 575 OpenGL Engine ATI Technologies Inc. 4.1 ATI-4.9.51 **Blender Version** Broken: version: 3.5.0 Alpha, branch: master, commit date: 2022-11-30 21:55, hash: `4aac5b92c1` Worked: (newest version of Blender that worked as expected) **Short description of error** Break line (I don't know word) see picture **Exact steps for others to reproduce the error** Only for Mac. Do not use Windows. ![image.png](https://archive.blender.org/developer/F13986121/image.png) ![image.png](https://archive.blender.org/developer/F13986133/image.png) See my picture on my iMac there. ![image.png](https://archive.blender.org/developer/F13986119/image.png) Browser to show picture. https://imgur.com/0q6NTJs ![image.png](https://archive.blender.org/developer/F13986176/image.png) Theme on Nodes "Dashed Lines Opacity" ![image.png](https://archive.blender.org/developer/F13986184/image.png)

Kent Davis commented

2022-12-02 18:11:53 +01:00

Added subscriber: @Kent-Davis

Harley Acheson commented

2022-12-02 18:20:48 +01:00

Added subscriber: @Harley

Harley Acheson commented

2022-12-02 18:20:48 +01:00

It would be so nice to be able to fix this. Especially since this is a serious accessibility problem.

This issue is caused because our "dotted line" shader, unlike the rest, does not support custom line widths. Instead it always just uses the GL line width. Unfortunately GL line widths above 1 is optional for the driver. And on many Macs they cannot do greater than 1 pixel wide. Couple that with a Retina display and you end up with dashed lines that are less than a normal pixel wide. Terrible if you also have vision difficulties.

It would be so nice to be able to fix this. Especially since this is a serious accessibility problem. This issue is caused because our "dotted line" shader, unlike the rest, does not support custom line widths. Instead it always just uses the GL line width. Unfortunately GL line widths above 1 is optional for the driver. And on many Macs they cannot do greater than 1 pixel wide. Couple that with a Retina display and you end up with dashed lines that are less than a normal pixel wide. Terrible if you also have vision difficulties.

Iliya Katushenock commented

2022-12-02 18:39:54 +01:00

Added subscriber: @mod_moder

Iliya Katushenock commented

2022-12-02 18:39:54 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Iliya Katushenock commented

2022-12-02 18:39:54 +01:00

In that case, I'll confirm this issue. Also, from the explanation @Harley it looks like something with a high priority.

Harley Acheson commented

2022-12-02 18:50:13 +01:00

I personally consider it a high priority, since it is accessibility-related. However, it is also a very long-standing problem. It used to be that all of our shaders created invisible lines on some Macs with Retina displays, but over time they were all improved with just this one remaining. Of course even one like this is too many for those with difficulty seeing them.

I personally consider it a high priority, since it is accessibility-related. However, it is also a very long-standing problem. It used to be that **all** of our shaders created invisible lines on some Macs with Retina displays, but over time they were all improved with just this one remaining. Of course even one like this is too many for those with difficulty seeing them.

Hans Goudey changed title from ~~Geometry Nodes Diamond line unable to see. December 2, 2022~~ to Dashed geometry nodes field link to hard to see on macOS

2022-12-02 19:47:41 +01:00

Hans Goudey changed title from ~~Dashed geometry nodes field link to hard to see on macOS~~ to Dashed geometry nodes field link too hard to see on macOS

2022-12-02 19:47:53 +01:00

Hans Goudey commented

2022-12-02 23:11:55 +01:00

Added subscriber: @HooglyBoogly

Hans Goudey commented

2022-12-02 23:11:55 +01:00

Actually I don't think this is the same problem. Node links aren't drawn with the same shader as the other dashed links. They actually change thickness as you zoom in and out, just like regular links. Maybe a solution is to make the line width UI option affect the node link width.

Harley Acheson commented

2022-12-03 01:22:16 +01:00

@HooglyBoogly - Actually I don't think this is the same problem

No, I think you are right. My bad. I am just so used to our dashed-line shader affecting Kent that I jumped to the wrong conclusion.

This looks to be made with the GPU_SHADER_2D_NODELINK shader. And it looks like it isn't scaling correctly. Kent's capture had to be shown full-screen (its 3720 x 1081 since it is on a high-DPI monitor) to really see what is going on. He is indicating that the gaps between the sections of that line are only a pixel wide. So when shown on his monitor those gaps are subpixel in size. Actually the gaps seem to be between 1 and 2 pixels in size.

{F13987310,width=100%}

With a High DPI screen and his UI scale set to 2.0 and thick lines turned on he should have a U.pixelsize of 6 I think. So we really shouldn't have any features smaller than than 6 pixels. Instead we have a gaps that are smaller than the eye can discern on a high-dpi monitor.

> @HooglyBoogly - Actually I don't think this is the same problem No, I think you are right. My bad. I am just so used to our dashed-line shader affecting Kent that I jumped to the wrong conclusion. This looks to be made with the GPU_SHADER_2D_NODELINK shader. And it looks like it isn't scaling correctly. Kent's capture had to be shown full-screen (its 3720 x 1081 since it is on a high-DPI monitor) to really see what is going on. He is indicating that the gaps between the sections of that line are only a pixel wide. So when shown on his monitor those gaps are subpixel in size. Actually the gaps seem to be between 1 and 2 pixels in size. {[F13987310](https://archive.blender.org/developer/F13987310/image.png),width=100%} With a High DPI screen and his UI scale set to 2.0 and thick lines turned on he should have a U.pixelsize of 6 I think. So we really shouldn't have any features smaller than than 6 pixels. Instead we have a gaps that are smaller than the eye can discern on a high-dpi monitor.

Kent Davis commented

2022-12-03 16:23:47 +01:00

You can see " Resolution: Retina 5K (5120 x 2880) " on below.

Screenshot is 6400 px X 3200 px
You can see picture is very largest.

Radeon Pro 575:

Chipset Model:	Radeon Pro 575
Type:	GPU
Bus:	PCIe
PCIe Lane Width:	x16
VRAM (Total):	4 GB
Vendor:	AMD (0x1002)
Device ID:	0x67df
Revision ID:	0x00c4
ROM Revision:	113-D000AA-931
VBIOS Version:	113-D0001A1P-025
EFI Driver Version:	01.00.931
Metal Support:	Metal 2
Displays:

iMac:

Display Type:	Built-In Retina LCD
Resolution:	Retina 5K (5120 x 2880)
Framebuffer Depth:	30-Bit Color (ARGB2101010)
Main Display:	Yes
Mirror:	Off
Online:	Yes
Automatically Adjust Brightness:	No
Connection Type:	Internal

You can see " Resolution: Retina 5K (5120 x 2880) " on below. Screenshot is 6400 px X 3200 px You can see picture is very largest. ![Screenshot 2022-12-03 at 7.21.09 AM.png](https://archive.blender.org/developer/F13989215/Screenshot_2022-12-03_at_7.21.09_AM.png) Radeon Pro 575: ``` Chipset Model: Radeon Pro 575 Type: GPU Bus: PCIe PCIe Lane Width: x16 VRAM (Total): 4 GB Vendor: AMD (0x1002) Device ID: 0x67df Revision ID: 0x00c4 ROM Revision: 113-D000AA-931 VBIOS Version: 113-D0001A1P-025 EFI Driver Version: 01.00.931 Metal Support: Metal 2 Displays: ``` iMac: ``` Display Type: Built-In Retina LCD Resolution: Retina 5K (5120 x 2880) Framebuffer Depth: 30-Bit Color (ARGB2101010) Main Display: Yes Mirror: Off Online: Yes Automatically Adjust Brightness: No Connection Type: Internal ```

Kent Davis commented

2022-12-03 18:52:10 +01:00

Don't forget about iMac will come soon will be RETINA DISPLAY 10,000 px come soon because of iPad Pro already have 10,000 px too.

Please check my previous ticket many times. I was wait too long to fix on Blender for Mac Accessibility everything menu, 3D Viewer, and etc.

Don't forget about iMac will come soon will be RETINA DISPLAY 10,000 px come soon because of iPad Pro already have 10,000 px too. Please check my previous ticket many times. I was wait too long to fix on Blender for Mac Accessibility everything menu, 3D Viewer, and etc.

Michael Parkin-White commented

2023-01-03 11:38:29 +01:00

Added subscriber: @Michael-Parkin-White-Apple

Kent Davis commented

2023-04-07 19:05:05 +02:00

I am still wait for you to fix.
Not only EEVEE.
Only focus Geometry on break line.

I am still wait for you to fix. Not only EEVEE. Only focus Geometry on break line. ![image](/attachments/5153c8e2-dfa9-4a0a-9835-3c105903ec7b)

image.png

96 KiB

Iliya Katushenock commented

2023-04-07 19:11:51 +02:00

Hello. I don't think this is a bug that you can do anything about.

It would be possible to replace the cyrves by polylines in link drawing, so that using polylines, have a uniform density. If this is your problem?
Or we can add the line step width to the theme settings.

Hello. I don't think this is a bug that you can do anything about. - It would be possible to replace the cyrves by polylines in link drawing, so that using polylines, have a uniform density. If this is your problem? - Or we can add the line step width to the theme settings.

Kent Davis commented

2023-04-08 23:14:04 +02:00

@mod_moder
Do you have your own Macintosh iMac?

@mod_moder Do you have your own Macintosh iMac?

Iliya Katushenock commented

2023-04-08 23:19:02 +02:00

no

Kent Davis commented

2023-04-08 23:21:46 +02:00

@mod_moder
Then you should not do that without your own Mac. They do fix code for Mac only.
I am wait for them to fix code make sure Dashed Line correct.

@mod_moder Then you should not do that without your own Mac. They do fix code for Mac only. I am wait for them to fix code make sure Dashed Line correct.

Kent Davis commented

2023-04-08 23:41:51 +02:00

@PratikPB2123 Would you like to put Mac notification?

Harley Acheson commented

2023-04-09 00:18:09 +02:00

What I'm not seeing (yet) in the shader is control over the length of each dash segment. But we can control the proportion between dash and non-dash. And the line width.

This is what the dashed line looks like by default:

But if we do the following:

diff --git a/source/blender/editors/space_node/drawnode.cc b/source/blender/editors/space_node/drawnode.cc
index 4eb1dffd880..bc22b8e422a 100644
--- a/source/blender/editors/space_node/drawnode.cc
+++ b/source/blender/editors/space_node/drawnode.cc
@@ -2044,11 +2044,11 @@ static NodeLinkDrawConfig nodelink_get_draw_config(const bContext &C,
 
   const bool field_link = node_link_is_field_link(snode, link);
 
-  draw_config.dash_factor = field_link ? 0.75f : 1.0f;
+  draw_config.dash_factor = field_link ? 0.5f : 1.0f;
 
   const float scale = UI_view2d_scale_get_x(&v2d);
   /* Clamp the thickness to make the links more readable when zooming out. */
-  draw_config.thickness = max_ff(scale, 1.0f) * (field_link ? 0.7f : 1.0f);
+  draw_config.thickness = max_ff(scale, 1.0f);
   draw_config.highlighted = link.flag & NODE_LINK_TEMP_HIGHLIGHT;
   draw_config.drawarrow = ((link.tonode && (link.tonode->type == NODE_REROUTE)) &&
                            (link.fromnode && (link.fromnode->type == NODE_REROUTE)));

And then the user (and/or us) changes the "Dashed Lines Opacity" to 0:

we then get this, which might be enough to help Kent:

What I'm not seeing (yet) in the shader is control over the length of each dash segment. But we can control the proportion between dash and non-dash. And the line width. This is what the dashed line looks like by default: ![image](/attachments/c6cdfa8d-75ad-4e3e-a1ff-9547b6f8c6c2) But if we do the following: ``` diff --git a/source/blender/editors/space_node/drawnode.cc b/source/blender/editors/space_node/drawnode.cc index 4eb1dffd880..bc22b8e422a 100644 --- a/source/blender/editors/space_node/drawnode.cc +++ b/source/blender/editors/space_node/drawnode.cc @@ -2044,11 +2044,11 @@ static NodeLinkDrawConfig nodelink_get_draw_config(const bContext &C, const bool field_link = node_link_is_field_link(snode, link); - draw_config.dash_factor = field_link ? 0.75f : 1.0f; + draw_config.dash_factor = field_link ? 0.5f : 1.0f; const float scale = UI_view2d_scale_get_x(&v2d); /* Clamp the thickness to make the links more readable when zooming out. */ - draw_config.thickness = max_ff(scale, 1.0f) * (field_link ? 0.7f : 1.0f); + draw_config.thickness = max_ff(scale, 1.0f); draw_config.highlighted = link.flag & NODE_LINK_TEMP_HIGHLIGHT; draw_config.drawarrow = ((link.tonode && (link.tonode->type == NODE_REROUTE)) && (link.fromnode && (link.fromnode->type == NODE_REROUTE))); ``` And then the user (and/or us) changes the "Dashed Lines Opacity" to 0: ![image](/attachments/a7b79327-c46c-4df0-a517-aad4bf4ef11a) we then get this, which *might* be enough to help Kent: ![image](/attachments/1ee0784f-82cf-486b-a133-15e86e80e305)

image.png

108 KiB

image.png

108 KiB

image.png

109 KiB

image.png

12 KiB

Kent Davis commented

2023-04-09 01:13:22 +02:00

Sigh you still don't understand. I saw youtube for Windows Dash.
Mac need fix Blender code. I show you picture.

Sigh you still don't understand. I saw youtube for Windows Dash. Mac need fix Blender code. I show you picture. ![image](/attachments/b4718b81-03d5-4a91-9e3d-f98ea0f3c797)

image.png

795 KiB

Harley Acheson commented

2023-04-09 01:40:03 +02:00

I understand. I would like you to evaluate the following build I made for you to test:

https://builder.blender.org/download/patch/PR106725/

I understand. I would like you to evaluate the following build I made for you to test: https://builder.blender.org/download/patch/PR106725/

Kent Davis commented

2023-04-09 02:11:46 +02:00

Sureeeeeeeeee of course I can take test and show video on my own youtube

Kent Davis commented

2023-04-09 02:23:59 +02:00

@Harley

See my youtube to show you.
https://youtu.be/xHWDpk1HtPw

3.6.zip there for " /Users/kentdavis/Library/Application\ Support/Blender/3.6 "

@Harley See my youtube to show you. https://youtu.be/xHWDpk1HtPw 3.6.zip there for " /Users/kentdavis/Library/Application\ Support/Blender/3.6 "

3.6.zip

598 KiB

Harley Acheson commented

2023-04-09 02:52:56 +02:00

I can't tell from your video if my changes help you at all. I was hoping it would be a little more legible. Is it a little better, worse, or the same?

Kent Davis commented

2023-04-09 02:55:40 +02:00

The same.

Kent Davis commented

2023-04-09 02:59:26 +02:00

I don't know where find code Dash line on Blender.Can you tell me where code this dash?

Harley Acheson commented

2023-04-09 03:13:50 +02:00

Whoops, sorry didn't mean to close.

Harley Acheson closed this issue

2023-04-09 03:13:51 +02:00

Blender Bot added

and removed

labels 2023-04-09 03:13:52 +02:00

Harley Acheson reopened this issue

2023-04-09 03:14:16 +02:00

Blender Bot added

and removed

labels 2023-04-09 03:14:17 +02:00

Kent Davis commented

2023-04-09 03:16:48 +02:00

allright

Harley Acheson commented

2023-04-09 03:40:30 +02:00

I don't know where find code Dash line on Blender.Can you tell me where code this dash?

In the code you will see them referred to as GPU_SHADER_2D_NODELINK and GPU_SHADER_2D_NODELINK_INST', used in blender\source\blender\editors\space_graph\graph_draw.c. The actual shaders are a pair of files like gpu_shader_2D_nodelink_frag.glslandgpu_shader_2D_nodelink_vert.glsl`.

I think the central issue is that we can't pass a "length" parameter to specify the size of a dash unit. We can specify the width, the relative difference between the gap and non-gap, the opacity of the gap, colors, etc.

Fairly certain I see what we need. "gpu_shader_2D_nodelink_frag.glsl" has a define for a DASH_WIDTH as 10.0 which looks to be the length that we need to pass into it.

> I don't know where find code Dash line on Blender.Can you tell me where code this dash? In the code you will see them referred to as `GPU_SHADER_2D_NODELINK` and `GPU_SHADER_2D_NODELINK_INST', used in `blender\source\blender\editors\space_graph\graph_draw.c`. The actual shaders are a pair of files like `gpu_shader_2D_nodelink_frag.glsl` and `gpu_shader_2D_nodelink_vert.glsl`. I _think_ the central issue is that we can't pass a "length" parameter to specify the size of a dash unit. We can specify the width, the relative difference between the gap and non-gap, the opacity of the gap, colors, etc. Fairly certain I see what we need. "gpu_shader_2D_nodelink_frag.glsl" has a define for a DASH_WIDTH as 10.0 which looks to be the length that we need to pass into it.

Kent Davis commented

2023-04-09 03:52:24 +02:00

Oh I see GPU Allright.
There for Mac "Show Package Contents"
Youtube: https://youtu.be/5UlNs70JtIo

That different for windows:
blender\source\blender\editors\space_graph\graph_draw.c

Oh I see GPU Allright. There for Mac "Show Package Contents" Youtube: https://youtu.be/5UlNs70JtIo That different for windows: blender\source\blender\editors\space_graph\graph_draw.c

Harley Acheson commented

2023-04-09 04:11:17 +02:00

Sorry, these things are not in the Blender packages that are installed on users' computers for any platform. These things are in the blender source code that is edited by developers. If you had an interest in editing and compiling the Blender source code, and the applicable programming knowledge, you would start that journey here: https://wiki.blender.org/wiki/Building_Blender/Mac

Kent Davis commented

2023-04-09 04:16:45 +02:00

Thank you for send me link and I got it understand about xCode.app I know very little and I have fail to use xCode many times and I giveup myself long time ago.
No problem thank you for your discuss with me smile.

Thank you for send me link and I got it understand about xCode.app I know very little and I have fail to use xCode many times and I giveup myself long time ago. No problem thank you for your discuss with me smile.

Pratik Borhade commented

2023-04-09 04:44:56 +02:00

@PratikPB2123 Would you like to put Mac notification?

Hi, I don't think this is a MAC only issue. I'm able to redo it on Windows also.

> @PratikPB2123 Would you like to put Mac notification? Hi, I don't think this is a MAC only issue. I'm able to redo it on Windows also.

Pratik Borhade added

and removed

labels 2023-04-09 04:45:08 +02:00

Kent Davis commented

2023-04-09 04:46:57 +02:00

Allright @PratikPB2123 I get you.

Harley Acheson commented

2023-04-09 19:53:20 +02:00

With my limited shader knowledge I'm having no luck with this.

In a nutshell if we have the Resolution Scale set to 1x we have a nice display of the dashed lines at any 2D zoom. But as we increase Resolution scale we should see a decrease in the dash frequency but instead we get an increase. So effectively the dashes get smaller and the distance between decreases as Resolution scale increases, which is backwards, resulting in this issue for high-resolution displays like on Retina.

With my limited shader knowledge I'm having no luck with this. In a nutshell if we have the Resolution Scale set to 1x we have a nice display of the dashed lines at any 2D zoom. But as we increase Resolution scale we _should_ see a decrease in the dash frequency but instead we get an increase. So effectively the dashes get smaller and the distance between decreases as Resolution scale increases, which is backwards, resulting in this issue for high-resolution displays like on Retina.

Kent Davis commented

2023-04-09 20:37:46 +02:00

Yes me too I knowledge very limit about xCode.app
My iMac have Retina Display.
I did download everything complete on build Blender.xcodeproj

Yes me too I knowledge very limit about xCode.app My iMac have Retina Display. I did download everything complete on build Blender.xcodeproj

Leon Schittek referenced this issue

2023-07-17 07:58:49 +02:00

WIP: UI: Node Dashed Lines Readability #110124

Leon Schittek referenced this issue

2023-08-18 17:43:42 +02:00

Fix: Display nodelinks consistently across different UI scales #111270

Leon Schittek referenced this issue from a commit

2023-08-22 19:24:17 +02:00

Fix: Display nodelinks consistently across different UI scales

Leon Schittek referenced this issue

2023-11-10 18:19:07 +01:00

WIP: Node Editor: Improve readability of dashed node links #114716

Kent Davis commented

2024-02-19 23:07:01 +01:00

Blender 4.1.0 is resolve see picture on my iMac MacOS

You can inspect there on your iMac or MacBook or MacBook Pro before close a ticket.

Blender 4.1.0 is resolve see picture on my iMac MacOS ![image](/attachments/bb9cd62f-268c-4975-978d-7e8f0d2d44b3) You can inspect there on your iMac or MacBook or MacBook Pro before close a ticket.

image.png

5.5 MiB

❤️ 1

Pratik Borhade commented

2024-02-20 04:46:00 +01:00

Yes, looks better compared to 3.5. Closing then.

Thanks @Kent-Davis

Yes, looks better compared to 3.5. Closing then. Thanks @Kent-Davis

Pratik Borhade closed this issue

2024-02-20 04:46:04 +01:00

Blender Bot added

Status