Sculpt: Paint tool cavity custom curve crash #103013
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#103013
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Operating system: Windows 10
Graphics card: NVDIA RTX 2060 Super
Broken: 3.4, 3.5
Steps to reproduce the issue:
Enable Custom Curve under Advanced >> Cavity in the "Brush" dropdown
Result:
No Custom Curve is shown as in other Sculpting Tools & after trying to paint with the Paint tool setup this way blender instantly crashes.
Added subscriber: @Soudne
Changed status from 'Needs Triage' to: 'Confirmed'
Added subscriber: @PratikPB2123
Sculpt Mode "Paint" tool cavity custom curve crashto Sculpt: Paint tool cavity custom curve crashAdded subscriber: @JosephEagar
I can't reproduce this.
Also cannot reproduce this.
Just checking if this is still an issue for you in recent builds from https://builder.blender.org/download/daily/ @Soudne @PratikPB2123 ?
Can still confirm in current main:
63f482d55091b12324d0b78a2f151083542ccd65
Call Stack
Still cant repro.a crash, @PratikPB2123 maybe you could check if these are properly called?
Crash is because
brush->automasking_cavity_curve
is null in some cases.So I added breakpoint inside
brush_blend_read_data
, the brush in that file hasbrush->automasking_cavity_curve
null itself 👀May not be bug in blender ig
Does this fix it?
Ah, wasnt aware this is about a particular file? (was just using the repro steps from my default startup file...)
Will check your fix. This is happening in default sculpting file btw.
Instead of assigning
brush->automasking_cavity_curve
, If I doautomasking->settings.cavity_curve = BKE_sculpt_default_cavity_curve();
then crash is prevented. But my knowledge is bit short here.btw brush is passed as const in
cache_init()
@farsthary might want to check
will reset to confirmed (since @PratikPB2123 is able to repro consistently).
And since this is a crasher, will also raise priority
@PratikPB2123 - Changing the automasking settings won't be a long term fix since it still means the user would be unable to edit the curve. That struct is just used as a cache of data.
My knowledge of how the blendfile reading / writing works is limited, but doesn't the order matter between the two methods? I'm not sure if this would be the root cause of the issue, but the order appears to be mismatched.
vs
This occurs specifically with the Sculpting
startup.blend
file. When that file is loaded, it doesn't have thePaint
brush which then means that thebrush_blend_read_data
for that block is never read that is supposed to initialize this value.