Python: Add deprecation warnings to GPUBatch program usage. #103978

New Issue

Closed

opened 2023-01-18 19:11:11 +01:00 by Jeroen Bakker · 14 comments

Jeroen Bakker commented

2023-01-18 19:11:11 +01:00

Member

Calls to gpu.types.GPUBatch.draw#program without a program parameter, or a None as value of the program parameter should raise a deprecation warning.
All calls to gpu.types.GPUBatch.program_set should raise a deprecation warning..

Check pygpu_batch__tp_new how to raise a deprecation warning using CPython.

It would be great if you want to work on this topic. If so, assign the task to yourself. If you have questions or require some guidance, please get in contact via #blender-coders or via a reply on this task.

Calls to `gpu.types.GPUBatch.draw#program` without a program parameter, or a None as value of the program parameter should raise a deprecation warning. All calls to `gpu.types.GPUBatch.program_set` should raise a deprecation warning.. Check `pygpu_batch__tp_new` how to raise a deprecation warning using CPython. It would be great if you want to work on this topic. If so, assign the task to yourself. If you have questions or require some guidance, please get in contact via #blender-coders or via a reply on this task.

Jeroen Bakker commented

2023-01-18 19:11:11 +01:00

Author

Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'

Jeroen Bakker commented

2023-01-18 19:11:11 +01:00

Author

Member

Added subscriber: @Jeroen-Bakker

Added subscriber: @Jeroen-Bakker

Jash Shah commented

2023-01-29 18:46:18 +01:00

Added subscriber: @Jash-Shah

Added subscriber: @Jash-Shah

Jash Shah self-assigned this 2023-01-29 18:46:18 +01:00

Jash Shah commented

2023-01-29 18:46:18 +01:00

Hey, I am new to Blender dev, but this task seems like a good place for me to start since I have some experience working with CPython before!
As mentioned in the task description, I'm assigning the task to myself.

Hey, I am new to Blender dev, but this task seems like a good place for me to start since I have some experience working with CPython before! As mentioned in the task description, I'm assigning the task to myself.

Philipp Oeser removed the

EEVEE & Viewport

label 2023-02-09 15:11:54 +01:00

Prakhar-Singh-Chouhan commented

2023-02-21 13:50:12 +01:00

Contributor

hey, is this issue still open ??

hey, is this issue still open ??

Jeroen Bakker commented

2023-02-21 14:48:06 +01:00

Author

Member

I think so, I haven't seen any activity on this.

I think so, I haven't seen any activity on this.

Prakhar-Singh-Chouhan commented

2023-02-22 11:50:08 +01:00

Contributor

@Jeroen-Bakker could you guide me to pygpu_batch__tp_new program so i could learn how to raise a depreciation warning

@Jeroen-Bakker could you guide me to pygpu_batch__tp_new program so i could learn how to raise a depreciation warning

Prakhar-Singh-Chouhan commented

2023-02-22 12:09:02 +01:00

Contributor

nvm found it

nvm found it

Jeroen Bakker commented

2023-02-22 12:09:58 +01:00

Author

Member

It is better to ask specific code questions on blender.chat in the blender-coders channel. You can expect quicker response there, as there are more developers present to help you with your questions.

It is better to ask specific code questions on blender.chat in the blender-coders channel. You can expect quicker response there, as there are more developers present to help you with your questions.

Prakhar-Singh-Chouhan commented

2023-02-22 21:15:43 +01:00

Contributor

@Jeroen-Bakker i did some changes in the gpu.py.bacth file i'm attaching the file here could you see through it once and tell me the necessary changes i would have to do

@Jeroen-Bakker i did some changes in the gpu.py.bacth file i'm attaching the file here could you see through it once and tell me the necessary changes i would have to do

gpu_py_batch.c

11 KiB

Jeroen Bakker commented

2023-02-23 09:15:57 +01:00

Author

Member

@Prakhar-Singh-Chouhan Can you upload it as a pull request? That makes it easier to use review tools provided here.

@Prakhar-Singh-Chouhan Can you upload it as a pull request? That makes it easier to use review tools provided here.

Prakhar-Singh-Chouhan referenced a pull request that will close this issue

2023-02-24 15:29:42 +01:00

WIP: Fix #103978 Python: Add deprecation warnings to GPUBatch program usage #105174

Prakhar-Singh-Chouhan referenced a pull request that will close this issue

2023-02-28 12:51:27 +01:00

Fix #103978 Add deprecation warnings to GPUBatch program usage. #105295

Alpesh Jamgade commented

2024-01-12 05:33:01 +01:00

Hi. Is it available for me to work on? If so, I'd like to take it up.

Hi. Is it available for me to work on? If so, I'd like to take it up.

Jeroen Bakker commented

2024-01-12 15:01:08 +01:00

Author

Member

Think so. please refer to the #105295 as it already provides a solution, but needs to be updated and review comments needs to be solved.

Think so. please refer to the #105295 as it already provides a solution, but needs to be updated and review comments needs to be solved.

Prakhar-Singh-Chouhan referenced this issue

2024-01-18 18:39:13 +01:00

#103978 Add deprecation warnings to GPUBatch program usage. #117299

Prakhar-Singh-Chouhan commented

2024-01-19 04:39:50 +01:00

Contributor

@Jeroen-Bakker I updated the PR and solved the review comments. Can you have a look at it #117299

@Jeroen-Bakker I updated the PR and solved the review comments. Can you have a look at it https://projects.blender.org/blender/blender/pulls/117299

Prakhar-Singh-Chouhan referenced this issue

2024-01-19 11:44:32 +01:00

WIP #103978 Add deprecation warnings to GPUBatch program usage. #117324

Jeroen Bakker referenced this issue from a commit

2024-03-04 08:33:04 +01:00

Python: Add deprecation warnings to GPUBatch program usage

Jeroen Bakker closed this issue

2024-03-04 08:34:42 +01:00

Blender Bot added

and removed

labels 2024-03-04 08:34:44 +01:00

Jeroen Bakker added this to the 4.2 LTS milestone 2024-03-04 08:34:53 +01:00

Jeroen Bakker added this to the Python API project 2024-03-04 08:35:03 +01:00

Jash Shah was unassigned by Jeroen Bakker

2024-03-04 08:35:29 +01:00

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

4 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#103978

No description provided.