Page MenuHome

object actuator DRot reverted since Blender 246
Closed, ArchivedPublicPATCH

Description

This patch revert the values of dRot in Object Actuator in files older then Blender 246.

Since Blender 246 a bugfix handle dRot revertedly and now this patch make it easy to run old files.

To test open the file:

\physics-2.43-physics-testfiles-5\3_trampoline_ragdoll.blend ) available in http://www.blender.org/download/get-blender/

or directly:

http://mirror.cs.umn.edu/blender.org/demo/test/physics-2.43-physics-testfiles-5.zip

patched against 247

Event Timeline

The bug always existed and was only fixed in Blender 246.

(I tested it with Blender 2.24 and beyond)

So the patch is correct.

No problem with patch,

comitted in revision 16681

Benoit Bolsee (ben2610) changed the task status from Unknown Status to Unknown Status.Sep 22 2008, 7:13 PM

Thanks, it's working perfectly (the test file in fact is the ragdoll_High_Jump)

one more thing, in the readfile.c now we have three checks for the same version of Blender:

"""
if(main->versionfile < 246 || (main->versionfile == 246 && main->subversionfile < 1)) {
"""

In the Patch I was also trying to unify them.

Well I'm submiting a new patch (in this same tracker) to merge them. It's nothing special but helps make the code cleaner.

I don't think it is necessary to unified the version check; they have been added at different time to do different things and there is no performance impact.
I didn't merge them to minimize the impact on the code: no need to patch more than necessary.
For me it is just as good as it is.