Realtime PCF soft shadows support #18750

New Issue

Sebastian De LA Torre · 2009-05-14T21:49:50+02:00

2009-05-14 21:49:50 +02:00

%%%This patch adds support for pcf filtering on realtime shadows using the spotlights Samples and Soft settings.

What you get is soft realtime spotlight shadows in the viewport and GE that closely matching the internal renderer's.

It's been tested with both nvidia and ati cards on the BA forums.
%%%

%%%This patch adds support for pcf filtering on realtime shadows using the spotlights Samples and Soft settings. What you get is soft realtime spotlight shadows in the viewport and GE that closely matching the internal renderer's. It's been tested with both nvidia and ati cards on the BA forums. %%%

Sebastian De LA Torre commented

2009-05-14 21:49:50 +02:00

Changed status to: 'Open'

Erwin Coumans commented

2009-05-14 23:00:53 +02:00

%%%can you attach a .blend file showing the effect?%%%

Dalai Felinto commented

2009-05-14 23:08:02 +02:00

%%%a few comments:

shouldn't you set result as 0 or whatever before start adding values to it? (inp != 0.0 and shadowkernel > 1.0)
Why not replace all this hardcoded (if shadowkernel == ....) tests by:
"
if(shadowkernel == 1.0)
result = shadow2DProj(shadowmap, co).x;
else {
for(i=0;i<shadowkernel; i++) {

for(j=0;j<shadowkernel;j++)
 result += shadow2DProj(shadowmap, co+vec4(((j * sstep)-soffs)/co.w, (y-soffs)/co.w, 0.0, 0.0)).x;

y+= sstep;
}
}
"
void test_shadowbuf would be like: http://www.pasteall.org/5570
3) nice patch !%%%

%%%a few comments: 1) shouldn't you set result as 0 or whatever before start adding values to it? (inp != 0.0 and shadowkernel > 1.0) 2) Why not replace all this hardcoded (if shadowkernel == ....) tests by: " if(shadowkernel == 1.0) result = shadow2DProj(shadowmap, co).x; else { for(i=0;i<shadowkernel; i++) { ``` for(j=0;j<shadowkernel;j++) result += shadow2DProj(shadowmap, co+vec4(((j * sstep)-soffs)/co.w, (y-soffs)/co.w, 0.0, 0.0)).x; ``` y+= sstep; } } " void test_shadowbuf would be like: http://www.pasteall.org/5570 3) nice patch !%%%

Dalai Felinto commented

2009-05-14 23:11:43 +02:00

%%%Erwin:
softshadow.blend attached. From what I got from Sebastian's patch it's only a matter of changing Samples and Softness in the GUI.

Sebastian:
It looks like the lighting already supports softness. Do you know if the light method is the same method as the shadow?%%%

%%%Erwin: softshadow.blend attached. From what I got from Sebastian's patch it's only a matter of changing Samples and Softness in the GUI. Sebastian: It looks like the lighting already supports softness. Do you know if the light method is the same method as the shadow?%%%

Brecht Van Lommel commented

2009-05-15 14:59:04 +02:00

%%%Nice patch. However the settings don't really match the internal renderer that well in my tests? In particular the softness is much stronger in GLSL. In the test softshadow.blend file, compare the GLSL result with a shift+P preview render.

One problem if this gets committed is how to handle backwards compatibility. Right now games using shadows will have samples set quite high and so they will get a big performance degradation. If this gets committed as part of 2.5 with other compatibility changes it may not be a problem though.%%%

%%%Nice patch. However the settings don't really match the internal renderer that well in my tests? In particular the softness is much stronger in GLSL. In the test softshadow.blend file, compare the GLSL result with a shift+P preview render. One problem if this gets committed is how to handle backwards compatibility. Right now games using shadows will have samples set quite high and so they will get a big performance degradation. If this gets committed as part of 2.5 with other compatibility changes it may not be a problem though.%%%

Dalai Felinto commented

2009-05-15 18:11:49 +02:00

%%%Brecht ("how to handle backwards compatibility"):
How about an option in the GLSL menu: enable soft shadows?
Then in 2.5 we leave it enabled by default (or even remove from the menu).%%%

%%%Brecht ("how to handle backwards compatibility"): How about an option in the GLSL menu: enable soft shadows? Then in 2.5 we leave it enabled by default (or even remove from the menu).%%%

Sebastian De LA Torre commented

2009-05-16 02:06:59 +02:00

%%%Dalai Felinto, the reason is compatibility. Older PS 2.0/ATI cards do not support dynamic sized and nested loops.

Brecht Van Lommel, I've attached an improved patch(pcfshadows2.txt & the test.blend I used) that attempts to more closely match the internal renderer, and a small optimization as well.

As for compatibility, no one raised this on the BA forums so I'm not sure it's a big deal? If so I agree with a GLSL menu option.%%%

%%%Dalai Felinto, the reason is compatibility. Older PS 2.0/ATI cards do not support dynamic sized and nested loops. Brecht Van Lommel, I've attached an improved patch(pcfshadows2.txt & the test.blend I used) that attempts to more closely match the internal renderer, and a small optimization as well. As for compatibility, no one raised this on the BA forums so I'm not sure it's a big deal? If so I agree with a GLSL menu option.%%%

Campbell Barton commented

2009-07-11 21:49:25 +02:00

%%%Personally Id not worry about compatibility, games should not use a huge number of spot lamps, when people run their games in a new version of blender they often need to update a few settings.

Adding more stuff for people to have to tweak should be avoided however I think in this case its acceptable.

2c%%%

%%%Personally Id not worry about compatibility, games should not use a huge number of spot lamps, when people run their games in a new version of blender they often need to update a few settings. Adding more stuff for people to have to tweak should be avoided however I think in this case its acceptable. - 2c%%%

Mitchell Stokes commented

2009-09-20 02:26:17 +02:00

%%%This patch seemed to have gotten lost in the 2.49 pre-release madness. I've modified the patch to work with the latest trunk (23357) in hopes of getting discussion going again.

http://www.pasteall.org/8037/diff%%%

%%%This patch seemed to have gotten lost in the 2.49 pre-release madness. I've modified the patch to work with the latest trunk (23357) in hopes of getting discussion going again. http://www.pasteall.org/8037/diff%%%

Jacob F commented

2010-08-26 16:18:02 +02:00

%%%What needs to be done here to get this in trunk?%%%

Yousef Harfoush commented

2011-06-08 04:48:25 +02:00

%%%hi all
i tried to update this patch but no use :(
@mitchell
can you update this patch, it is very old and some need it, i wonder why it didn't got to trunk to now ????%%%

%%%hi all i tried to update this patch but no use :( @mitchell can you update this patch, it is very old and some need it, i wonder why it didn't got to trunk to now ????%%%

Yousef Harfoush commented

2011-11-05 05:26:05 +01:00

%%%Updated the patch to svn 41542.
attached by the file named <pcf_shadows_r41542.patch>
one question though, when it will go to trunk ?%%%

%%%Updated the patch to svn 41542. attached by the file named <pcf_shadows_r41542.patch> one question though, when it will go to trunk ?%%%

Yousef Harfoush commented

2012-05-02 00:54:29 +02:00

%%%hi
can someone update please,as i can patch no after harmony's merge
and when it will go to trunk ?%%%

%%%hi can someone update please,as i can patch no after harmony's merge and when it will go to trunk ?%%%

Brecht Van Lommel removed their assignment 2013-11-13 14:05:06 +01:00

Mitchell Stokes commented

2014-05-28 06:27:11 +02:00

Changed status from 'Open' to: 'Archived'

Mitchell Stokes closed this issue

2014-05-28 06:27:11 +02:00

Mitchell Stokes self-assigned this 2014-05-28 06:27:11 +02:00

Mitchell Stokes commented

2014-05-28 06:27:11 +02:00

We're using VSMs for soft shadows, so I don't think we really need PCF anymore.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Realtime PCF soft shadows support #18750