OBJ Exporter crashes when exporting smoothed normals in 2.5 alpha0 #20559

New Issue

Moritz Post · 2010-01-04T00:28:24+01:00

Moritz Post commented

2010-01-04 00:28:24 +01:00

%%%When setting mesh faces to smooth and exporting the normals, the export crashes. The problem is that the face does not have a reference to the VerticeMesh anymore (or so i think). The following changes fix the problem for the "if f_smooth" statement:

if EXPORT_NORMALS:
if f_smooth: # Smoothed, use vertex normals
for vi, v in enumerate(f_v):
file.write( ' %d/%d/%d' %
(v["index"] + totverts,
totuvco + uv_face_mapping[f_index][vi],
globalNormals[ veckey3d(v["vertex"].normal) ]) ) # vert, uv, normal

					else: # No smoothing, face normals
						no = globalNormals[ veckey3d(f.normal) ]
						for vi, v in enumerate(f_v):
							file.write( ' %d/%d/%d' % \
											(v["index"] + totverts,
											 totuvco + uv_face_mapping[f_index][vi],
											 no) ) # vert, uv, normal
				else: # No Normals
					for vi, v in enumerate(f_v):
						file.write( ' %d/%d' % (\
						  v["index"] + totverts,\
						  totuvco + uv_face_mapping[f_index][vi])) # vert, uv
				
				face_vert_index += len(f_v)

Hope this helps. Keep up the good work.%%%

%%%When setting mesh faces to smooth and exporting the normals, the export crashes. The problem is that the face does not have a reference to the VerticeMesh anymore (or so i think). The following changes fix the problem for the "if f_smooth" statement: if EXPORT_NORMALS: if f_smooth: # Smoothed, use vertex normals for vi, v in enumerate(f_v): file.write( ' %d/%d/%d' % \ (v["index"] + totverts, totuvco + uv_face_mapping[f_index][vi], globalNormals[ veckey3d(v["vertex"].normal) ]) ) # vert, uv, normal else: # No smoothing, face normals no = globalNormals[ veckey3d(f.normal) ] for vi, v in enumerate(f_v): file.write( ' %d/%d/%d' % \ (v["index"] + totverts, totuvco + uv_face_mapping[f_index][vi], no) ) # vert, uv, normal else: # No Normals for vi, v in enumerate(f_v): file.write( ' %d/%d' % (\ v["index"] + totverts,\ totuvco + uv_face_mapping[f_index][vi])) # vert, uv face_vert_index += len(f_v) Hope this helps. Keep up the good work.%%%

Moritz Post commented

2010-01-04 00:28:24 +01:00

Changed status to: 'Open'

Moritz Post commented

2010-01-04 00:41:33 +01:00

%%%Sorry my bad... First attempt of posting failed. The pasted snippet is wrong. The correct part is:

		if EXPORT_NORMALS:				
			if f.smooth:
				for v in me.verts:
					noKey = veckey3d(v.normal)
					if noKey not in globalNormals:
						globalNormals[noKey] = totno
						totno +=1
						file.write('vn %.6f %.6f %.6f\n' % noKey)
			else:
				for f in faces:
					# Hard, 1 normal from the face.
					noKey = veckey3d(f.normal)
					if noKey not in globalNormals:
						globalNormals[noKey] = totno
						totno +=1
						file.write('vn %.6f %.6f %.6f\n' % noKey)

Sorry. And good luck.%%%

%%%Sorry my bad... First attempt of posting failed. The pasted snippet is wrong. The correct part is: if EXPORT_NORMALS: if f.smooth: for v in me.verts: noKey = veckey3d(v.normal) if noKey not in globalNormals: globalNormals[noKey] = totno totno +=1 file.write('vn %.6f %.6f %.6f\n' % noKey) else: for f in faces: # Hard, 1 normal from the face. noKey = veckey3d(f.normal) if noKey not in globalNormals: globalNormals[noKey] = totno totno +=1 file.write('vn %.6f %.6f %.6f\n' % noKey) Sorry. And good luck.%%%

Campbell Barton commented

2010-01-06 11:50:03 +01:00

%%%Hi, I'd like to look into why this crashes further, so not ignore the patch but like to understand what goes wrong incase the API can be fixed.

also, if you can submit a patch its much more clear to me what changes.

Thanks for looking into this.%%%

%%%Hi, I'd like to look into why this crashes further, so not ignore the patch but like to understand what goes wrong incase the API can be fixed. also, if you can submit a patch its much more clear to me what changes. - Thanks for looking into this.%%%

Moritz Post commented

2010-01-06 12:45:15 +01:00

%%%Thanks for considering the changes. I wanted to present the changes in a patch file but didn't really know where in the svn repo the file was located.

The export still crashes blender from time to time as you correctly pointed out. After thinking about the fix, it actually doesn't work correct. When it finds the f_smooth flag it treats all faces as smooth although some might be set to flat.

That is ok for the project i am working on but not correct behavior.

So you should just consider this as a starting point. Anyways, thanks for looking into it.%%%

%%%Thanks for considering the changes. I wanted to present the changes in a patch file but didn't really know where in the svn repo the file was located. The export still crashes blender from time to time as you correctly pointed out. After thinking about the fix, it actually doesn't work correct. When it finds the f_smooth flag it treats all faces as smooth although some might be set to flat. That is ok for the project i am working on but not correct behavior. So you should just consider this as a starting point. Anyways, thanks for looking into it.%%%

Tom Musgrove commented

2010-03-31 11:45:34 +02:00

%%%Hi in svn they are located in blender/release/scripts/io%%%

Campbell Barton commented

2011-08-03 17:49:17 +02:00

%%%fixed in svn.%%%

Campbell Barton commented

2011-08-03 17:49:17 +02:00

Changed status from 'Open' to: 'Archived'

Campbell Barton closed this issue

2011-08-03 17:49:17 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

OBJ Exporter crashes when exporting smoothed normals in 2.5 alpha0 #20559