Add rotate option to blf module #21867

New Issue

Dan Eicher · 2010-04-01T09:04:39+02:00

Dan Eicher commented

2010-04-01 09:04:39 +02:00

%%%Added an optional angle argument to the blf.draw function to allow the text to be rotated.

I tried to wrap the BLF_default_rotation directly but it sets the global text rotation angle and if you don't reset it then... well, not really intended behavior results.

So this patch sets the angle, calls the draw function and then resets the rotation angle back to 0 which is a lot safer than the alternative.%%%

%%%Added an optional angle argument to the blf.draw function to allow the text to be rotated. I tried to wrap the BLF_default_rotation directly but it sets the global text rotation angle and if you don't reset it then... well, not really intended behavior results. So this patch sets the angle, calls the draw function and then resets the rotation angle back to 0 which is a lot safer than the alternative.%%%

Dan Eicher commented

2010-04-01 09:04:39 +02:00

Changed status to: 'Open'

Dan Eicher commented

2010-04-02 03:49:21 +02:00

%%%Version #2 with wrappers for rotate, shadow and clipping along with the helper functions to get them to work.

No idea what BLF_KERNING_DEFAULT does but threw that in as well for completeness.%%%

%%%Version #2 with wrappers for rotate, shadow and clipping along with the helper functions to get them to work. No idea what BLF_KERNING_DEFAULT does but threw that in as well for completeness.%%%

Campbell Barton commented

2010-04-02 11:44:48 +02:00

%%%Could you please make these 2 changes.

invalid blur level raise an error.
move constants into their own module eg: blf.modes.ROTATION

%%%

%%%Could you please make these 2 changes. - invalid blur level raise an error. - move constants into their own module eg: blf.modes.ROTATION %%%

Dan Eicher commented

2010-04-03 20:11:37 +02:00

%%%Ok, did #1, if blur != 0, 3 or 5 it throws an error.

On change #2, this would break consistency with the bgl module where all the constants are in the same flat namespace as the functions.

And, as we all know, Consistency is King...

Based on my own usage of this module the chances are good that the user will also be using the bgl module as well and will expect them to behave similarly when it comes to constants since they both fulfill a nearly identical roll.

Having different methods for the same thing like bgl.glEnable(bgl.GL_BLEND) and blf.enable(blf.modes.ROTATION) will just lead to confusion IMHO.

I did however remove the BLF_ prefix as per your request since blf.ROTATION is pretty nearly the same thing.%%%

%%%Ok, did #1, if blur != 0, 3 or 5 it throws an error. On change #2, this would break consistency with the bgl module where all the constants are in the same flat namespace as the functions. And, as we all know, Consistency is King... Based on my own usage of this module the chances are good that the user will also be using the bgl module as well and will expect them to behave similarly when it comes to constants since they both fulfill a nearly identical roll. Having different methods for the same thing like bgl.glEnable(bgl.GL_BLEND) and blf.enable(blf.modes.ROTATION) will just lead to confusion IMHO. I did however remove the BLF_ prefix as per your request since blf.ROTATION is pretty nearly the same thing.%%%

Campbell Barton commented

2010-04-04 15:09:24 +02:00

%%%applied patch to trunk, /w small fix, exception needed to return NULL, not -1.

re: opengl consistency, we have a number of python api's so its a choice to which once you want to match, but since this is probably used with OpenGL I can see the rationale. %%%

%%%applied patch to trunk, /w small fix, exception needed to return NULL, not -1. re: opengl consistency, we have a number of python api's so its a choice to which once you want to match, but since this is probably used with OpenGL I can see the rationale. %%%

Joshua Leung commented

2010-04-06 07:03:55 +02:00

Changed status from 'Open' to: 'Archived'

Joshua Leung closed this issue

2010-04-06 07:03:55 +02:00

Dominik Klooz commented

2013-05-31 00:48:14 +02:00

%%%This might come a liitle late, but I just noticed, that the "invalid blur level" error doesn't show up when using blf.blur() inside the Game Engine.%%%

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Add rotate option to blf module #21867