Show poselib content in outliner, apply function #23306

Closed
opened 2010-08-14 07:09:20 +02:00 by Torsten Rupp · 11 comments

%%%This patch improve patch #22805: "Show poselib content in outliner" by now also adding an "apply" function in the context menu in the outliner overview for the poselib content (open context menu in outliner with right mouse button).

The outliner show the poselib content like this:

when closed:

  • Armature
+ PoseLib

when opened:

  • Armature
    • PoseLib
      • pose name 1
      • pose name 2
      • pose name 3
  ...

A pose can be selected in the list and then applied to the current frame with the new "apply" function from the context menu. Context menu look like this:

+----------------------------+

Outliner PoseLib Operation
Unlink
Apply
+----------------------------+

BTW: the existing functions for browsing and modifying the poselib are not changed and can still be used.

It would be nice if someone may review the patch. I'm looking also forward to see the patch pushed into the repository.
%%%

%%%This patch improve patch #22805: "Show poselib content in outliner" by now also adding an "apply" function in the context menu in the outliner overview for the poselib content (open context menu in outliner with right mouse button). The outliner show the poselib content like this: when closed: - Armature ``` + PoseLib ``` when opened: - Armature - PoseLib * pose name 1 * pose name 2 * pose name 3 ``` ... ``` A pose can be selected in the list and then applied to the current frame with the new "apply" function from the context menu. Context menu look like this: +----------------------------+ | Outliner PoseLib Operation | | -- | | Unlink | | Apply | +----------------------------+ BTW: the existing functions for browsing and modifying the poselib are not changed and can still be used. It would be nice if someone may review the patch. I'm looking also forward to see the patch pushed into the repository. %%%
Author

Changed status to: 'Open'

Changed status to: 'Open'
Author

%%%update patch to r32936
%%%

%%%update patch to r32936 %%%
Author

%%%update r34026%%%

%%%update r34026%%%
Author

%%%updated to r37993
%%%

%%%updated to r37993 %%%

%%%can you update to recent trunk, as there are a lot of functionality change, thank you.%%%

%%%can you update to recent trunk, as there are a lot of functionality change, thank you.%%%
Author

%%%I will update the patch to the recent revision in trunk.
%%%

%%%I will update the patch to the recent revision in trunk. %%%
Author

%%%I updated the patch to recent trunk, r42450.

I'm looking forward to see the patch integrated.
%%%

%%%I updated the patch to recent trunk, r42450. I'm looking forward to see the patch integrated. %%%
Member

%%%Hi,

Just a quick review:
I'm not so keen on duplicating the code used to actually manipulate Pose Library data between two places, and especially in the Outliner code.

A better approach may be to separate out some of these core operations from the Pose Library operators, making ED_* api calls for them in poselib.c and exposing for use in Outliner (as well as for the operators). Certainly this would be closer in spirit to the original design of the code back in 2.4 when there were no operators, and the current operators were defined as API calls which could be used from various event handlers.

It may also be useful to look at integrating other functionality, such as deleting and renaming poses from here.

Cheers%%%

%%%Hi, Just a quick review: I'm not so keen on duplicating the code used to actually manipulate Pose Library data between two places, and especially in the Outliner code. A better approach may be to separate out some of these core operations from the Pose Library operators, making ED_* api calls for them in poselib.c and exposing for use in Outliner (as well as for the operators). Certainly this would be closer in spirit to the original design of the code back in 2.4 when there were no operators, and the current operators were defined as API calls which could be used from various event handlers. It may also be useful to look at integrating other functionality, such as deleting and renaming poses from here. Cheers%%%

Changed status from 'Open' to: 'Archived'

Changed status from 'Open' to: 'Archived'

Added subscriber: @mont29

Added subscriber: @mont29

Sounds time to archive.

Sounds time to archive.
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#23306
No description provided.