Fix for bug#27261, "GLSL shading disrespects node-material's texture's Image Mapping Extension setting" #27538

Closed
opened 2011-05-31 21:16:57 +02:00 by Vox Lapin · 10 comments

Patch for: #27261

%%%Fix for #27261. First patch, not a software engineer, be gentle. The functionality I was looking for was 99% finished. All I had to do:

  • Expose existing but hidden properies to user (Did I just touch the UI? >> send_in_the_guards.wav)
  • Moved the implicit gpu_verify_repeat() up one function in order to add a call to it in GPU_verify_image()
  • Fixed rna_image.c to reload the image on property changes

Attached patch and the fail case blend from the bug report. Fun to play with the new Realtime Settings subpanel and watch the texture respond from "infinitely tiled, who cares if you don't like it that way" to "useable for my purposes."

Open to comment & critique, obviously.%%%

**Patch for**: #27261 %%%Fix for #27261. First patch, not a software engineer, be gentle. The functionality I was looking for was 99% finished. All I had to do: * Expose existing but hidden properies to user (Did I just touch the UI? >> send_in_the_guards.wav) * Moved the implicit gpu_verify_repeat() up one function in order to add a call to it in GPU_verify_image() * Fixed rna_image.c to reload the image on property changes Attached patch and the fail case blend from the bug report. Fun to play with the new Realtime Settings subpanel and watch the texture respond from "infinitely tiled, who cares if you don't like it that way" to "useable for my purposes." Open to comment & critique, obviously.%%%
Author

Changed status to: 'Open'

Changed status to: 'Open'
Author

%%%Updated for r42447%%%

%%%Updated for r42447%%%

Added subscriber: @mont29

Added subscriber: @mont29

Is this patch sitll relevant/alive?

Is this patch sitll relevant/alive?
Antonis Ryakiotakis was assigned by Sergey Sharybin 2015-02-26 11:40:16 +01:00

Added subscribers: @Psy-Fi, @Sergey

Added subscribers: @Psy-Fi, @Sergey

@Psy-Fi, mind checking if this is still valid to have those changes?

@Psy-Fi, mind checking if this is still valid to have those changes?

I am not sure...the properties are listed as game properties in the image editor. Also rendering does not support them. I would prefer if we were to expose those to also support them in rendering as well. Apart from clamping, we already have functionality to tile images in material mode (via coordinate scaling) so there is some duplication here.

I am not sure...the properties are listed as game properties in the image editor. Also rendering does not support them. I would prefer if we were to expose those to also support them in rendering as well. Apart from clamping, we already have functionality to tile images in material mode (via coordinate scaling) so there is some duplication here.
Antonis Ryakiotakis removed their assignment 2016-01-06 20:39:10 +01:00

Added subscriber: @dfelinto

Added subscriber: @dfelinto

Changed status from 'Confirmed' to: 'Archived'

Changed status from 'Confirmed' to: 'Archived'
Dalai Felinto self-assigned this 2019-12-23 18:52:09 +01:00

Hi, thanks for your patch.

We are undergoing a Tracker Curfew where we are automatically closing old patches.

If you think the patch is still relevant please update and re-submit it. For new features make sure there is a clear design from the user level perspective.

Hi, thanks for your patch. We are undergoing a [Tracker Curfew ](https://code.blender.org/?p=3861) where we are automatically closing old patches. If you think the patch is still relevant please update and re-submit it. For new features make sure there is a clear design from the user level perspective.
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#27538
No description provided.