Drag and drop parenting in outliner #27790

New Issue

Perry Parks · 2011-06-28T04:30:45+02:00

Perry Parks commented

2011-06-28 04:30:45 +02:00

%%%This patch enables drag and drop parenting for objects in the outliner.

Drag and drop is supported for a selection of multiple objects as well. Also, all of the "special" parenting tasks (armature, curve, lattice) are possible through the usual parenting context menus. For example, drag a mesh object onto an armature and you are prompted for using bone envelopes, automatic weights, etc.

Note: exec function of the existing operator OBJECT_OT_parent_set are now API calls which take the parent object and parent type as arguments.%%%

%%%This patch enables drag and drop parenting for objects in the outliner. Drag and drop is supported for a selection of multiple objects as well. Also, all of the "special" parenting tasks (armature, curve, lattice) are possible through the usual parenting context menus. For example, drag a mesh object onto an armature and you are prompted for using bone envelopes, automatic weights, etc. Note: exec function of the existing operator OBJECT_OT_parent_set are now API calls which take the parent object and parent type as arguments.%%%

Perry Parks commented

2011-06-28 04:30:45 +02:00

Changed status to: 'Open'

Perry Parks commented

2011-06-28 07:32:01 +02:00

%%%Demonstration on Vimeo: http://vimeo.com/25698606%%%

Yousef Harfoush commented

2011-07-05 22:17:50 +02:00

%%%this does not compile with blender player on windows, i didn't check the other OS's%%%

Joshua Leung commented

2011-07-07 05:55:14 +02:00

%%%Some comments:

Code which depends deals with operators should generally be in editors NOT blenkernel. Operators are for UI editing operations, while blenkernel is more backend type stuff (including evaluation etc.).

Furthermore, you include headers for editors (ED_*.h) in blenkernel, which is bad coupling between these modules. Further evidence that this stuff is in the wrong place.

Probably the stuff in blenkernel/object.c could have gone into a relevant file in editors/object/, with the do_parent_set() method named something like ED_object_parent_set() and included in ED_object.h (and then make sure that outliner.c includes this header)

You have two sets of #defines of the various parenting types defined twice in 2 places. I suggest placing this in an existing header file, perhaps ED_object.h, and making these defines an enum instead of individual macro-defines.
Why are the forward defs needed in outliner.c? Unless I'm overlooking something, it should compile fine without.%%%

%%%Some comments: - Code which depends deals with operators should generally be in editors NOT blenkernel. Operators are for UI editing operations, while blenkernel is more backend type stuff (including evaluation etc.). Furthermore, you include headers for editors (ED_*.h) in blenkernel, which is bad coupling between these modules. Further evidence that this stuff is in the wrong place. Probably the stuff in blenkernel/object.c could have gone into a relevant file in editors/object/, with the do_parent_set() method named something like ED_object_parent_set() and included in ED_object.h (and then make sure that outliner.c includes this header) - You have two sets of #defines of the various parenting types defined twice in 2 places. I suggest placing this in an existing header file, perhaps ED_object.h, and making these defines an enum instead of individual macro-defines. - Why are the forward defs needed in outliner.c? Unless I'm overlooking something, it should compile fine without.%%%

Perry Parks commented

2011-07-08 06:06:11 +02:00

%%%Thanks for the comments Joshua! Yes, I should have realized this was the wrong place to put those methods. I guess I must not have fully understood the library layout at the time.

I've addressed all the points in your comments and have prepared another patch. This one also includes drag and drop parent clearing. Since I can't seem to be able to post an additional patch for this ticket (attachment submit gives errors), I'm temporarily linking to it on my Dropbox account:

http://dl.dropbox.com/u/1531862/drag_and_drop_v2.diff

Regarding the parent type #defines/enums, I've placed an enum (ParentType) in ED_object.h, then defined the operator properties in object_relations.c along with corresponding extern declarations in outliner.c. This seemed to be the only/best solution that I could see.

Let me know what you think!%%%

%%%Thanks for the comments Joshua! Yes, I should have realized this was the wrong place to put those methods. I guess I must not have fully understood the library layout at the time. I've addressed all the points in your comments and have prepared another patch. This one also includes drag and drop parent clearing. Since I can't seem to be able to post an additional patch for this ticket (attachment submit gives errors), I'm temporarily linking to it on my Dropbox account: http://dl.dropbox.com/u/1531862/drag_and_drop_v2.diff Regarding the parent type #defines/enums, I've placed an enum (ParentType) in ED_object.h, then defined the operator properties in object_relations.c along with corresponding extern declarations in outliner.c. This seemed to be the only/best solution that I could see. Let me know what you think!%%%

Perry Parks commented

2011-07-11 18:19:15 +02:00

%%%I have a new patch which is current with svn r38308. Also updated the dropzone definition to include the (+) icon for clearing parents.

Patch is here:

http://dl.dropbox.com/u/1531862/drag_and_drop_v3.diff%%%

%%%I have a new patch which is current with svn r38308. Also updated the dropzone definition to include the (+) icon for clearing parents. Patch is here: http://dl.dropbox.com/u/1531862/drag_and_drop_v3.diff%%%

Yousef Harfoush commented

2011-08-17 18:01:29 +02:00

%%%hi, there have been split in the outliner space files could you update your patches, thanks.%%%

Perry Parks commented

2011-08-18 20:34:18 +02:00

%%%Yes, I know there have been changes. I can update soon.%%%

Yousef Harfoush commented

2011-08-31 08:26:42 +02:00

%%%hi
just wanting to know if you updated the patches else where, or if you didn't update them, lots of users want these you know :)%%%

%%%hi just wanting to know if you updated the patches else where, or if you didn't update them, lots of users want these you know :)%%%

Perry Parks commented

2011-09-08 23:25:36 +02:00

%%%Yousef,

Yes, here is an updated patch for you. Sorry for the delay. I expected to get it done earlier but I had some other things to take care of.

Drag and drop operators now reside in outliner_edit.c. This seemed to me the most appropriate location since outliner_tools.c is primarily for right-click menu stuff.

At this point, one thing I was wondering about is my choice of tooltip on parenting and clear parent. Currently, I've left it as "Drop to Set Parent" and "Drop to Clear Parent." I'm thinking maybe it's just as well to simply use "Set Parent" and "Clear Parent."

Patch is here:
http://dl.dropbox.com/u/1531862/Blender/drag_and_drop_v4.diff%%%

%%%Yousef, Yes, here is an updated patch for you. Sorry for the delay. I expected to get it done earlier but I had some other things to take care of. Drag and drop operators now reside in outliner_edit.c. This seemed to me the most appropriate location since outliner_tools.c is primarily for right-click menu stuff. At this point, one thing I was wondering about is my choice of tooltip on parenting and clear parent. Currently, I've left it as "Drop to Set Parent" and "Drop to Clear Parent." I'm thinking maybe it's just as well to simply use "Set Parent" and "Clear Parent." Patch is here: http://dl.dropbox.com/u/1531862/Blender/drag_and_drop_v4.diff%%%

Yousef Harfoush commented

2011-11-05 07:40:05 +01:00

%%%thanks, for the last update, but know it gives this error:
http://www.pasteall.org/26094

i tried to solve it, but the error happens on lines not changed from trunk!

i use window 7 scons, msvcp1 to build, svn of r41542.%%%

%%%thanks, for the last update, but know it gives this error: http://www.pasteall.org/26094 i tried to solve it, but the error happens on lines not changed from trunk! i use window 7 scons, msvcp1 to build, svn of r41542.%%%

Yousef Harfoush commented

2011-12-10 06:50:32 +01:00

%%%updated to svn 42546, tested with scons and msvcsp1 on windows, file name -> outliner-drag_and_drop_v4_42546%%%

Joshua Leung commented

2012-01-22 11:21:04 +01:00

%%%Congrats and thanks for the patch!

Committed to SVN r.43601 :)%%%

%%%Congrats and thanks for the patch! Committed to SVN r.43601 :)%%%

Joshua Leung commented

2012-01-22 11:21:06 +01:00

Changed status from 'Open' to: 'Archived'

Joshua Leung closed this issue

2012-01-22 11:21:06 +01:00

Cenek Strichel commented

2014-02-09 19:39:22 +01:00

Added subscriber: @Cenda

Cenek Strichel commented

2014-02-09 19:39:22 +01:00

is there any possibility select multiple objects in outliner by Border select and drag n drop for parent? Or how can I select multiple objects, without clicking on all with shift and parent.

Cenek Strichel commented

2014-02-10 08:38:57 +01:00

I found that I can use border select for marking RMB and select. But it is time consuming.

Bhadresh commented

2016-12-01 16:34:11 +01:00

Added subscriber: @BDhanani

Bhadresh commented

2016-12-01 16:34:11 +01:00

In #27790#201577, @Cenda wrote:
is there any possibility select multiple objects in outliner by Border select and drag n drop for parent? Or how can I select multiple objects, without clicking on all with shift and parent.

Is it possible to select multiple objects and drag and drop for parent ?
If you know the trick, please let me know. I have started using blender recently and I need to know how to do it.

Regards,
Bhadresh

> In #27790#201577, @Cenda wrote: > is there any possibility select multiple objects in outliner by Border select and drag n drop for parent? Or how can I select multiple objects, without clicking on all with shift and parent. Is it possible to select multiple objects and drag and drop for parent ? If you know the trick, please let me know. I have started using blender recently and I need to know how to do it. Regards, Bhadresh

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Drag and drop parenting in outliner #27790