ShrinkWrap Modifier patch that adds distance threshold control #34661

Closed
opened 2013-03-17 05:52:53 +01:00 by kursad k · 8 comments
Member

%%%Hi

I made a patch that adds a distance based control to vertex and closest surface point types in Shrinkwrap modifier. The projection type has already has some kind of limiting so I did not bother delving into that one. Basically only the vertices that are below the distance value are projected and the rest are disregarded in the loop.

The distance threshold drag box shows up only under vertex and closest point types in the modifier panel

I was getting some compiler errors with some OpenMPO related stuff so I had to disable those pragmas that are in shrinkwrap.c. Please check out the commented out lines. There something to do with Apple and OpenMP as far as I can tell, the reason I commented out because I just could not figure out the error.

Here are the relevant lines

FIX OPENMP Compile Error related ?? 'not specified in enclosing parallel', I have to disable it for now#ifndef APPLE
#pragma omp parallel for default(none) private(i) firstprivate(nearest) shared(calc,treeData) schedule(static)#endif

Please check out the attacheed files for more details.

thanks

k

%%%

%%%Hi I made a patch that adds a distance based control to vertex and closest surface point types in Shrinkwrap modifier. The projection type has already has some kind of limiting so I did not bother delving into that one. Basically only the vertices that are below the distance value are projected and the rest are disregarded in the loop. The distance threshold drag box shows up only under vertex and closest point types in the modifier panel I was getting some compiler errors with some OpenMPO related stuff so I had to disable those pragmas that are in shrinkwrap.c. Please check out the commented out lines. There something to do with Apple and OpenMP as far as I can tell, the reason I commented out because I just could not figure out the error. Here are the relevant lines *FIX OPENMP Compile Error related ?? 'not specified in enclosing parallel', I have to disable it for now*#ifndef __APPLE__ *#pragma omp parallel for default(none) private(i) firstprivate(nearest) shared(calc,treeData) schedule(static)*#endif Please check out the attacheed files for more details. thanks k %%%
Author
Member

Changed status to: 'Open'

Changed status to: 'Open'

%%%just a thought so it won't break existing files or workflow if the threshold is set to 0.0 this feature would be ignored and it would work pretty much the same way as the texture baking works right now with its distance setting.%%%

%%%just a thought so it won't break existing files or workflow if the threshold is set to 0.0 this feature would be ignored and it would work pretty much the same way as the texture baking works right now with its distance setting.%%%

%%%@Fredrik Hansson, is this how it works now or how you propose it could work?%%%

%%%@Fredrik Hansson, is this how it works now or how you propose it could work?%%%

%%%from looking at the patch again well without actually testing it this time there is no such feature in this.
just a proposal to make it more like existing distance thresholds also since a threshold of 0.0 would effectively be the same as turning the modifier off.%%%

%%%from looking at the patch again well without actually testing it this time there is no such feature in this. just a proposal to make it more like existing distance thresholds also since a threshold of 0.0 would effectively be the same as turning the modifier off.%%%
Campbell Barton removed their assignment 2016-08-11 06:37:22 +02:00

Removed subscriber: @ideasman42

Removed subscriber: @ideasman42

Added subscriber: @dfelinto

Added subscriber: @dfelinto

Changed status from 'Confirmed' to: 'Archived'

Changed status from 'Confirmed' to: 'Archived'
Dalai Felinto self-assigned this 2019-12-23 18:46:17 +01:00

Hi, thanks for your patch.

We are undergoing a Tracker Curfew where we are automatically closing old patches.

If you think the patch is still relevant please update and re-submit it. For new features make sure there is a clear design from the user level perspective.

Hi, thanks for your patch. We are undergoing a [Tracker Curfew ](https://code.blender.org/?p=3861) where we are automatically closing old patches. If you think the patch is still relevant please update and re-submit it. For new features make sure there is a clear design from the user level perspective.
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#34661
No description provided.