Second character motion actuator overwirte forward motion [patch] #36703

New Issue

Thomas Szepe · 2013-09-11T16:33:48+02:00

Thomas Szepe commented

2013-09-11 16:33:48 +02:00

%%%This bug report is related to [#36329] Character physics type doesn't react to actuator?.

I know that I can enable the "Add" button to get it work. But if add is enabled and you move and rotate the rotation speed does not match with the character rotation.
I made a fix for that. I also fixed the double jump problem. Now it is possible to jump permanently and make a double jump. I also removed the now unnecessary "Add" button.

%%%

%%%This bug report is related to [#36329] Character physics type doesn't react to actuator?. I know that I can enable the "Add" button to get it work. But if add is enabled and you move and rotate the rotation speed does not match with the character rotation. I made a fix for that. I also fixed the double jump problem. Now it is possible to jump permanently and make a double jump. I also removed the now unnecessary "Add" button. %%%

Thomas Szepe commented

2013-09-11 16:33:48 +02:00

Changed status to: 'Open'

blender-admin commented

2013-09-11 16:33:48 +02:00

#40682 was marked as duplicate of this issue

Daniel Stokes commented

2013-09-12 09:02:02 +02:00

%%%Is this a new bug, or just a patch for an existing bug?%%%

Mitchell Stokes commented

2013-09-12 09:37:43 +02:00

%%%I haven't actually tested the patch, but I do see some issues with it. First off, the add button is to allow two motion actuator bricks to add movement (not just movement and rotation). For example, if I have four actuators that control 4 directions, I can combine two of those to get diagonals. It looks like your patch removes the ability to do this. Also, the motion actuator shouldn't be doing OnGround checks, this should be the responsibility of the character physics.

I've also refactored the physics code so (among other things) the motion actuator receives a character controller reference and doesn't need to keep doing nonsense with the generic physics controller. However, that's not really a problem with your patch; I'm just noting a future conflict.%%%

%%%I haven't actually tested the patch, but I do see some issues with it. First off, the add button is to allow two motion actuator bricks to add movement (not just movement and rotation). For example, if I have four actuators that control 4 directions, I can combine two of those to get diagonals. It looks like your patch removes the ability to do this. Also, the motion actuator shouldn't be doing OnGround checks, this should be the responsibility of the character physics. I've also refactored the physics code so (among other things) the motion actuator receives a character controller reference and doesn't need to keep doing nonsense with the generic physics controller. However, that's not really a problem with your patch; I'm just noting a future conflict.%%%

Thomas Szepe commented

2013-09-12 10:04:56 +02:00

%%%@daniel-34 Strokes.
It is just a patch for the existing bug.

@Mitchell Strokes.
You are right. Diagonal movement is not possible, like the other motion actuator. I am also not satisfied with OnGround check in the motion actuator.
If I have time I try to find a better solution.%%%

%%%@daniel-34 Strokes. It is just a patch for the existing bug. @Mitchell Strokes. You are right. Diagonal movement is not possible, like the other motion actuator. I am also not satisfied with OnGround check in the motion actuator. If I have time I try to find a better solution.%%%

Daniel Stokes commented

2013-09-12 22:32:53 +02:00

%%%Moved from Game Engine to Patches%%%

Thomas Szepe commented

2013-09-14 11:27:23 +02:00

%%%I uploaded a new patch. Now diagonal movement and rotation is possible.

The problem why the add button not working with rotated objects was, that GetWalkDirection() returns returns the rotated movement vector.
There are only two ways to fix that .

Rotate the GetWalkDirection() vector back.
Store the old set vector in a static variable.
I choose the the number two because it need less calculations.

About the double jump fix. I think there are no much better way to fix that. Because I need to know when the keyboard key is released. This information I only can get from the motion actuator.
I can make noJump() or keyStatus(true) method or modify the Jump(true) method to pass this information through to the character physics. But this will need the same changes as passing the onGround() to the motion actuator.
I am also not sure which class(es) you mean by character physics and generic physics controller.

I added the "Add" button back. But I think this button is unnecessary. Add can be always on. There are only two things for that it is good for.
If you don't want to move diagonally or stop with a 0,0,0 actuator. But this can be also done with the logic controllers (XOR, AND) or just by releasing the key.

%%%

%%%I uploaded a new patch. Now diagonal movement and rotation is possible. The problem why the add button not working with rotated objects was, that GetWalkDirection() returns returns the rotated movement vector. There are only two ways to fix that . 1. Rotate the GetWalkDirection() vector back. 2. Store the old set vector in a static variable. I choose the the number two because it need less calculations. About the double jump fix. I think there are no much better way to fix that. Because I need to know when the keyboard key is released. This information I only can get from the motion actuator. I can make noJump() or keyStatus(true) method or modify the Jump(true) method to pass this information through to the character physics. But this will need the same changes as passing the onGround() to the motion actuator. I am also not sure which class(es) you mean by character physics and generic physics controller. I added the "Add" button back. But I think this button is unnecessary. Add can be always on. There are only two things for that it is good for. If you don't want to move diagonally or stop with a 0,0,0 actuator. But this can be also done with the logic controllers (XOR, AND) or just by releasing the key. %%%

Sybren A. Stüvel commented

2015-04-02 22:53:12 +02:00

Added subscriber: @dr.sybren

Sybren A. Stüvel commented

2015-04-02 22:53:13 +02:00

How safe is such a static variable when there are multiple actuators?

Thomas Szepe commented

2015-04-02 23:20:27 +02:00

Normally it is save to use static variables. But what I missed to test if we add more then one Character object.

For the actual patch D1206 it is not necessary any more. It get the actual rotation and velocity directly from the object.

Normally it is save to use static variables. But what I missed to test if we add more then one Character object. For the actual patch [D1206](https://archive.blender.org/developer/D1206) it is not necessary any more. It get the actual rotation and velocity directly from the object.

blender-admin commented

2015-04-05 10:13:04 +02:00

This issue was referenced by 29e968a315

This issue was referenced by 29e968a3158b2e51a7d03b993b5e64a47ebea276

Thomas Szepe commented

2015-04-05 10:14:20 +02:00

Changed status from 'Open' to: 'Resolved'

Thomas Szepe closed this issue

2015-04-05 10:14:20 +02:00

Thomas Szepe commented

2015-04-05 10:14:20 +02:00

Closed by commit 29e968a315.