Crash making linked objects local and undo #37599

New Issue

blender-admin · 2013-11-24T15:01:58+01:00

richie967 commented

2013-11-24 15:01:58 +01:00

(Migrated from localhost:3001)

System Information
Dell Studio 1749, i3, Windows 7, 1 GB ATI Mobility Radeon HD 5650

Blender Version
Broken: Blender 2.69.0 r60995

Steps to Redo
when importing the attached blender file objects into a new blender file, using file > link, linking just the objects, then make all objects local, then move up, move down, then as soon as i click 'ctrl & z' the blender crashes,

Any ideas?

undo steps set to 32

coffee-table3.blend

**System Information** Dell Studio 1749, i3, Windows 7, 1 GB ATI Mobility Radeon HD 5650 **Blender Version** Broken: Blender 2.69.0 r60995 **Steps to Redo** when importing the attached blender file objects into a new blender file, using file > link, linking just the objects, then make all objects local, then move up, move down, then as soon as i click 'ctrl & z' the blender crashes, Any ideas? undo steps set to 32 [coffee-table3.blend](https://archive.blender.org/developer/F32136/coffee-table3.blend)

blender-admin commented

2013-11-24 15:01:58 +01:00

#39354 was marked as duplicate of this issue

richie967 commented

2013-11-24 15:01:59 +01:00

(Migrated from localhost:3001)

Changed status to: 'Open'

richie967 commented

2013-11-24 15:01:59 +01:00

(Migrated from localhost:3001)

Added subscriber: @richie967

Brecht Van Lommel commented

2013-11-24 15:11:27 +01:00

Added subscriber: @brecht

Brecht Van Lommel commented

2013-11-24 15:11:27 +01:00

Please add all the requested information about system information, blender version, steps to redo, etc, not just a title.

richie967 commented

2013-11-24 15:24:38 +01:00

(Migrated from localhost:3001)

Hi brecht,

here is some more information....

System Information
Dell Studio 1749, i3, Windows 7, 1 GB ATI Mobility Radeon HD 5650

Blender Version
Broken: Blender 2.69.0 r60995

when importing the attached blender file objects into a new blender file, using file > link, linking just the objects, then make all objects local, then move up, move down, then as soon as i click 'ctrl & z' the blender crashes,

Any ideas?

undo steps set to 32{F32136}

Hi brecht, here is some more information.... System Information Dell Studio 1749, i3, Windows 7, 1 GB ATI Mobility Radeon HD 5650 Blender Version Broken: Blender 2.69.0 r60995 when importing the attached blender file objects into a new blender file, using file > link, linking just the objects, then make all objects local, then move up, move down, then as soon as i click 'ctrl & z' the blender crashes, Any ideas? undo steps set to 32{[F32136](https://archive.blender.org/developer/F32136/coffee-table3.blend)}

Brecht Van Lommel changed title from ~~blender crashes when doing an undo 'ctrl & z'... This happens shortly after linking in an object, making it local ,moving it around, then pressing undo~~ to Crash making linked objects local and undo

2013-11-25 20:29:45 +01:00

Brecht Van Lommel commented

2013-11-25 20:30:28 +01:00

I can confirm the crash with the above steps, linking in all objects in this file.

Sergey Sharybin self-assigned this 2014-02-17 10:11:18 +01:00

Sergey Sharybin commented

2014-02-17 10:11:18 +01:00

@brecht, i couldn't really reproduce the crash. Do have:

Warning: LIB ERROR: object lost from scene: 'Scene'
LIB ERROR: object lost from scene: 'Scene'

messages in the console after the undo tho. Will have a look into this issue, but wouldn't mind having some details about crash..

@brecht, i couldn't really reproduce the crash. Do have: ``` Warning: LIB ERROR: object lost from scene: 'Scene' LIB ERROR: object lost from scene: 'Scene' ``` messages in the console after the undo tho. Will have a look into this issue, but wouldn't mind having some details about crash..

Brecht Van Lommel commented

2014-02-17 14:08:21 +01:00

thread #25: tid = 0x14d564, 0x0000000100aeb4d1 blender`BKE_curve_bevel_make(scene=0x0000000106501008, ob=0x00000001065e1c08, disp=0x0000000115f4bcb8, forRender=0, renderResolution=0) + 161 at curve.c:1641, stop reason = EXC_BAD_ACCESS (code=1, address=0x114)
  frame #0: 0x0000000100aeb4d1 blender`BKE_curve_bevel_make(scene=0x0000000106501008, ob=0x00000001065e1c08, disp=0x0000000115f4bcb8, forRender=0, renderResolution=0) + 161 at curve.c:1641
  frame #1: 0x0000000100b0fe08 blender`do_makeDispListCurveTypes(scene=0x0000000106501008, ob=0x00000001065e1c08, dispbase=0x000000010563da88, derivedFinal=0x00000001065e2120, forRender=0, forOrco=0, renderResolution=0) + 552 at displist.c:1396
  frame #2: 0x0000000100b0fbce blender`BKE_displist_make_curveTypes(scene=0x0000000106501008, ob=0x00000001065e1c08, forOrco=0) + 222 at displist.c:1612
  frame #3: 0x0000000100bf1224 blender`BKE_object_handle_update_ex(eval_ctx=0x000000010563f898, scene=0x0000000106501008, ob=0x00000001065e1c08, rbw=0x0000000000000000) + 1508 at object.c:2945
  frame #4: 0x0000000100c4924d blender`scene_update_object_func(pool=0x0000000113ad2128, taskdata=0x0000000113aabc98, threadid=6) + 285 at scene.c:1320
  frame #5: 0x0000000100dcf2b8 blender`task_scheduler_thread_run(thread_p=0x0000000105721098) + 104 at task.c:137
  frame #6: 0x00007fff85424899 libsystem_pthread.dylib`_pthread_body + 138
  frame #7: 0x00007fff8542472a libsystem_pthread.dylib`_pthread_start + 137
  frame #8: 0x00007fff85428fc9 libsystem_pthread.dylib`thread_start + 13

cu->bevobj->data and so bevcu is NULL. It's easy to add a NULL check but that doesn't seem like the right solution.

It should be possible to reproduce this if you follow these steps:

New file
File > Link, go to Objects, press A to select all, click Link
L key to make local > Selected Objects
G key to move, enter to confirm.
Ctrl + Z to undo

``` thread #25: tid = 0x14d564, 0x0000000100aeb4d1 blender`BKE_curve_bevel_make(scene=0x0000000106501008, ob=0x00000001065e1c08, disp=0x0000000115f4bcb8, forRender=0, renderResolution=0) + 161 at curve.c:1641, stop reason = EXC_BAD_ACCESS (code=1, address=0x114) frame #0: 0x0000000100aeb4d1 blender`BKE_curve_bevel_make(scene=0x0000000106501008, ob=0x00000001065e1c08, disp=0x0000000115f4bcb8, forRender=0, renderResolution=0) + 161 at curve.c:1641 frame #1: 0x0000000100b0fe08 blender`do_makeDispListCurveTypes(scene=0x0000000106501008, ob=0x00000001065e1c08, dispbase=0x000000010563da88, derivedFinal=0x00000001065e2120, forRender=0, forOrco=0, renderResolution=0) + 552 at displist.c:1396 frame #2: 0x0000000100b0fbce blender`BKE_displist_make_curveTypes(scene=0x0000000106501008, ob=0x00000001065e1c08, forOrco=0) + 222 at displist.c:1612 frame #3: 0x0000000100bf1224 blender`BKE_object_handle_update_ex(eval_ctx=0x000000010563f898, scene=0x0000000106501008, ob=0x00000001065e1c08, rbw=0x0000000000000000) + 1508 at object.c:2945 frame #4: 0x0000000100c4924d blender`scene_update_object_func(pool=0x0000000113ad2128, taskdata=0x0000000113aabc98, threadid=6) + 285 at scene.c:1320 frame #5: 0x0000000100dcf2b8 blender`task_scheduler_thread_run(thread_p=0x0000000105721098) + 104 at task.c:137 frame #6: 0x00007fff85424899 libsystem_pthread.dylib`_pthread_body + 138 frame #7: 0x00007fff8542472a libsystem_pthread.dylib`_pthread_start + 137 frame #8: 0x00007fff85428fc9 libsystem_pthread.dylib`thread_start + 13 ``` `cu->bevobj->data` and so `bevcu` is NULL. It's easy to add a NULL check but that doesn't seem like the right solution. It should be possible to reproduce this if you follow these steps: * New file * File > Link, go to Objects, press A to select all, click Link * L key to make local > Selected Objects * G key to move, enter to confirm. * Ctrl + Z to undo

Sergey Sharybin commented

2014-02-27 12:27:08 +01:00

@brecht, managed to reproduce now. Checking for NULL is not the right solution at all, we need to understand why object data is got lost.

Sergey Sharybin commented

2014-02-27 12:46:28 +01:00

@brecht, the issue is actually caused by linked curve pointing to a local object which screws up the file loading. As far as i can tell it's not really supported situation so guess proper solution would be to disallow making IDs local if they're used by other datablocks?

Brecht Van Lommel commented

2014-02-27 16:15:48 +01:00

Right, either that or making the other datablocks local automatically, but to me it seems better to refuse and let the user then use Selected Objects & Data. So yes, I think we should disallow it.