Page MenuHome

Undo/Redo don't work properly with Text Insert Mode in Text Editor
Closed, ResolvedPublic

Description

System Information
Ubuntu 13.10 32-bit
Intel Ironlake Mobile x86/MMX/SSE

Blender Version
Broken: 2.69.8 8aaf4aa

Short description of error
In Text Editor, the actions of undo or redo a previous text created with Text Insert Mode enabled (key INS), don't work properly, letting the text unrecoverable.

Exact steps for others to reproduce the error
lease, see this video. Look how each redo or undo action is immediately undone by the following one, making impossible to recover or redo the text properly.

Event Timeline

Brecht Van Lommel (brecht) triaged this task as Confirmed, Medium priority.Jan 20 2014, 7:12 PM

I had a quick look at this but don't understand the code here well. @Campbell Barton (campbellbarton) or @Justin Dailey (dail), do either of you want to take this one?

Personally I wouldn't mind if we just removed this insert key functionality entirely, it seems such an outdated thing, but maybe some people still use it.

Hi @Brecht Van Lommel (brecht),

Here is fix for this. I know I have commit access to the repo but haven't looked into setting up arc or dealing with keys yet. So feel free to commit this. Thanks! :)

Justin Dailey (dail) edited this Maniphest Task.Jan 20 2014, 10:15 PM
Justin Dailey (dail) closed this task as Resolved.Jan 20 2014, 10:15 PM

Closed by commit rB7c6f60572b24.

Thanks, committed now.

You don't need arc to commit by the way, it's just a more convenient way to do code reviews, but you would need to set up SSH keys for git.

Justin Dailey (dail) edited this Maniphest Task.May 12 2014, 4:37 PM