Crop node doesnt work procedurally #38850

Closed
opened 2014-02-26 15:11:28 +01:00 by levon hudson · 5 comments

System Information
OSX 10.8.4

Broken: in both official 2.69 release and trunk build 27/02/14 cf0120b

The crop node gets the input size/position from the original image size, not from the node being piped into it.

if you look at the attached blend file. disabling the scale node, you can see the crop is taking its dimensions from the input image, not from the scaled image.

In the bottom node tree, you can see the crop takes no notice of any transforms applied to the image.

expected behaviour would be the crop is based on 1) the output image dimensions, or ideally 2) the new dimensions of the image after it has been scaled.

crop_bug.blend

**System Information** OSX 10.8.4 Broken: in both official 2.69 release and trunk build 27/02/14 cf0120b The crop node gets the input size/position from the original image size, not from the node being piped into it. if you look at the attached blend file. disabling the scale node, you can see the crop is taking its dimensions from the input image, not from the scaled image. In the bottom node tree, you can see the crop takes no notice of any transforms applied to the image. expected behaviour would be the crop is based on 1) the output image dimensions, or ideally 2) the new dimensions of the image after it has been scaled. [crop_bug.blend](https://archive.blender.org/developer/F79037/crop_bug.blend)
Author

Changed status to: 'Open'

Changed status to: 'Open'
Author

Added subscriber: @LevonHudson

Added subscriber: @LevonHudson
Member

Added subscriber: @LukasTonne

Added subscriber: @LukasTonne
Member

"Size" in the compositor is badly defined, but not really a bug: When the crop node uses relative borders this is based on the resolution of the image. This resolution is exactly the same for the input image and the scale/translate node outputs. This is awkward behavior in itself, but it is necessary because the compositor has no other way of defining the relation of different images and node results to each other currently.

The only solution really is to implement proper canvas compositing, which defines a common "canvas space". Nodes can then have pixel resolutions on top of that to do proper sampling.

Until then this must be considered intentional, although undesirable and limiting ...

"Size" in the compositor is badly defined, but not really a bug: When the crop node uses *relative* borders this is based on the __resolution__ of the image. This resolution is exactly the same for the input image and the scale/translate node outputs. This is awkward behavior in itself, but it is necessary because the compositor has no other way of defining the relation of different images and node results to each other currently. The only solution really is to implement proper canvas compositing, which defines a common "canvas space". Nodes can then have pixel resolutions on top of that to do proper sampling. Until then this must be considered intentional, although undesirable and limiting ...

Changed status from 'Open' to: 'Archived'

Changed status from 'Open' to: 'Archived'
Campbell Barton self-assigned this 2014-02-27 03:41:51 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#38850
No description provided.