Add thousands separators to scene stats #38898

New Issue

Diego Gangl · 2014-03-01T05:28:20+01:00

Diego Gangl commented

2014-03-01 05:28:20 +01:00

This patch adds a thousands separator to the stats in the info header so they are more readable.

This patch adds a thousands separator to the stats in the info header so they are more readable. ![thousands.png](https://archive.blender.org/developer/F79306/thousands.png) [thousands-separator.patch](https://archive.blender.org/developer/F79308/thousands-separator.patch)

Diego Gangl commented

2014-03-01 05:28:20 +01:00

Changed status to: 'Open'

Diego Gangl self-assigned this 2014-03-01 05:28:20 +01:00

Diego Gangl commented

2014-03-01 05:28:20 +01:00

Added subscriber: @Januz

Diego Gangl was unassigned by Bastien Montagne

2014-03-01 13:04:51 +01:00

Brecht Van Lommel was assigned by Bastien Montagne

2014-03-01 13:04:51 +01:00

Bastien Montagne commented

2014-03-01 13:04:51 +01:00

Added subscribers: @brecht, @mont29

Bastien Montagne commented

2014-03-01 13:04:51 +01:00

I’m not sure we want to add such thing (in this case, we would also need it for any num button), not convinced it’s worth the added complexity.

Assigning to @brecht, he’s our UI chief!

I’m not sure we want to add such thing (in this case, we would also need it for any num button), not convinced it’s worth the added complexity. Assigning to @brecht, he’s our UI chief!

Brecht Van Lommel commented

2014-03-01 13:50:48 +01:00

Added subscribers: @JonathanWilliamson, @billrey, @ideasman42

Campbell Barton commented

2014-03-01 13:57:43 +01:00

If this is accepted, would like the function to be generalized and added to BLI_string.h.

I don't have a strong opinion on the patch, it can be hard to tell how many faces you have at a glance when you get over 100,000 - 1 milllion.

If this is accepted, would like the function to be generalized and added to `BLI_string.h`. I don't have a strong opinion on the patch, it can be hard to tell how many faces you have at a glance when you get over 100,000 - 1 milllion.

Brecht Van Lommel commented

2014-03-01 14:01:37 +01:00

I think this is useful, it's difficult to see now if you have 1 million or 10 million faces now.

It could be done in number buttons too but doing it only here is already an improvement. In number buttons you usually don't have to type such bigger numbers, if you do it's likely bad UI design or a case where units would help, so I wouldn't worry about that case.

I think this is useful, it's difficult to see now if you have 1 million or 10 million faces now. It could be done in number buttons too but doing it only here is already an improvement. In number buttons you usually don't have to type such bigger numbers, if you do it's likely bad UI design or a case where units would help, so I wouldn't worry about that case.

Diego Gangl commented

2014-03-02 00:29:39 +01:00

@mont29 thanks for re-assigning, I wasn't sure what to put there :P

stats_format() could be moved to BLI_string. However, one issue is that it's using locale.h to get the locale's separator, maybe it should use blender's methods (iface, etc.)?

About number buttons, the only big numbers I can see are the particles count and the blackbody node. Not sure it's worth it.

@mont29 thanks for re-assigning, I wasn't sure what to put there :P stats_format() could be moved to BLI_string. However, one issue is that it's using locale.h to get the locale's separator, maybe it should use blender's methods (iface, etc.)? About number buttons, the only big numbers I can see are the particles count and the blackbody node. Not sure it's worth it.

Campbell Barton commented

2014-03-02 02:00:08 +01:00

the separator could simply be passed as an argument.

Though not sure how important it is to support, and by the looks of it only ascii separators are supported anyway. so it could just be hard coded to use ,.

We don't use locale for number display either.

the separator could simply be passed as an argument. Though not sure how important it is to support, and by the looks of it only ascii separators are supported anyway. so it could just be hard coded to use `,`. We don't use locale for number display either.

Jonathan Williamson commented

2014-03-02 02:34:08 +01:00

I believe this is a good change. It makes things more readable and is particularly relevant in the INFO bar as those are all report numbers, not necessarily settings.

Scott Petrovic commented

2014-03-02 03:07:19 +01:00

Added subscriber: @scottyp

Scott Petrovic commented

2014-03-02 03:07:19 +01:00

I like this! +1. I can't speak for how it is implemented in the patch, but adding commas makes large numbers easier to read. It would be nice if this would carry over to make it more global, but that might be too much work for now.

David Michael Sisco commented

2014-03-02 06:26:22 +01:00

Added subscriber: @DavidSisco

David Michael Sisco commented

2014-03-02 06:26:22 +01:00

Alternative suggestion here.
What if we just start abbreviating "million" to the end if the number goes above 999,999.
Eg: instead of "10,528,000" it would show "10.5 million".
That might be even more easily recognizable at a glance.

Though that would add the issue of "what if you actually want to know exactly how many are there".
Food for thought.

Alternative suggestion here. What if we just start abbreviating "million" to the end if the number goes above 999,999. Eg: instead of "10,528,000" it would show "10.5 million". That might be even more easily recognizable at a glance. Though that would add the issue of "what if you actually want to know exactly how many are there". Food for thought.

Diego Gangl commented

2014-03-02 22:44:47 +01:00

@DavidSisco The issue with "10.5 million" is that any change below 100,000 would go unnoticed, and that's a lot of faces/verts.

New patch! with stats_format moved to BLI_string. The separator is now hardcoded with a reminder to fix it in the future.
thousands-separator2.patch

@DavidSisco The issue with "10.5 million" is that any change below 100,000 would go unnoticed, and that's a lot of faces/verts. New patch! with stats_format moved to BLI_string. The separator is now hardcoded with a reminder to fix it in the future. [thousands-separator2.patch](https://archive.blender.org/developer/F79673/thousands-separator2.patch)

Diego Gangl commented

2014-07-14 01:21:42 +02:00

Rebased so it applies again.
(Should I post this in differential instead?)

thousands-separator-3.patch

Rebased so it applies again. (Should I post this in differential instead?) [thousands-separator-3.patch](https://archive.blender.org/developer/F97749/thousands-separator-3.patch)

Campbell Barton commented

2014-07-14 01:34:06 +02:00

Yep, would be good to make a differential, otherwise its hard to give feedback.

Diego Gangl commented

2014-07-14 01:50:30 +02:00

Added Diff D646

Added Diff [D646](https://archive.blender.org/developer/D646)

Diego Gangl commented

2014-07-20 23:54:12 +02:00

Changed status from 'Open' to: 'Resolved'

Diego Gangl closed this issue

2014-07-20 23:54:12 +02:00

Diego Gangl commented

2014-07-20 23:54:12 +02:00

Patch commited, closing this.

Danilo Bargen commented

2015-02-28 21:06:32 +01:00

Added subscriber: @dbrgn

Danilo Bargen commented

2015-02-28 21:06:32 +01:00

I'm not sure if this is the right place for discussion (especially as this is closed), but some places are still missing the separator, e.g. the face count in the decimate modifier:

Any plans to add the separators there too?

I'm not sure if this is the right place for discussion (especially as this is closed), but some places are still missing the separator, e.g. the face count in the decimate modifier: ![20150228_210316.png](https://archive.blender.org/developer/F146388/20150228_210316.png) Any plans to add the separators there too?

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Add thousands separators to scene stats #38898