Skin modifier crash with null skin radii (C++ assert) #39097

Closed
opened 2014-03-10 20:58:29 +01:00 by gandalf3 · 15 comments
Member

System Information
Archlinux
Nvidia GTX 460

Blender Version
Broken: 2.7 RC1

Short description of error
Setting the skin radius to a smaller value with numinput crashes blender

Exact steps for others to reproduce the error
Based on lightnining.blend

  1. Open attached file and press Ctrl+A .5
  2. Blender crashes
**System Information** Archlinux Nvidia GTX 460 **Blender Version** Broken: 2.7 RC1 **Short description of error** Setting the skin radius to a smaller value with numinput crashes blender **Exact steps for others to reproduce the error** Based on [lightnining.blend](https://archive.blender.org/developer/F80570/lightnining.blend) 1. Open attached file and press Ctrl+A .5 2. Blender crashes
Author
Member

Changed status to: 'Open'

Changed status to: 'Open'
Author
Member

Added subscriber: @gandalf3

Added subscriber: @gandalf3

#44566 was marked as duplicate of this issue

#44566 was marked as duplicate of this issue

Added subscriber: @mont29

Added subscriber: @mont29
Bastien Montagne self-assigned this 2014-03-10 23:28:01 +01:00

Actually, issue is caused by skin radius being set to zero (the only dot in numinput will evaluate to 0…).

Actually, issue is caused by skin radius being set to zero (the only dot in numinput will evaluate to 0…).
Bastien Montagne removed their assignment 2014-03-11 00:11:16 +01:00

Grmlll… looks like this tool should not crash on Zero radius…

Not my area at all, have no clue how this stuff works… :/

Grmlll… looks like this tool should not crash on Zero radius… Not my area at all, have no clue how this stuff works… :/
Bastien Montagne changed title from Crash when using numinput to adjust skin modifier to Skin modifier crash with null skin radii (C++ assert) 2014-03-11 00:12:35 +01:00
Nicholas Bishop was assigned by Lukas Tönne 2014-03-25 17:33:03 +01:00
Member

Added subscribers: @NicholasBishop, @LukasTonne

Added subscribers: @NicholasBishop, @LukasTonne
Member

@NicholasBishop: Maybe you could have a look at this issue? I'm getting nan values in the skin modifier data. Culprit seems to be this function (maybe dangling pointers exist in Frame.merge before):
https://developer.blender.org/diffusion/B/browse/master/source/blender/modifiers/intern/MOD_skin.c;a7ed1db51fa32a80b943816d354b45b413d98fa3$1471

There was another issue in relation to skin modifier in this report: #39341
The actual regression was fixed, but if you have a look at this reduced test file Vase_Céramique4.blend1, you can see that enter/exit editmode constantly changes the vertex/face count. I'm pretty sure these two things are both related to skin modifier applied on a edge-only mesh.

@NicholasBishop: Maybe you could have a look at this issue? I'm getting `nan` values in the skin modifier data. Culprit seems to be this function (maybe dangling pointers exist in Frame.merge before): https://developer.blender.org/diffusion/B/browse/master/source/blender/modifiers/intern/MOD_skin.c;a7ed1db51fa32a80b943816d354b45b413d98fa3$1471 There was another issue in relation to skin modifier in this report: #39341 The actual regression was fixed, but if you have a look at this reduced test file [Vase_Céramique4.blend1](https://archive.blender.org/developer/F82548/Vase_Céramique4.blend1), you can see that enter/exit editmode constantly changes the vertex/face count. I'm pretty sure these two things are both related to skin modifier applied on a edge-only mesh.

Added subscribers: @ideasman42, @Sergey

Added subscribers: @ideasman42, @Sergey

@ideasman42, remember you've added some clamping to skin modifier, guess we need some more here?

@ideasman42, remember you've added some clamping to skin modifier, guess we need some more here?

@NicholasBishop, any hope you'll have a look in observable future?

@NicholasBishop, any hope you'll have a look in observable future?

Added subscriber: @michaelknubben

Added subscriber: @michaelknubben

Apologies, but I've created a new bug report about this, as I didn't find this in the search earlier.
It's #44566, and I've also attached a .blend there.
I can't edit it anymore, or I'd make it a subtask!
And as I didn't mention it in my report (can't edit), I'm on Windows 7, 64bit, with an Nvidia GTX 670 (driver: 347.52)

Apologies, but I've created a new bug report about this, as I didn't find this in the search earlier. It's #44566, and I've also attached a .blend there. I can't edit it anymore, or I'd make it a subtask! And as I didn't mention it in my report (can't edit), I'm on Windows 7, 64bit, with an Nvidia GTX 670 (driver: 347.52)

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'

7969b238db fixes this. closing.

7969b238db fixes this. closing.
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
7 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#39097
No description provided.