Compositor works poorly with Full Sample Antialiasing #39143

Closed
opened 2014-03-12 21:30:49 +01:00 by Zauber Paracelsus · 8 comments

System Information
64bit Linux Mint 16
Linux Kernel 3.11.0
nVidia GTX 650 Ti, driver 319.32

Blender Version
Broken: Broken: 2.69, 2.70 Release Candidate 1

Short description of error
When the "Full Sample" option for antialiasing is used, the compositor operates on each sample image individually, leading to a much longer time for compositing. In addition, if you edit the compositor nodes or toggle any compositor settings, then when re-applying the compositor nodes, it only applies to the first sample, requiring you to do a full re-render.

Suggested fix: Do not apply the compositor to individual antialiasing samples: only apply it to the final result of the render.

Exact steps for others to reproduce the error
Open any scene using the compositor along with the glare node. Then render both with and without Full Sample on Antialiasing.

**System Information** 64bit Linux Mint 16 Linux Kernel 3.11.0 nVidia GTX 650 Ti, driver 319.32 **Blender Version** Broken: Broken: 2.69, 2.70 Release Candidate 1 **Short description of error** When the "Full Sample" option for antialiasing is used, the compositor operates on each sample image individually, leading to a much longer time for compositing. In addition, if you edit the compositor nodes or toggle any compositor settings, then when re-applying the compositor nodes, it only applies to the first sample, requiring you to do a full re-render. Suggested fix: Do not apply the compositor to individual antialiasing samples: only apply it to the final result of the render. **Exact steps for others to reproduce the error** Open any scene using the compositor along with the glare node. Then render both with and without Full Sample on Antialiasing.

Changed status to: 'Open'

Changed status to: 'Open'

Added subscriber: @ZauberParacelsus

Added subscriber: @ZauberParacelsus

As an additional note, this can also cause the composited image to appear incorrectly. For example, the use of a glare node might appear brighter than it should be. I've uploaded some examples below:

Without Full Sample: FullSampleTest_Off.png
With Full Sample: FullSampleTest_On.png

As an additional note, this can also cause the composited image to appear incorrectly. For example, the use of a glare node might appear brighter than it should be. I've uploaded some examples below: **Without Full Sample:** ![FullSampleTest_Off.png](https://archive.blender.org/developer/F80872/FullSampleTest_Off.png) **With Full Sample:** ![FullSampleTest_On.png](https://archive.blender.org/developer/F80874/FullSampleTest_On.png)

Added subscriber: @Ace_Dragon

Added subscriber: @Ace_Dragon

This is more or less due to how FSA works at the moment.

For FSA to even work like it does now, it needs to take multiple samples of the entire composited image (which the only way to get those samples is to re-composite multiple times).

As for the FSA disappearing when a setting is changed, this has been a limitation of the system since its initial implementation (more in the line of missing functionality rather than a bug). In general, I believe that people would usually get the compositing right first and then render using FSA, but reworking the implementation so that it does the anti-aliasing process over again on a setting change (or implementing a new system which doesn't require 4-8-16 re-composites) is not really seen to be in bug territory.

This is more or less due to how FSA works at the moment. For FSA to even work like it does now, it needs to take multiple samples of the entire composited image (which the only way to get those samples is to re-composite multiple times). As for the FSA disappearing when a setting is changed, this has been a limitation of the system since its initial implementation (more in the line of missing functionality rather than a bug). In general, I believe that people would usually get the compositing right first and then render using FSA, but reworking the implementation so that it does the anti-aliasing process over again on a setting change (or implementing a new system which doesn't require 4-8-16 re-composites) is not really seen to be in bug territory.

Well, for right now I'm using FSA to work around an issue I have, where surfaces with high emission will have heavier aliasing than other surfaces. Are there any other workarounds I could try?

Well, for right now I'm using FSA to work around an issue I have, where surfaces with high emission will have heavier aliasing than other surfaces. Are there any other workarounds I could try?

Changed status from 'Open' to: 'Archived'

Changed status from 'Open' to: 'Archived'
Sergey Sharybin self-assigned this 2014-03-13 08:38:11 +01:00

Thanks for the report, but it's obviously not a bug but a specific of how compositor is designed at this moment. Improvements are possible but they're considered a TODO. Made sure this report is listed in our wiki: http://wiki.blender.org/index.php/Dev:2.5/Source/Development/Todo/Tools#Compositing

Thanks for the report, but it's obviously not a bug but a specific of how compositor is designed at this moment. Improvements are possible but they're considered a TODO. Made sure this report is listed in our wiki: http://wiki.blender.org/index.php/Dev:2.5/Source/Development/Todo/Tools#Compositing
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#39143
No description provided.