Rig>Deform:Curve bones>Segment 32 (ease in 0 ease out0) ..max rotation causes this segmented bone stop rotating and flips #39491

New Issue

yellow foxz · 2014-03-28T19:51:26+01:00

yellow foxz commented

2014-03-28 19:51:26 +01:00

System Information
Operating system and graphics card
win 7 64bits, intel default graphic
Blender Version
Broken: (example: 2.69.7 4b206af, see splash screen)
broken very ;atest blender 2.70 official released

Short description of error
download this file..i have created.>>Bug_Deform.blend
Exact steps for others to reproduce the error
download file above....hard to explain !

**System Information** Operating system and graphics card win 7 64bits, intel default graphic **Blender Version** Broken: (example: 2.69.7 4b206af, see splash screen) broken very ;atest blender 2.70 official released **Short description of error** download this file..i have created.>>[Bug_Deform.blend](https://archive.blender.org/developer/F83256/Bug_Deform.blend) **Exact steps for others to reproduce the error** download file above....hard to explain !

yellow foxz commented

2014-03-28 19:51:26 +01:00

Changed status to: 'Open'

yellow foxz commented

2014-03-28 19:51:26 +01:00

Added subscriber: @yellowfoxz

Bastien Montagne was assigned by Sergey Sharybin

2014-04-10 19:18:02 +02:00

Sergey Sharybin commented

2014-04-10 19:18:02 +02:00

Added subscriber: @Sergey

Sergey Sharybin commented

2014-04-10 19:18:02 +02:00

Another bone issues. Mind having a look? :)

Bastien Montagne commented

2014-04-27 14:58:04 +02:00

Added subscriber: @JoshuaLeung

Bastien Montagne commented

2014-04-27 14:58:04 +02:00

So, that small patch seems to fix that glitch (yet another '-180° to 180° gap' one).

P52: #39491

diff --git a/source/blender/blenkernel/intern/armature.c b/source/blender/blenkernel/intern/armature.c
index 3920f59..5f4beab 100644
--- a/source/blender/blenkernel/intern/armature.c
+++ b/source/blender/blenkernel/intern/armature.c
@@ -506,7 +506,7 @@ void b_bone_spline_setup(bPoseChannel *pchan, int rest, Mat4 result_array[MAX_BB
 			invert_m3_m3(imat3, mat3);
 			mul_m3_m3m3(mat3, result, imat3); /* the matrix transforming vec_roll to desired roll */
 
-			roll1 = (float)atan2(mat3- [x]- [x], mat3- [x][2]);
+			roll1 = angle_compat_rad((float)atan2(mat3- [x]- [x], mat3- [x]- [x]), pchan->prev_roll1);
 		}
 	}
 	else {
@@ -544,14 +544,14 @@ void b_bone_spline_setup(bPoseChannel *pchan, int rest, Mat4 result_array[MAX_BB
 		invert_m3_m3(imat3, mat3);
 		mul_m3_m3m3(mat3, imat3, result); /* the matrix transforming vec_roll to desired roll */
 
-		roll2 = (float)atan2(mat3- [x]- [x], mat3- [x][2]);
+		roll2 = angle_compat_rad((float)atan2(mat3- [x]- [x], mat3- [x]- [x]), pchan->prev_roll2);
 
 		/* and only now negate handle */
 		mul_v3_fl(h2, -hlength2);
 	}
 	else {
 		h2- [x] = 0.0f; h2- [x] = -hlength2; h2- [x] = 0.0f;
-		roll2 = 0.0;
+		roll2 = 0.0f;
 	}
 
 	/* make curve */
@@ -578,6 +578,9 @@ void b_bone_spline_setup(bPoseChannel *pchan, int rest, Mat4 result_array[MAX_BB
 			mul_serie_m4(result_array- [x].mat, iscalemat, result_array- [x].mat, scalemat, NULL, NULL, NULL, NULL, NULL);
 		}
 	}
+
+	pchan->prev_roll1 = roll1;
+	pchan->prev_roll2 = roll2;
 }
 
 /* ************ Armature Deform ******************* */
diff --git a/source/blender/makesdna/DNA_action_types.h b/source/blender/makesdna/DNA_action_types.h
index dab825c..026f75c 100644
--- a/source/blender/makesdna/DNA_action_types.h
+++ b/source/blender/makesdna/DNA_action_types.h
@@ -239,6 +239,10 @@ typedef struct bPoseChannel {
 	float ikrotweight;              /* weight of joint rotation constraint */
 	float iklinweight;              /* weight of joint stretch constraint */
 
+	/* For handling BBones. */
+	float prev_roll1;
+	float prev_roll2;
+
 	void        *temp;              /* use for outliner */
 } bPoseChannel;

Now, I’m not quite sure about it… Piling bbones + IK + other constraints leads us to lands of hyper-complications. Joshua, thoughts here?

So, that small patch seems to fix that glitch (yet another '-180° to 180° gap' one). [P52: #39491](https://archive.blender.org/developer/P52.txt) ```diff diff --git a/source/blender/blenkernel/intern/armature.c b/source/blender/blenkernel/intern/armature.c index 3920f59..5f4beab 100644 --- a/source/blender/blenkernel/intern/armature.c +++ b/source/blender/blenkernel/intern/armature.c @@ -506,7 +506,7 @@ void b_bone_spline_setup(bPoseChannel *pchan, int rest, Mat4 result_array[MAX_BB invert_m3_m3(imat3, mat3); mul_m3_m3m3(mat3, result, imat3); /* the matrix transforming vec_roll to desired roll */ - roll1 = (float)atan2(mat3- [x]- [x], mat3- [x][2]); + roll1 = angle_compat_rad((float)atan2(mat3- [x]- [x], mat3- [x]- [x]), pchan->prev_roll1); } } else { @@ -544,14 +544,14 @@ void b_bone_spline_setup(bPoseChannel *pchan, int rest, Mat4 result_array[MAX_BB invert_m3_m3(imat3, mat3); mul_m3_m3m3(mat3, imat3, result); /* the matrix transforming vec_roll to desired roll */ - roll2 = (float)atan2(mat3- [x]- [x], mat3- [x][2]); + roll2 = angle_compat_rad((float)atan2(mat3- [x]- [x], mat3- [x]- [x]), pchan->prev_roll2); /* and only now negate handle */ mul_v3_fl(h2, -hlength2); } else { h2- [x] = 0.0f; h2- [x] = -hlength2; h2- [x] = 0.0f; - roll2 = 0.0; + roll2 = 0.0f; } /* make curve */ @@ -578,6 +578,9 @@ void b_bone_spline_setup(bPoseChannel *pchan, int rest, Mat4 result_array[MAX_BB mul_serie_m4(result_array- [x].mat, iscalemat, result_array- [x].mat, scalemat, NULL, NULL, NULL, NULL, NULL); } } + + pchan->prev_roll1 = roll1; + pchan->prev_roll2 = roll2; } /* ************ Armature Deform ******************* */ diff --git a/source/blender/makesdna/DNA_action_types.h b/source/blender/makesdna/DNA_action_types.h index dab825c..026f75c 100644 --- a/source/blender/makesdna/DNA_action_types.h +++ b/source/blender/makesdna/DNA_action_types.h @@ -239,6 +239,10 @@ typedef struct bPoseChannel { float ikrotweight; /* weight of joint rotation constraint */ float iklinweight; /* weight of joint stretch constraint */ + /* For handling BBones. */ + float prev_roll1; + float prev_roll2; + void *temp; /* use for outliner */ } bPoseChannel; ``` Now, I’m not quite sure about it… Piling bbones + IK + other constraints leads us to lands of hyper-complications. Joshua, thoughts here?

Campbell Barton commented

2014-06-04 03:01:48 +02:00

Added subscriber: @ideasman42

Campbell Barton commented

2014-06-04 03:01:48 +02:00

@mont29: relying on the previous roll seems risky, it means you can't reliably jump to a frame and be sure the pose state will the the same as when played from the beginning.

Bastien Montagne commented

2014-06-04 11:53:43 +02:00

Yes… TBH, I would be tempted to close this as "known limitation"/TODO… Rotation handling in current constraints is really week anyway.

Bastien Montagne commented

2014-06-16 14:05:47 +02:00

Changed status from 'Open' to: 'Archived'

Bastien Montagne closed this issue

2014-06-16 14:05:47 +02:00

Bastien Montagne commented

2014-06-16 14:05:47 +02:00

Closing as TODO (see http://wiki.blender.org/index.php/Dev:2.5/Source/Development/Todo/Animation#Armature), pretty sure we can’t fix this in a correct way with current code…

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Rig>Deform:Curve bones>Segment 32 (ease in 0 ease out0) ..max rotation causes this segmented bone stop rotating and flips #39491