Page MenuHome

Unused omp firstprivate variable sphdata at line 4439 of particle.c
Closed, ResolvedPublic

Description

My omp is fairly rudimentary, but the VS2013 compiler warns that sphdata is unreferenced at Line 4439 in particle.c:

#pragma omp parallel for firstprivate (sphdata) private (pa) schedule(dynamic,5) /* sphdata unreferenced */

				LOOP_DYNAMIC_PARTICLES {
					basic_integrate(sim, p, pa->state.time, cfra);
				}

is this intentional?

Event Timeline

John Pavel (jrp) set Type to Bug.
John Pavel (jrp) created this task.
John Pavel (jrp) raised the priority of this task from to Needs Triage by Developer.

Fair enough - yes, that's unintentional. It is required for the other loops, but not that one. Do you want to commit a fix? Otherwise I can.

John Pavel (jrp) added a comment.EditedApr 12 2014, 1:06 PM

I don't have commit access, so can I leave it to you, please, @Alex Fraser (z0r)?