Timeline/Frame ranges inconsistencies in UI #39689

Open
opened 2014-04-12 16:10:21 +02:00 by Bastien Montagne · 14 comments

#39484 raised that timeline frame range representation actually show (real_length - 1) interval… So e.g. a scene having same start and end frame is shown as zero length. This is also inconsistent with how caches are drawn in same window (they start at -0.5 frame and end at +0.5 frame), which allows to represent the real length, assuming 'frame' itself as a sort of “center” value.

To fix #39484 I simply made same thing for frame range, but this was to quick in fact, we need a design decision here and make it consistent in all time-related windows (timeline, VSE, MCE, animations, etc.).

@sebastian_k proposed to rather draw a [start, end+1] interval, adding a small green square of one frame width to the cursor:

Image_2014-04-12_at_3.44.20_nachm..png

#39484 raised that timeline frame range representation actually show (real_length - 1) interval… So e.g. a scene having same start and end frame is shown as zero length. This is also inconsistent with how caches are drawn in same window (they start at -0.5 frame and end at +0.5 frame), which allows to represent the real length, assuming 'frame' itself as a sort of “center” value. To fix #39484 I simply made same thing for frame range, but this was to quick in fact, we need a design decision here and make it consistent in all time-related windows (timeline, VSE, MCE, animations, etc.). @sebastian_k proposed to rather draw a [start, end+1] interval, adding a small green square of one frame width to the cursor: ![Image_2014-04-12_at_3.44.20_nachm..png](https://archive.blender.org/developer/F84651/Image_2014-04-12_at_3.44.20_nachm..png)
Author
Owner

Changed status to: 'Open'

Changed status to: 'Open'
Author
Owner
Added subscribers: @mont29, @brecht, @JonathanWilliamson, @sebastian_k

#46092 was marked as duplicate of this issue

#46092 was marked as duplicate of this issue

Added subscribers: @BassamKurdali, @JoshuaLeung, @cessen

Added subscribers: @BassamKurdali, @JoshuaLeung, @cessen

Every solution here has a downside, either the duration is 'wrong', or the start/end frames are in 'wrong' place. It depends which one you care about more.

Personally I have no preference here. Maybe the animation team should be consulted here @JoshuaLeung, @cessen, @bassamk.

Every solution here has a downside, either the duration is 'wrong', or the start/end frames are in 'wrong' place. It depends which one you care about more. Personally I have no preference here. Maybe the animation team should be consulted here @JoshuaLeung, @cessen, @bassamk.

Added subscriber: @willi-2

Added subscriber: @willi-2
Member

I'm fine with sebastian's proposal though the 'wrongness' doesn't really bother me; some notes:

  • probably best to stay consistent in all the time editors
  • some things like keyframes don't have a 'duration' as such - I guess it is fine if they show up at the beginning of the one frame interval
I'm fine with sebastian's proposal though the 'wrongness' doesn't really bother me; some notes: - probably best to stay consistent in all the time editors - some things like keyframes don't have a 'duration' as such - I guess it is fine if they show up at the beginning of the one frame interval
Bastien Montagne self-assigned this 2014-04-17 14:17:04 +02:00
Author
Owner

Ok, will try to get a patch working this way (and yes, keyframes should not be 'extended', only the currframe cursor would get that small 'one frame' green block ;) ).

Ok, will try to get a patch working this way (and yes, keyframes should not be 'extended', only the currframe cursor would get that small 'one frame' green block ;) ).
Member

Personally, I haven't actually ever been bothered by the current display. Agreed with @BassamKurdali's point regarding keyframes not having a "duration" - this is one of the things that is different between the way we display things vs say the dopesheet in Maya.

If it does matter that the end frame doesn't stop abruptly on the end-frame value, perhaps the range could be something like [start, end + 0.9] or so. Apart from that no other changes are needed.

Personally, I haven't actually ever been bothered by the current display. Agreed with @BassamKurdali's point regarding keyframes not having a "duration" - this is one of the things that is different between the way we display things vs say the dopesheet in Maya. If it does matter that the end frame doesn't stop abruptly on the end-frame value, perhaps the range could be something like [start, end + 0.9] or so. Apart from that no other changes are needed.

Didn't want to meddle with design decisions, but as I raised #39484...: To me, a rectangle enclosing the current frame would be most intuitive:
Bild305.png
All frames are light-gray (including end frame), and labels are in the center of the frame.

Didn't want to meddle with design decisions, but as I raised #39484...: To me, a rectangle enclosing the current frame would be most intuitive: ![Bild305.png](https://archive.blender.org/developer/F85085/Bild305.png) All frames are light-gray (including end frame), and labels are in the center of the frame.

Oh, and regarding key frames in the dope sheet window: It must be a dot (visualized as a diamond ) because it marks the point in time when a property has a certain value. This can also be somewhere in the middle of a frame (ctrl+MouseMove while grabbing), and there could be multiple key frames within a scene's frame. Just my 2c.

Oh, and regarding key frames in the dope sheet window: It must be a dot (visualized as a diamond ) because it marks *the point in time* when a property has a certain value. This can also be somewhere in the middle of a frame (ctrl+MouseMove while grabbing), and there could be multiple key frames within a scene's frame. Just my 2c.
Author
Owner

Once again, yes, it’s obvious keyframes are not concerned here, since they are a precise time position, and have no duration per se.

I think we all agree to the same solution (to summarize: extend last frame to get real range, add '1frame' visualization block to currtime cursor, like it’s already done in some places), so will propose a patch about this, it will be easier to talk from it (when I have time, this ain’t exactly top priority topic either ;) ).

Once again, yes, it’s obvious keyframes are not concerned here, since they are a precise time position, and have no duration *per se*. I think we all agree to the same solution (to summarize: extend last frame to get real range, add '1frame' visualization block to currtime cursor, like it’s already done in some places), so will propose a patch about this, it will be easier to talk from it (when I have time, this ain’t exactly top priority topic either ;) ).

Sorry, I just see this task's type is "design", not "bug". Accidently went the wrong way. Won't happen again. :)

Sorry, I just see this task's type is "design", not "bug". Accidently went the wrong way. Won't happen again. :)
Author
Owner

Added subscriber: @techstig

Added subscriber: @techstig
Philipp Oeser removed the
Interest
User Interface
label 2023-02-10 09:26:33 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
6 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#39689
No description provided.