Hotkey is not displayed in the node editor's menu #39867

New Issue

lopata · 2014-04-23T21:05:54+02:00

lopata commented

2014-04-23 21:05:54 +02:00

Win7 x64

blender-2.70-0f91d2c-win64-vc12

Win7 x64 blender-2.70-0f91d2c-win64-vc12 [no_hotkey.blend](https://archive.blender.org/developer/F85756/no_hotkey.blend) ![2.jpg](https://archive.blender.org/developer/F85759/2.jpg)

lopata commented

2014-04-23 21:05:54 +02:00

Changed status to: 'Open'

lopata commented

2014-04-23 21:05:54 +02:00

Added subscriber: @lopataasdf

Bastien Montagne commented

2014-04-23 22:17:08 +02:00

Added subscribers: @ideasman42, @mont29

Bastien Montagne commented

2014-04-23 22:17:08 +02:00

Okay, so issue here is comparing floats. Menu entry is set to exactly 0.833, while shortcut is set to exactly 0.83333, so menu func checking for shortcuts does not find any one valid for value 0.833.

We can simply fix this by making both values really the same, but I wonder if it would not be better to have some 'nearlyequal' comparison in idprop.c’s IDP_EqualsProperties_ex? Campbell, what do you think? Could this backfire in other places/cases? As far as I can see, the only use of this func is in wm_keymap.c…

Okay, so issue here is comparing floats. Menu entry is set to exactly 0.833, while shortcut is set to exactly 0.83333, so menu func checking for shortcuts does not find any one valid for value 0.833. We can simply fix this by making both values really the same, but I wonder if it would not be better to have some 'nearlyequal' comparison in idprop.c’s `IDP_EqualsProperties_ex`? Campbell, what do you think? Could this backfire in other places/cases? As far as I can see, the only use of this func is in wm_keymap.c…

Bastien Montagne self-assigned this 2014-04-23 22:17:15 +02:00

blender-admin commented

2014-04-24 16:48:43 +02:00

This issue was referenced by blender/blender-addons-contrib@258a9b5fc1

This issue was referenced by blender/blender-addons-contrib@258a9b5fc1f024a371bd43cefeb94a5b2d1f3ce5

blender-admin commented

2014-04-24 16:48:43 +02:00

This issue was referenced by 258a9b5fc1

This issue was referenced by 258a9b5fc1f024a371bd43cefeb94a5b2d1f3ce5

Bastien Montagne commented

2014-04-24 16:50:02 +02:00

Changed status from 'Open' to: 'Resolved'