Page MenuHome

Cycles Baking - Branched path tracing sample values have no effect
Closed, ResolvedPublic

Description

System Information
Win 7 64-bit

Blender Version
8904eaf

Short description of error
Branched Path Tracing sample values do not contribute to sample quality of bakes. Only AA samples or straight path tracing.

Exact steps for others to reproduce the error
Try to bake with BPT

Event Timeline

Matt Heimlich (m9105826) set Type to Bug.
Matt Heimlich (m9105826) created this task.
Matt Heimlich (m9105826) raised the priority of this task from to Needs Triage by Developer.

Yes, compute_light_pass() only takes AA samples into account now. I am not sure if we should add the complexity here.

Thomas Dinges (dingto) triaged this task as Normal priority.May 11 2014, 10:39 AM

@Thomas Dinges (dingto) isn't it only a matter of setting the aa samples of the branched settings instead? (totally unfamiliar with branched from a user or dev point of view)

We already use the Branched Path or Path Trace AA samples, that's set inside of kernel_data.integrator.aa_samples.

What Matt means, are the dedicated Diffuse, Glossy, SSS... samples that Branched Path offers. Basically we would need another for() loop inside of the existing one for each Sample Type. I think this is overkill for baking. What do you think @Brecht Van Lommel (brecht) ?

Well, it would mean making separate AO, SSS and integrate lighting functions for branched path and calling them, just like has been done for regular path tracing already.

I think that can work fine, add some if/else to check for the branched case and call the appropriate functions.