Gradient background in hsv curve widget doesn't zoom properly + patch to fix #40185

New Issue

Henrik Aarnio · 2014-05-13T23:24:54+02:00

Henrik Aarnio commented

2014-05-13 23:24:54 +02:00

Blender Version
Broken: all versions up to current trunk

Short description of error
Hsv color adjust curve widget (in "hue correct" node and the corresponding VSE strip modifier) has a hue color gradient background. When using the zoom buttons on the widget, the background gradient does not scale according to the zoom, rather it stays at fixed size, and fills the whole widged area only if it is viewed at lower left corner, otherwise the ending point of the gradient is visible and the gradient doesn't match the curve points.

Exact steps for others to reproduce the error
Open blender, switch to compositor and enable nodes. Add a hue correct node, zoom in and move the curve widged navigation around. Notice obvious mismatch between the gradient's location and zoom level, and that of the curve points, and how they don't match.

Apply attached patch and test again to see the problem fixed.hsv_gradient_fix.diff

**Blender Version** Broken: all versions up to current trunk **Short description of error** Hsv color adjust curve widget (in "hue correct" node and the corresponding VSE strip modifier) has a hue color gradient background. When using the zoom buttons on the widget, the background gradient does not scale according to the zoom, rather it stays at fixed size, and fills the whole widged area only if it is viewed at lower left corner, otherwise the ending point of the gradient is visible and the gradient doesn't match the curve points. **Exact steps for others to reproduce the error** Open blender, switch to compositor and enable nodes. Add a hue correct node, zoom in and move the curve widged navigation around. Notice obvious mismatch between the gradient's location and zoom level, and that of the curve points, and how they don't match. Apply attached patch and test again to see the problem fixed.[hsv_gradient_fix.diff](https://archive.blender.org/developer/F88879/hsv_gradient_fix.diff)

Henrik Aarnio commented

2014-05-13 23:24:54 +02:00

Changed status to: 'Open'

Henrik Aarnio commented

2014-05-13 23:24:54 +02:00

Added subscriber: @hjaarnio

Henrik Aarnio commented

2014-05-13 23:31:03 +02:00

Should note that unnecessary calculation of the y-zoom of the gradient was removed, since the area should just be filled from bottom to top in the y direction, regardless of zoom level.

Henrik Aarnio changed title from ~~Gradient background in hsv curve widget doesn't zoom properly~~ to Gradient background in hsv curve widget doesn't zoom properly + patch to fix

2014-05-13 23:35:40 +02:00

Kévin Dietrich commented

2014-05-13 23:52:47 +02:00

Added subscriber: @kevindietrich

Kévin Dietrich commented

2014-05-13 23:52:47 +02:00

A blendfile demonstrating the error (maybe some screenshots too) could have been great. Can confirm the issue, but cannot test your patch (I'm not at home...).

Here's a blendfile setup for the compositor: untitled.blend (I've hit the zoom button a couple of time)

(Do not care about the weird drawing...)

A blendfile demonstrating the error (maybe some screenshots too) could have been great. Can confirm the issue, but cannot test your patch (I'm not at home...). Here's a blendfile setup for the compositor: [untitled.blend](https://archive.blender.org/developer/F88880/untitled.blend) (I've hit the zoom button a couple of time) ![untitled.blend.png](https://archive.blender.org/developer/F88881/untitled.blend.png) (Do not care about the weird drawing...)

Campbell Barton commented

2014-05-14 01:38:38 +02:00

Changed status from 'Open' to: 'Resolved'

Campbell Barton closed this issue

2014-05-14 01:38:38 +02:00

Campbell Barton self-assigned this 2014-05-14 01:38:38 +02:00

Campbell Barton commented

2014-05-14 01:38:38 +02:00

This fix wasnt quite right, committed fix 30361a7341

This fix wasnt quite right, committed fix 30361a7341

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Gradient background in hsv curve widget doesn't zoom properly + patch to fix #40185