fcurve cleaning #40279

Closed
opened 2014-05-20 13:29:39 +02:00 by ju val · 10 comments
Member

In the Graph Editor
My opinion is that end user can be frustrated by the curve cleaning behavior:
it only remove doublons without any further process
A good behavior would be to remove more points
My purposal is to base thresholding not on difference between neighboor points but on a an integration...:
To know if i add a point i check its influence on the integral of the cleaned curve
Don't know how to explain this so i post my code
keyframes_general-clean_fcurve.c

In the Graph Editor My opinion is that end user can be frustrated by the curve cleaning behavior: it only remove doublons without any further process A good behavior would be to remove more points My purposal is to base thresholding not on difference between neighboor points but on a an integration...: To know if i add a point i check its influence on the integral of the cleaned curve Don't know how to explain this so i post my code [keyframes_general-clean_fcurve.c](https://archive.blender.org/developer/F89504/keyframes_general-clean_fcurve.c)
Author
Member

Changed status to: 'Open'

Changed status to: 'Open'
Author
Member

Added subscriber: @julienvalentin

Added subscriber: @julienvalentin
Author
Member

sorry, the code is dirty because I don't know if it's worth while as curve_simplify.py (for blender<=2.59) features are much more elaborated

sorry, the code is dirty because I don't know if it's worth while as curve_simplify.py (for blender<=2.59) features are much more elaborated

Added subscriber: @ideasman42

Added subscriber: @ideasman42

Not sure whats suggested.

I think the term cleaning is a bit vague.

Suggest:

  • rename "Remove Doubles"
  • add a tool "Simplify" - can port code from ./release/scripts/addons/curve_simplify.py which reduces density of overly complicated curves.
Not sure whats suggested. I think the term `cleaning` is a bit vague. Suggest: - rename "Remove Doubles" - add a tool "Simplify" - can port code from `./release/scripts/addons/curve_simplify.py` which reduces density of overly complicated curves.
Author
Member

Sorry campbellbarton , I can't edit the task....

My point is from a end user perspective:
In graph editor:

  • When he presses Shift+O : the curve is sampled on a regular basis
  • So when he presses O: he expects to have the inverse behavior but doublon removal is not the inverse of sampling so he's frustrated

This inverse behavior should be a simplifier (with a default low threshold) rather than a doubles removal
Moreover, double removal is pretty the same thing as simplification with very low threshold isn't it?
And according python documentation:

 bpy.ops.action.clean(threshold=0.001)
 Simplify F-Curves by removing closely spaced keyframes

For me it sound obvious and doesn't require semantic argues on the meaning of "cleaning"...

I attached a picture of the behavior of my patch image3004.png

Sorry campbellbarton , I can't edit the task.... My point is from a end user perspective: In graph editor: - When he presses Shift+O : the curve is sampled on a regular basis - So when he presses O: he expects to have the inverse behavior but doublon removal is not the inverse of sampling so he's frustrated This inverse behavior should be a simplifier (with a default low threshold) rather than a doubles removal Moreover, double removal is pretty the same thing as simplification with very low threshold isn't it? And according python documentation: ``` bpy.ops.action.clean(threshold=0.001) Simplify F-Curves by removing closely spaced keyframes ``` For me it sound obvious and doesn't require semantic argues on the meaning of "cleaning"... I attached a picture of the behavior of my patch ![image3004.png](https://archive.blender.org/developer/F89513/image3004.png)
Author
Member

An other problem is that /scripts/addons/curve_simplify.py is not working anymore with BF>=2.6

An other problem is that /scripts/addons/curve_simplify.py is not working anymore with BF>=2.6
Joshua Leung was assigned by Campbell Barton 2015-02-26 11:56:07 +01:00

Added subscriber: @dfelinto

Added subscriber: @dfelinto

Changed status from 'Confirmed' to: 'Archived'

Changed status from 'Confirmed' to: 'Archived'

Hi, thanks for your patch.

We are undergoing a Tracker Curfew where we are automatically closing old patches.

If you think the patch is still relevant please update and re-submit it. For new features make sure there is a clear design from the user level perspective.

Hi, thanks for your patch. We are undergoing a [Tracker Curfew ](https://code.blender.org/?p=3861) where we are automatically closing old patches. If you think the patch is still relevant please update and re-submit it. For new features make sure there is a clear design from the user level perspective.
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#40279
No description provided.