Viewport has 8fps if i open Animation viewports. #40372

New Issue

paul geraskin · 2014-05-26T22:13:48+02:00

paul geraskin commented

2014-05-26 22:13:48 +02:00

System Information
Linux 64,

Blender Version
2.70.5 nightly build.

Short description of error
I get 8 fps if i do like this: http://youtu.be/yJcMInvQ1jU

Here is test file https://developer.blender.org/F124318

Exact steps for others to reproduce the error

**System Information** Linux 64, **Blender Version** 2.70.5 nightly build. **Short description of error** I get 8 fps if i do like this: http://youtu.be/yJcMInvQ1jU Here is test file https://developer.blender.org/F124318 **Exact steps for others to reproduce the error**

paul geraskin commented

2014-05-26 22:13:48 +02:00

Changed status to: 'Open'

paul geraskin commented

2014-05-26 22:13:48 +02:00

Added subscriber: @PaulGeraskin

Joshua Leung was assigned by Campbell Barton

2014-05-27 03:30:53 +02:00

Campbell Barton commented

2014-05-27 03:30:53 +02:00

Added subscriber: @ideasman42

Campbell Barton commented

2014-05-27 03:30:53 +02:00

Not sure I'd consider this a bug, but functions findzero and berekeny are quite heavy here.

Its calling fcurve_eval_keyframes a lot

Attached a patch which skips complex handle calculation when there is no need. but its not really solving the problem, just a small workaround.

fcurve_skip_findzero.diff

Other possible speedups.

Cache result of binarysearch_bezt_index_ex, so drawing (or any other caller), which does ordered lookups can avoid doing a full binary search each time.
Store per-space draw-cache for evaluated fcurves, this way redraws and playback would be fast, however transforming all curves or panning would remain slow.
Have a maximum number of steps to show, (rather then pixels), perhaps one sample per frame (probably OK for beziers, not so nice for some easing options).
Use a 2D array and have a function to fill in the points, take advantage of the ability to cache lookups.

Not sure I'd consider this a bug, but functions `findzero` and `berekeny` are quite heavy here. Its calling `fcurve_eval_keyframes` a *lot* Attached a patch which skips complex handle calculation when there is no need. but its not really solving the problem, just a small workaround. [fcurve_skip_findzero.diff](https://archive.blender.org/developer/F91346/fcurve_skip_findzero.diff) Other possible speedups. * Cache result of `binarysearch_bezt_index_ex`, so drawing (or any other caller), which does ordered lookups can avoid doing a full binary search each time. * Store per-space draw-cache for evaluated fcurves, this way redraws and playback would be fast, however transforming all curves or panning would remain slow. * Have a maximum number of steps to show, (rather then pixels), perhaps one sample per frame (probably OK for beziers, not so nice for some easing options). * Use a 2D array and have a function to fill in the points, take advantage of the ability to cache lookups.

Fazekas Laszlo commented

2014-05-28 22:10:24 +02:00

Added subscriber: @totoro-4

Fazekas Laszlo commented

2014-05-28 22:10:24 +02:00

Perhaps it redraws the whole view in every frame step? It requires 25 redraws/sec... For panning, zooming, modifying the curves etc. maybe a lower rate is quite enough. Maybe you can speed up the playback also if you redraw only the changed part at the cursor (if possible).

Lukas Tönne commented

2014-07-10 11:48:29 +02:00

Added subscriber: @LukasTonne

Lukas Tönne commented

2014-07-10 11:48:29 +02:00

I noticed that the fps issue becomes a lot worse for small x-axis intervals (zooming in on frames) - which seems odd given that this would contain a lot less frames and thus should require fewer fcurve evals. Zooming out OTOH gives fluid framerates.

Joshua Leung commented

2014-07-10 12:01:34 +02:00

@LukasTonne:
The reason is that when zoomed in, it needs to sample the curve many more times to fill the gaps between keyframes, while when zoomed out, we can just plot the keyframes and be done.

As for fixing this, I'm currently leaning towards the following option:
For the majority of cases, it would be nice to move back to using the old sample-free code for the segments where actually sampling isn't necessary. That should resolve the performance problems for most users most of the time that this generally isn't a big issue. Sure, the issues still exist when dealing with fancy curves, but at least in the foreseeable future, these won't be such a big deal yet.

I'm personally not fond of using any form of caches anywhere - at least until we've completely and thoroughly exhausted every other alternative. They are a pain to get working seamlessly - our buggered pointcaches are one of the many examples of how this can go so wrong.

@LukasTonne: The reason is that when zoomed in, it needs to sample the curve many more times to fill the gaps between keyframes, while when zoomed out, we can just plot the keyframes and be done. As for fixing this, I'm currently leaning towards the following option: For the majority of cases, it would be nice to move back to using the old sample-free code for the segments where actually sampling isn't necessary. That should resolve the performance problems for most users most of the time that this generally isn't a big issue. Sure, the issues still exist when dealing with fancy curves, but at least in the foreseeable future, these won't be such a big deal yet. I'm personally not fond of using any form of caches anywhere - at least until we've completely and thoroughly exhausted every other alternative. They are a pain to get working seamlessly - our buggered pointcaches are one of the many examples of how this can go so wrong.

Fazekas Laszlo commented

2014-07-10 15:21:24 +02:00

Also, maybe if you zoom out it is not necessary to refresh at each frames, only when the cursor really moves (when 1 pixel > 1 frame)

blender-admin commented

2014-11-16 11:32:56 +01:00

This issue was referenced by f0a2e714b3

This issue was referenced by f0a2e714b3c0149c02014d2735e713b9b1b81eff

Joshua Leung commented

2014-11-16 11:34:23 +01:00

Changed status from 'Open' to: 'Resolved'

Joshua Leung closed this issue

2014-11-16 11:34:23 +01:00

Joshua Leung commented

2014-11-16 11:34:23 +01:00

Closed by commit f0a2e714b3.

Closed by commit f0a2e714b3.

paul geraskin commented

2014-11-16 20:00:22 +01:00

Thanks!

paul geraskin commented

2014-11-16 21:37:48 +01:00

character_test_fps.blend

I removed the file from the dropbox. i attached here it for any cases.

[character_test_fps.blend](https://archive.blender.org/developer/F124318/character_test_fps.blend) I removed the file from the dropbox. i attached here it for any cases.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Viewport has 8fps if i open Animation viewports. #40372