Wrong Undo on curves #41226

New Issue

Karja Krähwald · 2014-07-28T21:51:38+02:00

Karja Krähwald commented

2014-07-28 21:51:38 +02:00

System Information
Windows 7 64, HD 5770

Blender Version
Broken: 2.71 release & e0d8e62

Short description of error
Extrude and Undo on a curves startpoint messes up the point order (numbering?) when Undo is executed in a different "Editmode session".
This negatively affects points that are assigned to a Hook.

Its complicated to describe, please take a look in the file.

Exact steps for others to reproduce the error
ConfusedHookpoints.blend

Setup for Hook:

Add a NurbsPath (Curve), add an Empty.
Give Curve a Hook Modifier.
Set Empty as Hook, and assign the middle control point of Curve.

Move Empty, Curve point should move aswell.

Bug:

Go into Curves Editmode.
Select the starting point and extrude one time.
Leave Editmode and enter again = different Editmode.
Undo your extruded starting point with STRG+Z.
Problem:
The assigned Hook point has changed. (move Empty)
It has shifted one point forward, related to extrude actions.

**System Information** Windows 7 64, HD 5770 **Blender Version** Broken: 2.71 release & e0d8e62 **Short description of error** Extrude and Undo on a curves startpoint messes up the point order (numbering?) when Undo is executed in a different "Editmode session". This negatively affects points that are assigned to a Hook. Its complicated to describe, please take a look in the file. **Exact steps for others to reproduce the error** [ConfusedHookpoints.blend](https://archive.blender.org/developer/F100059/ConfusedHookpoints.blend) >Setup for Hook: 1. Add a NurbsPath (Curve), add an Empty. 2. Give Curve a Hook Modifier. 3. Set Empty as Hook, and assign the middle control point of Curve. - Move Empty, Curve point should move aswell. >Bug: 1. Go into Curves Editmode. 2. Select the starting point and extrude one time. 3. Leave Editmode and enter again = different Editmode. 4. Undo your extruded starting point with STRG+Z. Problem: The assigned Hook point has changed. (move Empty) It has shifted one point forward, related to extrude actions.

Karja Krähwald commented

2014-07-28 21:51:38 +02:00

Changed status to: 'Open'

Karja Krähwald commented

2014-07-28 21:51:38 +02:00

Added subscriber: @karja

Sergey Sharybin was assigned by Bastien Montagne

2014-07-29 12:33:05 +02:00

Bastien Montagne commented

2014-07-29 12:33:05 +02:00

Added subscriber: @mont29

Bastien Montagne commented

2014-07-29 12:33:05 +02:00

Sergey, you know this area of code. :)

blender-admin commented

2014-07-31 14:21:57 +02:00

This issue was referenced by e042c8428f

This issue was referenced by e042c8428f8c0c0a72cdd23d2c058c20ab5745ed

Sergey Sharybin commented

2014-07-31 14:22:32 +02:00

Changed status from 'Open' to: 'Resolved'

Sergey Sharybin closed this issue

2014-07-31 14:22:32 +02:00

Sergey Sharybin commented

2014-07-31 14:22:32 +02:00

Closed by commit e042c8428f.

Closed by commit e042c8428f.

Sergey Sharybin commented

2014-07-31 14:22:34 +02:00

Committed the fix, please give it a good test with tonight's builds from builder.b.o.

Karja Krähwald commented

2014-07-31 23:10:03 +02:00

Hey,

I have tested bcbbed0 from Thu Jul 31 15:12:50 2014 with the same file.

If i extrude the startpoint 1 time, it works in every scenario.
If i extrude the startpoint 2 times, the Hookpoint changes now without additional Undo after leaving Editmode. I cant correct this with Undo in the same Editmode, i now have to be in a different Editmode for Undo.
If i extrude the startpoint 3 times, the Hookpoint stays correct. But Undo dont work correct anymore for the Hookpoint, no matter what Editmode. Also Blender tends to crash quite often if i Undo (Object&Editmode).

Hey, I have tested bcbbed0 from Thu Jul 31 15:12:50 2014 with the same file. - If i extrude the startpoint 1 time, it works in every scenario. - If i extrude the startpoint 2 times, the Hookpoint changes now without additional Undo after leaving Editmode. I cant correct this with Undo in the same Editmode, i now have to be in a different Editmode for Undo. - If i extrude the startpoint 3 times, the Hookpoint stays correct. But Undo dont work correct anymore for the Hookpoint, no matter what Editmode. Also Blender tends to crash quite often if i Undo (Object&Editmode).

Sergey Sharybin commented

2014-08-01 06:25:48 +02:00

Changed status from 'Resolved' to: 'Open'

Sergey Sharybin reopened this issue

2014-08-01 06:25:48 +02:00

blender-admin commented

2014-08-01 08:30:41 +02:00

This issue was referenced by 2f2bf513e9

This issue was referenced by 2f2bf513e97a3955f3d98582bf7e837ca44b8009

Sergey Sharybin commented

2014-08-01 08:32:53 +02:00

Changed status from 'Open' to: 'Resolved'

Sergey Sharybin closed this issue

2014-08-01 08:32:53 +02:00

Sergey Sharybin commented

2014-08-01 08:32:53 +02:00

Closed by commit 2f2bf513e9.

Closed by commit 2f2bf513e9.

Sergey Sharybin commented

2014-08-01 08:35:45 +02:00

Changed status from 'Resolved' to: 'Open'

Sergey Sharybin reopened this issue

2014-08-01 08:35:45 +02:00

Sergey Sharybin commented

2014-08-01 08:35:45 +02:00

Eh, was reverting previous fix which wasn't correct. Still looking into a more proper one.

Sergey Sharybin commented

2014-08-01 09:39:35 +02:00

Changed status from 'Open' to: 'Archived'

Sergey Sharybin closed this issue

2014-08-01 09:39:35 +02:00

Sergey Sharybin commented

2014-08-01 09:39:35 +02:00

After rather long investigation we came to a conclusion this is not gonna to work reliably with the current separation of global and local undo stacks. Even if steps above are supported there are still loads of ways to confuse the system.

Also, the same exact issues happens for the meshes, they might be not so trivial to reproduce, but it's still possible to have rather simple setup which demonstrates the same issue.

Moving it to a undo stack TODO: http://wiki.blender.org/index.php/Dev:2.5/Source/Development/Todo/UserInterface#Undo_stack

There are quite a few issues are caused by the local undo stacks and modifying global data..

After rather long investigation we came to a conclusion this is not gonna to work reliably with the current separation of global and local undo stacks. Even if steps above are supported there are still loads of ways to confuse the system. Also, the same exact issues happens for the meshes, they might be not so trivial to reproduce, but it's still possible to have rather simple setup which demonstrates the same issue. Moving it to a undo stack TODO: http://wiki.blender.org/index.php/Dev:2.5/Source/Development/Todo/UserInterface#Undo_stack There are quite a few issues are caused by the local undo stacks and modifying global data..

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Wrong Undo on curves #41226