Discrepancy in release process #41280

New Issue

Shane Ambler · 2014-08-01T08:04:47+02:00

Shane Ambler commented

2014-08-01 08:04:47 +02:00

Blender Version
Broken: 2.71 binary release
Worked: 2.71 source tarball

It appears there is an issue with the release process. While at least two features are known to exist in the official 2.71 release source tarball, they do not appear in 2.71 binary releases.

On 16 June commit 8c16f4c7d0 added
BGE: New Property sensor evaluation types
This patch adds "Less Than" and "Greater Than" evaluation types to the property sensor.

On 13 June commit 3de3987ea1 added
Cycles: Add dedicated nodes to split/combine vectors.

According to the blender download page and the 2.71 tag creation - 2.71 was released on 26 June so these two could be expected to be included.

My build from the release tarball has both of these features (I'm on FreeBSD so I don't have an official binary release to test). I have had two separate people say that one of these is not present and a third person confirm that both are not present in a binary release of 2.71

This leads to the question - do the release builds get final bug fixes before release? are any new bugs introduced through other commits that shouldn't be added to release?

**Blender Version** Broken: 2.71 binary release Worked: 2.71 source tarball It appears there is an issue with the release process. While at least two features are known to exist in the official 2.71 release source tarball, they do not appear in 2.71 binary releases. On 16 June commit 8c16f4c7d0 added BGE: New Property sensor evaluation types This patch adds "Less Than" and "Greater Than" evaluation types to the property sensor. On 13 June commit 3de3987ea1 added Cycles: Add dedicated nodes to split/combine vectors. According to the blender download page and the 2.71 tag creation - 2.71 was released on 26 June so these two could be expected to be included. My build from the release tarball has both of these features (I'm on FreeBSD so I don't have an official binary release to test). I have had two separate people say that one of these is not present and a third person confirm that both are not present in a binary release of 2.71 This leads to the question - do the release builds get final bug fixes before release? are any new bugs introduced through other commits that shouldn't be added to release?

Shane Ambler commented

2014-08-01 08:04:47 +02:00

Changed status to: 'Open'

Shane Ambler commented

2014-08-01 08:04:47 +02:00

Added subscriber: @sambler

Sergey Sharybin commented

2014-08-01 09:47:29 +02:00

Added subscriber: @Sergey

Sergey Sharybin commented

2014-08-01 09:47:29 +02:00

You've got wrong assumption here, only features which existed at the time of rc1 are to be expected in the final release. Only crucial fixes made after the rc1 tag are backported to the final release. And rc1 was created 13th jun.

So the issue is that the source tarball is created from the master branch, not the release tag.

You've got wrong assumption here, only features which existed at the time of rc1 are to be expected in the final release. Only crucial fixes made after the rc1 tag are backported to the final release. And rc1 was created 13th jun. So the issue is that the source tarball is created from the master branch, not the release tag.

gandalf3 commented

2014-08-01 09:54:08 +02:00

Added subscriber: @gandalf3

Bastien Montagne commented

2014-08-01 13:12:28 +02:00

Added subscriber: @mont29

Kent Mein commented

2014-08-07 16:21:27 +02:00

Added subscriber: @KentMein

Kent Mein commented

2014-08-07 16:21:27 +02:00

I use a perl script to generate the files and it does basically the following:
$VERSION = "v2.71"
git clone --recursive git://git.blender.org/blender.git blender-$VERSION
cd blender-$VERSION;git fetch --tags
git submodule foreach git fetch --tags
git checkout $VERSION
git submodule update --recursive

rm -rf blender-$VERSION/.git blender-$VERSION/.???*
/bin/tar cfvz blender-$VERSION.tar.gz blender-$VERSION

I'll check it to see whats going on.

I use a perl script to generate the files and it does basically the following: $VERSION = "v2.71" git clone --recursive git://git.blender.org/blender.git blender-$VERSION cd blender-$VERSION;git fetch --tags git submodule foreach git fetch --tags git checkout $VERSION git submodule update --recursive rm -rf blender-$VERSION/.git blender-$VERSION/.???* /bin/tar cfvz blender-$VERSION.tar.gz blender-$VERSION I'll check it to see whats going on.

Kent Mein commented

2014-08-07 18:42:12 +02:00

I'm not entirely sure what happened here. I reran the script again and it produced a tar file that is
different than the current one. I took a look at two files from the mentioned patches and it is
indeed different.

When I check the timestamp on the file:

ls -ld blender-2.71.tar.gz

rw-rw-r-- 1 mein wheel 57120144 Jun 27 14:23 blender-2.71.tar.gz

my guess is that I maybe ran the tar earlier than the tag, or there were changes made to the tag after
the tagging later... In general though the sources are created from the tag. since we remove the
.git dir from the source before uploading it, I can't do much more debugging. I'm open to suggestions on how to change things to avoid issues in the future though.

I'm going to update the source now so that it matches whats tagged.

Kent

I'm not entirely sure what happened here. I reran the script again and it produced a tar file that is different than the current one. I took a look at two files from the mentioned patches and it is indeed different. When I check the timestamp on the file: ls -ld blender-2.71.tar.gz - rw-rw-r-- 1 mein wheel 57120144 Jun 27 14:23 blender-2.71.tar.gz my guess is that I maybe ran the tar earlier than the tag, or there were changes made to the tag after the tagging later... In general though the sources are created from the tag. since we remove the .git dir from the source before uploading it, I can't do much more debugging. I'm open to suggestions on how to change things to avoid issues in the future though. I'm going to update the source now so that it matches whats tagged. Kent

Kent Mein commented

2014-08-07 19:07:42 +02:00

Changed status from 'Open' to: 'Resolved'

Kent Mein closed this issue

2014-08-07 19:07:42 +02:00

Kent Mein commented

2014-08-07 19:08:39 +02:00

I resolved this, I've updated the source and I'll add a step to make sure the tag is there before uploading just to be safe.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Discrepancy in release process #41280