With small units, cannot adjust Normals so well. #41308

New Issue

Bastien Montagne · 2014-08-04T02:34:51+02:00

Charlieb000 commented

2014-08-04 02:34:51 +02:00

(Migrated from localhost:3001)

Set the units to Metric and scale to 0.001 (milimeters) on the properties toolbar (scene)
create a torus (well its worse on that) then go show the normals and adjust their size by dragging the arrows - even with the shift key it isnt good. Can the size of the normal lines be dependant on the size of the face, ie %. This way it wont go nutty and gives visual priority to the larger faces. (sorry this is a bit of an idea besides a bug).

By the way, how can i always enable normals?

Set the units to Metric and scale to 0.001 (milimeters) on the properties toolbar (scene) create a torus (well its worse on that) then go show the normals and adjust their size by dragging the arrows - even with the shift key it isnt good. Can the size of the normal lines be dependant on the size of the face, ie %. This way it wont go nutty and gives visual priority to the larger faces. (sorry this is a bit of an idea besides a bug). By the way, how can i always enable normals?

Charlieb000 commented

2014-08-04 02:34:51 +02:00

(Migrated from localhost:3001)

Changed status to: 'Open'

Charlieb000 commented

2014-08-04 02:34:51 +02:00

(Migrated from localhost:3001)

Added subscriber: @Charlieb000

Charlieb000 commented

2014-08-04 02:39:10 +02:00

(Migrated from localhost:3001)

Ah. it seems i cannot "always enable" but if i add things while in edit mode with the normals enabled beforehand then it will be created with normals enabled.

Bastien Montagne self-assigned this 2014-08-04 10:59:36 +02:00

Bastien Montagne commented

2014-08-04 10:59:36 +02:00

Normals are always enabled, the only thing you can control is their visualization in Edit mode. And adding in Edit mode means you add some geometry to current object, instead of adding a new object, this is not the same thing at all.

As for normals, I'll see whether it’s possible to set them from bbox dimensions, would make sense imho.

Normals are always enabled, the only thing you can control is their visualization in Edit mode. And adding in Edit mode means you add some geometry to current object, instead of adding a new object, this is not the same thing at all. As for normals, I'll see whether it’s possible to set them from bbox dimensions, would make sense imho.

Bastien Montagne commented

2014-08-04 17:26:41 +02:00

For the record, here is a patch weighting normal size from global mesh's dimensions… Rejected for now though (can have bad effects in some corner cases too).

P113: #41308

diff --git a/source/blender/editors/space_view3d/drawobject.c b/source/blender/editors/space_view3d/drawobject.c
index 8d39632..a4c0ef4 100644
--- a/source/blender/editors/space_view3d/drawobject.c
+++ b/source/blender/editors/space_view3d/drawobject.c
@@ -2138,6 +2138,21 @@ static void drawSelectedVertices(DerivedMesh *dm, Mesh *me)
  * logic!!!
  */
 
+static float compute_normal_size(Object *ob, Scene *scene)
+{
+	float min- [x], max- [x], mat- [x][4];
+
+	INIT_MINMAX(min, max);
+	BKE_object_minmax(ob, min, max, false);
+	sub_v3_v3(max, min);
+
+	/* Bring back in global space. */
+	invert_m4_m4(mat, ob->obmat);
+	mul_mat3_m4_v3(mat, max);
+
+	return scene->toolsettings->normalsize * len_v3(max);
+}
+
 static void calcDrawDMNormalScale(Object *ob, drawDMNormal_userData *data)
 {
 	float obmat- [x][3];
@@ -2184,7 +2199,7 @@ static void draw_dm_face_normals(BMEditMesh *em, Scene *scene, Object *ob, Deriv
 	drawDMNormal_userData data;
 
 	data.bm = em->bm;
-	data.normalsize = scene->toolsettings->normalsize;
+	data.normalsize = compute_normal_size(ob, scene);
 
 	calcDrawDMNormalScale(ob, &data);
 
@@ -2249,7 +2264,7 @@ static void draw_dm_vert_normals(BMEditMesh *em, Scene *scene, Object *ob, Deriv
 	drawDMNormal_userData data;
 
 	data.bm = em->bm;
-	data.normalsize = scene->toolsettings->normalsize;
+	data.normalsize = compute_normal_size(ob, scene);
 
 	calcDrawDMNormalScale(ob, &data);
 
@@ -2643,7 +2658,7 @@ static void draw_dm_loop_normals(BMEditMesh *em, Scene *scene, Object *ob, Deriv
 	drawDMNormal_userData data;
 
 	data.bm = em->bm;
-	data.normalsize = scene->toolsettings->normalsize;
+	data.normalsize = compute_normal_size(ob, scene);
 
 	calcDrawDMNormalScale(ob, &data);
 
diff --git a/source/blender/makesrna/intern/rna_scene.c b/source/blender/makesrna/intern/rna_scene.c
index 1c6d0fa..f2edf70 100644
--- a/source/blender/makesrna/intern/rna_scene.c
+++ b/source/blender/makesrna/intern/rna_scene.c
@@ -1872,11 +1872,12 @@ static void rna_def_tool_settings(BlenderRNA  *brna)
 	RNA_def_property_ui_text(prop, "Proportional Size", "Display size for proportional editing circle");
 	RNA_def_property_range(prop, 0.00001, 5000.0);
 	
-	prop = RNA_def_property(srna, "normal_size", PROP_FLOAT, PROP_DISTANCE);
+	prop = RNA_def_property(srna, "normal_size", PROP_FLOAT, PROP_FACTOR);
 	RNA_def_property_float_sdna(prop, NULL, "normalsize");
-	RNA_def_property_ui_text(prop, "Normal Size", "Display size for normals in the 3D view");
-	RNA_def_property_range(prop, 0.00001, 1000.0);
-	RNA_def_property_ui_range(prop, 0.01, 10.0, 10.0, 2);
+	RNA_def_property_ui_text(prop, "Normal Size",
+	                         "Display size for normals in the 3D view (proportional to global mesh's size)");
+	RNA_def_property_range(prop, 0.001, 100.0);
+	RNA_def_property_ui_range(prop, 0.01, 2.0, 1.0, 2);
 	RNA_def_property_update(prop, NC_GEOM | ND_DATA, NULL);
 
 	prop = RNA_def_property(srna, "double_threshold", PROP_FLOAT, PROP_DISTANCE);

For the record, here is a patch weighting normal size from global mesh's dimensions… Rejected for now though (can have bad effects in some corner cases too). [P113: #41308](https://archive.blender.org/developer/P113.txt) ``` diff --git a/source/blender/editors/space_view3d/drawobject.c b/source/blender/editors/space_view3d/drawobject.c index 8d39632..a4c0ef4 100644 --- a/source/blender/editors/space_view3d/drawobject.c +++ b/source/blender/editors/space_view3d/drawobject.c @@ -2138,6 +2138,21 @@ static void drawSelectedVertices(DerivedMesh *dm, Mesh *me) * logic!!! */ +static float compute_normal_size(Object *ob, Scene *scene) +{ + float min- [x], max- [x], mat- [x][4]; + + INIT_MINMAX(min, max); + BKE_object_minmax(ob, min, max, false); + sub_v3_v3(max, min); + + /* Bring back in global space. */ + invert_m4_m4(mat, ob->obmat); + mul_mat3_m4_v3(mat, max); + + return scene->toolsettings->normalsize * len_v3(max); +} + static void calcDrawDMNormalScale(Object *ob, drawDMNormal_userData *data) { float obmat- [x][3]; @@ -2184,7 +2199,7 @@ static void draw_dm_face_normals(BMEditMesh *em, Scene *scene, Object *ob, Deriv drawDMNormal_userData data; data.bm = em->bm; - data.normalsize = scene->toolsettings->normalsize; + data.normalsize = compute_normal_size(ob, scene); calcDrawDMNormalScale(ob, &data); @@ -2249,7 +2264,7 @@ static void draw_dm_vert_normals(BMEditMesh *em, Scene *scene, Object *ob, Deriv drawDMNormal_userData data; data.bm = em->bm; - data.normalsize = scene->toolsettings->normalsize; + data.normalsize = compute_normal_size(ob, scene); calcDrawDMNormalScale(ob, &data); @@ -2643,7 +2658,7 @@ static void draw_dm_loop_normals(BMEditMesh *em, Scene *scene, Object *ob, Deriv drawDMNormal_userData data; data.bm = em->bm; - data.normalsize = scene->toolsettings->normalsize; + data.normalsize = compute_normal_size(ob, scene); calcDrawDMNormalScale(ob, &data); diff --git a/source/blender/makesrna/intern/rna_scene.c b/source/blender/makesrna/intern/rna_scene.c index 1c6d0fa..f2edf70 100644 --- a/source/blender/makesrna/intern/rna_scene.c +++ b/source/blender/makesrna/intern/rna_scene.c @@ -1872,11 +1872,12 @@ static void rna_def_tool_settings(BlenderRNA *brna) RNA_def_property_ui_text(prop, "Proportional Size", "Display size for proportional editing circle"); RNA_def_property_range(prop, 0.00001, 5000.0); - prop = RNA_def_property(srna, "normal_size", PROP_FLOAT, PROP_DISTANCE); + prop = RNA_def_property(srna, "normal_size", PROP_FLOAT, PROP_FACTOR); RNA_def_property_float_sdna(prop, NULL, "normalsize"); - RNA_def_property_ui_text(prop, "Normal Size", "Display size for normals in the 3D view"); - RNA_def_property_range(prop, 0.00001, 1000.0); - RNA_def_property_ui_range(prop, 0.01, 10.0, 10.0, 2); + RNA_def_property_ui_text(prop, "Normal Size", + "Display size for normals in the 3D view (proportional to global mesh's size)"); + RNA_def_property_range(prop, 0.001, 100.0); + RNA_def_property_ui_range(prop, 0.01, 2.0, 1.0, 2); RNA_def_property_update(prop, NC_GEOM | ND_DATA, NULL); prop = RNA_def_property(srna, "double_threshold", PROP_FLOAT, PROP_DISTANCE); ```

Bastien Montagne commented

2014-08-04 17:47:47 +02:00

Changed status from 'Open' to: 'Archived'

Bastien Montagne closed this issue

2014-08-04 17:47:47 +02:00

Bastien Montagne commented

2014-08-04 17:47:47 +02:00

Closing this one for now - added the scene's scale/dimentional UI items issue to our TODO list.

Thanks for the report anyway.

Closing this one for now - added the scene's scale/dimentional UI items issue to our [TODO list](http://wiki.blender.org/index.php/Dev:2.5/Source/Development/Todo/UserInterface#UI_Widgets). Thanks for the report anyway.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

With small units, cannot adjust Normals so well. #41308