Page MenuHome

real OpenGl Phong shading
Closed, ArchivedPublic

Description

the phong reflection shader was a blinn-phong implementation so we changed it to a real Phong reflection.

Details

Type
Patch

Event Timeline

dan grauer (kromar) raised the priority of this task from to Needs Triage by Developer.
dan grauer (kromar) updated the task description. (Show Details)
dan grauer (kromar) set Type to Patch.
dan grauer (kromar) updated the task description. (Show Details)

Seems ok, but will need to have a bit closer look.

@Antony Riakiotakis (psy-fi) might also be interested glancing here.

Sergey Sharybin (sergey) lowered the priority of this task from Needs Triage by Developer to Normal.Sep 12 2014, 10:56 AM

The purpose of the shader is to match the rendering, I'm not sure what is used there, but if it's not the same I might be against the change.

Nope, we are using blinn-phong in BI, check Phong_Spec function in shadeoutput.c line 588. We might consider changing that as well but it could influence old files.

I wouldn't be against adding a new specular type for BI though - sorry for the mail spam.

Aaron Carlisle (Blendify) closed this task as Archived.Mar 14 2017, 3:43 PM

Something similar has been done in the 2.8 branch.