Node Editor: Crash occurs with Select by Suffix #41933

New Issue

Leon Cheung · 2014-09-24T07:13:28+02:00

Leon Cheung commented

2014-09-24 07:13:28 +02:00

System Information
Win8 64bit | GTX680

Blender Version
Broken: 2.72 RC eb464ee

Short description of error
In Node Editor, when Shift G and choose "Suffix", Blender crashes.

Exact steps for others to reproduce the error
It's OK to test by using default scene. Thanks for checking.

**System Information** Win8 64bit | GTX680 **Blender Version** Broken: 2.72 RC eb464ee **Short description of error** In Node Editor, when **Shift G** and choose "Suffix", Blender crashes. **Exact steps for others to reproduce the error** It's OK to test by using default scene. Thanks for checking.

Leon Cheung commented

2014-09-24 07:13:28 +02:00

Changed status to: 'Open'

Leon Cheung commented

2014-09-24 07:13:28 +02:00

Added subscriber: @ZhangYu

Bastien Montagne was assigned by Sergey Sharybin

2014-09-24 11:27:57 +02:00

Sergey Sharybin commented

2014-09-24 11:27:57 +02:00

Added subscriber: @Sergey

Sergey Sharybin commented

2014-09-24 11:27:57 +02:00

Bastien, BLI_str_partition_ex_utf8 returns the length of the input string and NULL suffix, this is not properly checked by the callee function. Now, i'm not sure what value that function is expected to return, would think it should return length of the suffix? At leats that's what callee function expects it to be.

Bastien, `BLI_str_partition_ex_utf8` returns the length of the input string and NULL suffix, this is not properly checked by the callee function. Now, i'm not sure what value that function is expected to return, would think it should return length of the suffix? At leats that's what callee function expects it to be.

Lukas Tönne commented

2014-09-24 11:47:03 +02:00

Added subscriber: @LukasTonne

Lukas Tönne commented

2014-09-24 11:47:03 +02:00

Note from my side: I would expect a function like that to always return a valid string if a valid string is passed as input. That means if no delimiter is found it should make sep and suf empty strings (could be simply pointer to str + str_len, i.e. terminator char of the input).

Note from my side: I would expect a function like that to always return a valid string if a valid string is passed as input. That means if no delimiter is found it should make `sep` and `suf` empty strings (could be simply pointer to `str + str_len`, i.e. terminator char of the input).

Bastien Montagne commented

2014-09-24 20:07:21 +02:00

BLI_str_partition_ex_utf8 follows exactly its char counter part BLI_str_partition_ex - we might discuss what's best to do here, but for now issue is in calling code, which is not following BLI's API… will fix.

`BLI_str_partition_ex_utf8` follows exactly its char counter part `BLI_str_partition_ex` - we might discuss what's best to do here, but for now issue is in calling code, which is not following BLI's API… will fix.

blender-admin commented

2014-09-24 20:26:21 +02:00

This issue was referenced by e18a74849c

This issue was referenced by e18a74849c2dda52b25e0ca35127f511999a471c

Bastien Montagne commented

2014-09-24 20:28:33 +02:00

Changed status from 'Open' to: 'Resolved'

Bastien Montagne closed this issue

2014-09-24 20:28:33 +02:00

Bastien Montagne commented

2014-09-24 20:28:33 +02:00

Closed by commit e18a74849c.