Zeroing out angular velocity not possible #41943

New Issue

Raf Colson · 2014-09-24T16:54:13+02:00

Raf Colson commented

2014-09-24 16:54:13 +02:00

System Information
Windows 7 64 bit, Nvidia GeForce GT540M Cuda

Blender Version
I suppose the bug's there from the beginning. (tested with 2.57 up to 2.71)

Short description of error
Angular velocity magnitude can't be set to zero.

Exact steps for others to reproduce the error
Zeroing out angular velocity of Dynamic object with angular velocity magnitude > 0 has no effect.

Angular_velocity_zero_bug.blend

**System Information** Windows 7 64 bit, Nvidia GeForce GT540M Cuda **Blender Version** I suppose the bug's there from the beginning. (tested with 2.57 up to 2.71) **Short description of error** Angular velocity magnitude can't be set to zero. **Exact steps for others to reproduce the error** Zeroing out angular velocity of Dynamic object with angular velocity magnitude > 0 has no effect. [Angular_velocity_zero_bug.blend](https://archive.blender.org/developer/F112067/Angular_velocity_zero_bug.blend)

Raf Colson commented

2014-09-24 16:54:13 +02:00

Changed status to: 'Open'

Raf Colson commented

2014-09-24 16:54:13 +02:00

Added subscriber: @raco

Jorge Bernal commented

2014-09-28 01:29:53 +02:00

Added subscriber: @JorgeBernalMartinez

Jorge Bernal commented

2014-09-28 01:36:54 +02:00

Added subscriber: @Moguri

Jorge Bernal commented

2014-09-28 01:36:54 +02:00

I confirm the bug.

I have just checked the code and it seems that any value under a certain threshold (SIMD_EPSILON*SIMD_EPSILON) is totally ignored.

I attach a fix using the same solution that it was used for SetLinearVelocity (That is to comment the check for angular velocity min threshold).

setAngularVelocity_fix.patch

I confirm the bug. I have just checked the code and it seems that any value under a certain threshold (SIMD_EPSILON*SIMD_EPSILON) is totally ignored. I attach a fix using the same solution that it was used for SetLinearVelocity (That is to comment the check for angular velocity min threshold). [setAngularVelocity_fix.patch](https://archive.blender.org/developer/F113261/setAngularVelocity_fix.patch)

Andrey Kashlak commented

2014-11-22 12:42:11 +01:00

Added subscriber: @andreymal

Nicola Masotti commented

2014-12-12 22:46:44 +01:00

Added subscriber: @NIV

Jorge Bernal self-assigned this 2015-02-17 09:31:03 +01:00

Phoenix Down commented

2015-03-04 04:05:34 +01:00

Added subscriber: @Anasastu

Lee Pugh commented

2015-03-21 23:48:25 +01:00

Added subscriber: @Lee

Phoenix Down commented

2015-03-29 08:43:05 +02:00

In #41943#259105, @JorgeBernalMartinez wrote:
I confirm the bug.

I have just checked the code and it seems that any value under a certain threshold (SIMD_EPSILON*SIMD_EPSILON) is totally ignored.

I attach a fix using the same solution that it was used for SetLinearVelocity (That is to comment the check for angular velocity min threshold).

I think the check exists to restrict the user from applying values that would be grossly impractical, like 1e-20. That said, if we want to keep the check, we could ask if the applied sum is zero;
float angvelsum = angvel.length2()
if (m_object && ( angvelsum == 0 || angvelsum > (SIMD_EPSILON*SIMD_EPSILON)))

I've got no idea how to submit patches, though.

> In #41943#259105, @JorgeBernalMartinez wrote: > I confirm the bug. > > I have just checked the code and it seems that any value under a certain threshold (SIMD_EPSILON*SIMD_EPSILON) is totally ignored. > > I attach a fix using the same solution that it was used for SetLinearVelocity (That is to comment the check for angular velocity min threshold). I think the check exists to restrict the user from applying values that would be grossly impractical, like 1e-20. That said, if we want to keep the check, we could ask if the applied sum is zero; float angvelsum = angvel.length2() if (m_object && ( angvelsum == 0 || angvelsum > (SIMD_EPSILON*SIMD_EPSILON))) I've got no idea how to submit patches, though.

Jorge Bernal commented

2015-03-29 13:25:23 +02:00

It could be a good solution. When i come back from my easter holidays i will make a test blend to check it.

Phoenix Down commented

2015-04-25 21:17:31 +02:00

In #41943#298783, @Anasastu wrote:
I think the check exists to restrict the user from applying values that would be grossly impractical, like 1e-20. That said, if we want to keep the check, we could ask if the applied sum is zero;
float angvelsum = angvel.length2()
if (m_object && ( angvelsum == 0 || angvelsum > (SIMD_EPSILON*SIMD_EPSILON)))

I've got no idea how to submit patches, though.

Actually, I think it would be much more appropriate to print a message to console if the value is too low. If we assume that printf() can be used here and that I still understand C++:

float angvelsum = angvel.length2()
if (m_object && ( angvelsum == 0 || angvelsum > (SIMD_EPSILON*SIMD_EPSILON)))
  // go ahead and apply the change
else
  printf("Ignoring setAngularVelocity() command. Input value is too small in magnitude.");

This way, the user immediately knows what's up. If printf() can't be used, then we'd use whatever command prints out "Game Engine Started" and "Game Engine Finished".

> In #41943#298783, @Anasastu wrote: > I think the check exists to restrict the user from applying values that would be grossly impractical, like 1e-20. That said, if we want to keep the check, we could ask if the applied sum is zero; > float angvelsum = angvel.length2() > if (m_object && ( angvelsum == 0 || angvelsum > (SIMD_EPSILON*SIMD_EPSILON))) > > I've got no idea how to submit patches, though. Actually, I think it would be much more appropriate to print a message to console if the value is too low. If we assume that printf() can be used here and that I still understand C++: ``` float angvelsum = angvel.length2() if (m_object && ( angvelsum == 0 || angvelsum > (SIMD_EPSILON*SIMD_EPSILON))) // go ahead and apply the change else printf("Ignoring setAngularVelocity() command. Input value is too small in magnitude."); ``` This way, the user immediately knows what's up. If printf() can't be used, then we'd use whatever command prints out "Game Engine Started" and "Game Engine Finished".

qubodup commented

2015-05-05 06:02:46 +02:00

Added subscriber: @qubodup

Sybren A. Stüvel commented

2015-07-02 17:12:59 +02:00

Added subscriber: @dr.sybren

Sybren A. Stüvel commented

2015-07-02 17:12:59 +02:00

Why would we care about someone using 1e-20? If someone wants to, let them go ahead. Unless someone can prove that it actually causes a problem, I would suggest simply removing the check on magnitude.

Jorge Bernal commented

2015-07-02 23:21:35 +02:00

Hi Sybren,

I was proposing the same in D952. I'm doing a complex demo to check if magnitude check removal affects to instability. Maybe, next week I can finish it.

Hi Sybren, I was proposing the same in [D952](https://archive.blender.org/developer/D952). I'm doing a complex demo to check if magnitude check removal affects to instability. Maybe, next week I can finish it.

Inês Almeida commented

2015-10-03 11:44:10 +02:00

Added subscriber: @brita

Inês Almeida commented

2015-10-03 11:44:10 +02:00

I had a chat about this in IRC, it seems to me that we do want it to be possible to set angular and linear velocity (and more things) to zero.
Simply removing the check could, has mentioned, bring up performance and stability problems.
As for stability, I would suggest add a check if the value that the magnitude is being set to is within epsilon, if so, set to 0 instead epsilon.
For performance, I can't tell just by looking at it :)
What kind of tests are you preparing @JorgeBernalMartinez ? Are they ready and could you share them in the test suite files?

I see this is already the solution in D952 .
As a side note, it is really good to see suggestions from new people and an active community around this.

I had a chat about this in IRC, it seems to me that we do want it to be possible to set angular and linear velocity (and more things) to zero. Simply removing the check could, has mentioned, bring up performance and stability problems. As for stability, I would suggest add a check if the value that the magnitude is being set to is within epsilon, if so, set to 0 instead epsilon. For performance, I can't tell just by looking at it :) What kind of tests are you preparing @JorgeBernalMartinez ? Are they ready and could you share them in the test suite files? I see this is already the solution in [D952](https://archive.blender.org/developer/D952) . As a side note, it is really good to see suggestions from new people and an active community around this.

blender-admin commented

2015-10-09 09:50:20 +02:00

This issue was referenced by 46ad220305

This issue was referenced by 46ad2203057fbe4418120ab6dc1cb830e3d53958

Sybren A. Stüvel commented

2015-10-09 09:50:57 +02:00

Changed status from 'Open' to: 'Resolved'

Sybren A. Stüvel closed this issue

2015-10-09 09:50:57 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Zeroing out angular velocity not possible #41943