FCurve Modifier affecting keyframe after being deleted #42148

New Issue

Maverick · 2014-10-08T17:00:14+02:00

Maverick commented

2014-10-08 17:00:14 +02:00

System Information
win8-64 i7 gtx titan

Blender Version
blender-2.71-7c9b8aa-win64

Short description of error
F-Curve modifier still influences the curve after being deleted.

Exact steps for others to reproduce the error
1.Default cube, insert rotation
2.Go to Graph Editor and add a Noise modifier
3.Copy-Paste the modifier (important, does not work if you just add a new modifier !)
4.Press alt+a
5.Delete both modifiers and press alt+a again: cube is still affected

Check attached file as well (just press alt+a)

{F115482}

**System Information** win8-64 i7 gtx titan **Blender Version** blender-2.71-7c9b8aa-win64 **Short description of error** F-Curve modifier still influences the curve after being deleted. **Exact steps for others to reproduce the error** 1.Default cube, insert rotation 2.Go to Graph Editor and add a Noise modifier 3.Copy-Paste the modifier (*important*, does not work if you just add a new modifier !) 4.Press alt+a 5.Delete both modifiers and press alt+a again: cube is still affected Check attached file as well (just press alt+a) {F115482}

Maverick commented

2014-10-08 17:00:14 +02:00

Changed status to: 'Open'

Maverick commented

2014-10-08 17:00:14 +02:00

Added subscriber: @dragostanasie

Maverick commented

2014-10-08 17:01:39 +02:00

bug_minimal.blend

[bug_minimal.blend](https://archive.blender.org/developer/F115483/bug_minimal.blend)

Maverick commented

2014-10-08 17:25:37 +02:00

![bug_minimal.blend.jpg](https://archive.blender.org/developer/F115486/bug_minimal.blend.jpg)

Bastien Montagne commented

2014-10-08 18:05:50 +02:00

Added subscriber: @mont29

Bastien Montagne commented

2014-10-08 18:05:50 +02:00

Please check with latest Blender release! 2.72.

Cannot reproduce here (latest master, linux64).

Please check with latest Blender release! 2.72. Cannot reproduce here (latest master, linux64).

Maverick commented

2014-10-08 18:31:51 +02:00

oopss...sorry..I wrote the wrong blender version !
this was tested with latest git from buildbot

Windows 64 bit Official blender-2.72-47b8bf5-win64.zip 95M Wed Oct 8 03:01:02 2014

oopss...sorry..I wrote the wrong blender version ! this was tested with latest git from buildbot Windows 64 bit Official blender-2.72-47b8bf5-win64.zip 95M Wed Oct 8 03:01:02 2014

Maverick commented

2014-10-08 18:34:50 +02:00

great..the text is now badly formatted...please make it possible to be able to copy the blender version from the splash screen

blender-2.72-47b8bf5-win64.zip

great..the text is now badly formatted...please make it possible to be able to copy the blender version from the splash screen blender-2.72-47b8bf5-win64.zip

Bastien Montagne commented

2014-10-08 19:07:26 +02:00

Added subscriber: @MartijnBerger

Bastien Montagne commented

2014-10-08 19:07:26 +02:00

Martijn, mind checking this on windows? thanks

Greg Zaal commented

2014-10-08 19:22:12 +02:00

Added subscriber: @GregZaal

Greg Zaal commented

2014-10-08 19:22:12 +02:00

Works fine here (also linux 64bit) - can test later on windows, but I somehow doubt that has anything to do with it.

Maverick commented

2014-10-08 20:10:29 +02:00

Makes me make a video (or it's just a windows issue).

Martijn Berger was assigned by Bastien Montagne

2014-10-08 20:38:43 +02:00

Bastien Montagne commented

2014-10-08 20:38:43 +02:00

Added subscriber: @JoshuaLeung

Andrea Weikert commented

2014-10-08 20:39:08 +02:00

Added subscriber: @elubie

Andrea Weikert commented

2014-10-08 20:39:08 +02:00

I can confirm this happens when repeating the exact steps to reproduce on Windows 64 bit build 2.72 official release

Maverick commented

2014-10-09 02:17:45 +02:00

Found out that it breaks the animation even if you don't delete the modifiers.
After some time the animation fluctuates around some random value regardless of what parameters you change in the two modifiers.

Found out that it breaks the animation even if you don't delete the modifiers. After some time the animation fluctuates around some random value regardless of what parameters you change in the two modifiers.

Toni Alatalo commented

2014-10-14 13:13:12 +02:00

Added subscriber: @antont

Toni Alatalo commented

2014-10-14 13:14:16 +02:00

curious if this indeed is win specific (perhaps due to vs2013 like axys suspected on irc)

Joshua Leung commented

2014-10-14 13:27:05 +02:00

Wait a moment...

Up till tonight, I haven't been able to reproduce any issues (using a mingw64 bit build). However, after seeing Maverick's screenshot from Oct 9, I think I might have a clue what might be going on.

Specifically, when I was testing earlier, I was actually doing a few things differently. Namely, the procedure I followed was to:

Expand the group, and select one of the FCurves (usually the first or second)
Add a modifier to that FCurve
Copy the modifiers
Paste modifiers to the same FCurve or another one
Delete these modifiers one by one

However, from the looks of things, you're simply adding adding the modifier, then pressing copy/paste without expanding the group. This in turn seems to be adding the modifiers to all the FCurves in the group (since all of them are selected). Now, since you haven't expanded the group though, deleting the two modifiers from the UI only deletes them from the active FCurve and not from the other FCurves too.

Is this what is happening in your case?

Wait a moment... Up till tonight, I haven't been able to reproduce any issues (using a mingw64 bit build). However, after seeing Maverick's screenshot from Oct 9, I think I might have a clue what might be going on. Specifically, when I was testing earlier, I was actually doing a few things differently. Namely, the procedure I followed was to: 1) Expand the group, and select one of the FCurves (usually the first or second) 2) Add a modifier to that FCurve 3) Copy the modifiers 4) Paste modifiers to the same FCurve or another one 5) Delete these modifiers one by one However, from the looks of things, you're simply adding adding the modifier, then pressing copy/paste without expanding the group. This in turn seems to be adding the modifiers to all the FCurves in the group (since all of them are selected). Now, since you haven't expanded the group though, deleting the two modifiers from the UI only deletes them from the active FCurve and not from the other FCurves too. Is this what is happening in your case?

Bastien Montagne changed title from ~~Modifier affecting keyframe after being deleted~~ to FCurve Modifier affecting keyframe after being deleted

2014-10-14 13:51:12 +02:00

Andrea Weikert commented

2014-10-14 20:26:52 +02:00

@JoshuaLeung Bingo! I tried to play again and it is indeed the case that the pasted modifier gets added to all X, Y and Z rotation while delete only deletes it from the active FCurve. I was a bit confused about the pasting to all selected FCurves, but have to admit that this probably is the correct behaviour.

Toni Alatalo commented

2014-10-15 08:09:56 +02:00

Removed subscriber: @antont

Maverick commented

2014-10-15 20:14:54 +02:00

Ok, given the further testing by you guys I think we can better formulate the issue here:

1.Clicking "Add Modifier" adds the modifier on first channel ONLY (X in this case)
2.All the channels are selected though (this is not visible because the "Rotation" group is closed)
3.When you copy-paste the modifier the "Paste" command considers all the selected channels.

Proper solution here is to add the modifier to all selected channels.
If the group is closed and you select it then you expect the modifier to be added to all the channels.

Ok, given the further testing by you guys I think we can better formulate the issue here: 1.Clicking "Add Modifier" adds the modifier on first channel *ONLY* (X in this case) 2.All the channels are selected though (this is not visible because the "Rotation" group is closed) 3.When you copy-paste the modifier the "Paste" command considers all the selected channels. Proper solution here is to add the modifier to all selected channels. If the group is closed and you select it then you expect the modifier to be added to all the channels.

Martijn Berger was unassigned by Joshua Leung

2014-12-01 14:09:39 +01:00

Joshua Leung self-assigned this 2014-12-01 14:09:39 +01:00

Julian Eisel commented

2015-04-14 23:08:23 +02:00

Added subscriber: @JulianEisel

Julian Eisel commented

2015-04-14 23:08:23 +02:00

@JoshuaLeung, what's up with this? Is it still on your radar?

blender-admin commented

2016-04-15 10:05:08 +02:00

This issue was referenced by 344c17f439

This issue was referenced by 344c17f439394f263a20b117326c5d2c068a3896

Joshua Leung commented

2016-04-15 10:19:43 +02:00

Changed status from 'Open' to: 'Resolved'

Joshua Leung closed this issue

2016-04-15 10:19:43 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

FCurve Modifier affecting keyframe after being deleted #42148