Page MenuHome

FCurve Modifier affecting keyframe after being deleted
Closed, ResolvedPublic

Description

System Information
win8-64 i7 gtx titan

Blender Version
blender-2.71-7c9b8aa-win64

Short description of error
F-Curve modifier still influences the curve after being deleted.

Exact steps for others to reproduce the error
1.Default cube, insert rotation
2.Go to Graph Editor and add a Noise modifier
3.Copy-Paste the modifier (*important*, does not work if you just add a new modifier !)
4.Press alt+a
5.Delete both modifiers and press alt+a again: cube is still affected

Check attached file as well (just press alt+a)

{F115482}

Event Timeline

Maverick (maverick) set Type to Bug.
Maverick (maverick) created this task.
Maverick (maverick) raised the priority of this task from to Needs Triage by Developer.

Bastien Montagne (mont29) triaged this task as Needs Information from User priority.

Please check with latest Blender release! 2.72.

Cannot reproduce here (latest master, linux64).

oopss...sorry..I wrote the wrong blender version !
this was tested with latest git from buildbot

Windows 64 bit Official blender-2.72-47b8bf5-win64.zip 95M Wed Oct 8 03:01:02 2014

great..the text is now badly formatted...please make it possible to be able to copy the blender version from the splash screen

blender-2.72-47b8bf5-win64.zip

Martijn, mind checking this on windows? thanks

Bastien Montagne (mont29) raised the priority of this task from Needs Information from User to Normal.Oct 8 2014, 7:07 PM

Works fine here (also linux 64bit) - can test later on windows, but I somehow doubt that has anything to do with it.

Makes me make a video (or it's just a windows issue).

I can confirm this happens when repeating the exact steps to reproduce on Windows 64 bit build 2.72 official release

Found out that it breaks the animation even if you don't delete the modifiers.
After some time the animation fluctuates around some random value regardless of what parameters you change in the two modifiers.

curious if this indeed is win specific (perhaps due to vs2013 like axys suspected on irc)

Wait a moment...

Up till tonight, I haven't been able to reproduce any issues (using a mingw64 bit build). However, after seeing Maverick's screenshot from Oct 9, I think I might have a clue what might be going on.

Specifically, when I was testing earlier, I was actually doing a few things differently. Namely, the procedure I followed was to:

  1. Expand the group, and select one of the FCurves (usually the first or second)
  2. Add a modifier to that FCurve
  3. Copy the modifiers
  4. Paste modifiers to the same FCurve or another one
  5. Delete these modifiers one by one

However, from the looks of things, you're simply adding adding the modifier, then pressing copy/paste without expanding the group. This in turn seems to be adding the modifiers to all the FCurves in the group (since all of them are selected). Now, since you haven't expanded the group though, deleting the two modifiers from the UI only deletes them from the active FCurve and not from the other FCurves too.

Is this what is happening in your case?

Bastien Montagne (mont29) renamed this task from Modifier affecting keyframe after being deleted to FCurve Modifier affecting keyframe after being deleted.Oct 14 2014, 1:51 PM

@Joshua Leung (aligorith) Bingo! I tried to play again and it is indeed the case that the pasted modifier gets added to all X, Y and Z rotation while delete only deletes it from the active FCurve. I was a bit confused about the pasting to all selected FCurves, but have to admit that this probably is the correct behaviour.

Ok, given the further testing by you guys I think we can better formulate the issue here:

1.Clicking "Add Modifier" adds the modifier on first channel *ONLY* (X in this case)
2.All the channels are selected though (this is not visible because the "Rotation" group is closed)
3.When you copy-paste the modifier the "Paste" command considers all the selected channels.

Proper solution here is to add the modifier to all selected channels.
If the group is closed and you select it then you expect the modifier to be added to all the channels.

@Joshua Leung (aligorith), what's up with this? Is it still on your radar?