Weeping Willow preset in "Add Curve: Sapling" add-on broken #42207

New Issue

Jehan Pagès · 2014-10-13T16:43:09+02:00

Jehan Pagès commented

2014-10-13 16:43:09 +02:00

System Information
Linux Mint 17, 64-bit

Blender Version
Broken: the dev version from master branch pulled today.
Date: 2014-10-13 14:27
Hash: 8e1ae53

I have not tested the released version, so no idea if that is broken there too.

Short description of error

A tree made with the "Add Curve: Sapling" add-on, "weeping_willow" preset broken when using armature.

Exact steps for others to reproduce the error

No attached .blend file. This can be consistently reproduced from a new project in 1 minute:

Create a new project, get rid of the default cube;
Ensure that "Add Curve: Sapling" addon is enabled;
shift-a => Curve => Add Tree
In "Geometry" settings, open the "Load Preset" list, and select "weeping_willow";
Go to "Armature" settings, check "Use Armature".

Result: error pops-up, and you lose the settings dialogs.

Traceback (most recent call last):

File "/home/jehan/dev/build/blender/bin/2.72/scripts/addons/add_curve_sapling/__init__.py", line 550, in execute
  addTree(self)
File "/home/jehan/dev/build/blender/bin/2.72/scripts/addons/add_curve_sapling/utils.py", line 874, in addTree
  b.parent = arm.edit_bones[parBone]

KeyError: 'bpy_prop_collection[key]: key "bone029.002" not found'

location: :-1

Other preset seem ok. I got a similar error only with weeping_willow preset.

**System Information** Linux Mint 17, 64-bit **Blender Version** Broken: the dev version from master branch pulled today. Date: 2014-10-13 14:27 Hash: 8e1ae53 I have not tested the released version, so no idea if that is broken there too. **Short description of error** A tree made with the "Add Curve: Sapling" add-on, "weeping_willow" preset broken when using armature. **Exact steps for others to reproduce the error** No attached .blend file. This can be consistently reproduced from a new project in 1 minute: - Create a new project, get rid of the default cube; - Ensure that "Add Curve: Sapling" addon is enabled; - shift-a => Curve => Add Tree - In "Geometry" settings, open the "Load Preset" list, and select "weeping_willow"; - Go to "Armature" settings, check "Use Armature". Result: error pops-up, and you lose the settings dialogs. -------------------------------------------------------- Traceback (most recent call last): ``` File "/home/jehan/dev/build/blender/bin/2.72/scripts/addons/add_curve_sapling/__init__.py", line 550, in execute addTree(self) File "/home/jehan/dev/build/blender/bin/2.72/scripts/addons/add_curve_sapling/utils.py", line 874, in addTree b.parent = arm.edit_bones[parBone] ``` KeyError: 'bpy_prop_collection[key]: key "bone029.002" not found' location: <unknown location>:-1 location: <unknown location>:-1 -------------------------------------------------------- Other preset seem ok. I got a similar error only with weeping_willow preset.

Jehan Pagès commented

2014-10-13 16:43:09 +02:00

Changed status to: 'Open'

Jehan Pagès commented

2014-10-13 16:43:09 +02:00

Added subscriber: @jehan

Philipp Oeser commented

2014-10-13 18:50:15 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2014-10-13 18:50:15 +02:00

can confirm this, will have a look...

NikoLeopold commented

2014-10-30 00:23:45 +01:00

Added subscriber: @NikoLeopold

Philipp Oeser commented

2014-11-01 09:35:21 +01:00

"weeping_willow" preset has pruning turned on so this situation will expose a bug with armatures and pruning in general.
pruning might delete splines and create new one which is not reflected in the code's mapping of "splineToBone"

was testing this a bit but dont have time to finish this so just dropping two testpatches here for inspiration.
by no means a solution, will get rid of the error but will introduce a mismatch of parentbones...
T42207_first_try.patch T42207_second_try.patch

"weeping_willow" preset has pruning turned on so this situation will expose a bug with armatures and pruning in general. pruning might delete splines and create new one which is not reflected in the code's mapping of "splineToBone" was testing this a bit but dont have time to finish this so just dropping two testpatches here for inspiration. by no means a solution, will get rid of the error but will introduce a mismatch of parentbones... [T42207_first_try.patch](https://archive.blender.org/developer/F121008/T42207_first_try.patch) [T42207_second_try.patch](https://archive.blender.org/developer/F121009/T42207_second_try.patch)

Brendon Murphy commented

2015-05-24 14:08:32 +02:00

Added subscriber: @BrendonMurphy

Brendon Murphy commented

2015-05-24 14:08:32 +02:00

Changed status from 'Open' to: 'Resolved'

Brendon Murphy closed this issue

2015-05-24 14:08:32 +02:00

Brendon Murphy self-assigned this 2015-05-24 14:08:32 +02:00

Brendon Murphy commented

2015-05-24 14:08:32 +02:00

removed pruning from weeping willow preset.
https://developer.blender.org/rBA7b0dc56934743e2019b22fea78b972008d0d73a5

Note, I will try to create blender internal preset system at a later date.

closing report.

removed pruning from weeping willow preset. https://developer.blender.org/rBA7b0dc56934743e2019b22fea78b972008d0d73a5 Note, I will try to create blender internal preset system at a later date. closing report.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Weeping Willow preset in "Add Curve: Sapling" add-on broken #42207

location: :-1