Mocap addon: auto-scale doesn't work (patch attached) #42416

New Issue

inactive account · 2014-10-27T15:21:52+01:00

inactive account commented

2014-10-27 15:21:52 +01:00

System Information
Windows 7 64-bit, Blender 2.72b

Blender Version
Broken: Blender 2.72b
Also checked latest version from GIT (addon repo b714750bf0)

Short description of error
The "auto scale" feature of the mocap addon is broken. It applies the wrong scale, and keeps applying it. This means that not only is the initial result wrong, it keeps getting wronger every time you press the "auto scale" button.

Exact steps for others to reproduce the error
Open the attached blend file mocap_tools_test.blend. Select the right-hand armature, then shift-select the left-hand armature. In the object panel, click "Auto scale performer" a few times.

Expected behaviour: the first click sets the correct scale, subsequent clicks do nothing as the scale is already correct.
Observed behaviour: every click makes the performer skeleton change in size, and none of them is the expected size.

Patch
Here is my first patch to Blender ever: {F119931}!
Apart from fixing this bug, I've also simplified the code. There were a few things that were explicitly coded while there are Python builtins that perform the same operation (and do it faster).

**System Information** Windows 7 64-bit, Blender 2.72b **Blender Version** Broken: Blender 2.72b Also checked latest version from GIT (addon repo b714750bf00bd6aaf2c87afad533eb01b68861b8) **Short description of error** The "auto scale" feature of the mocap addon is broken. It applies the wrong scale, and keeps applying it. This means that not only is the initial result wrong, it keeps getting wronger every time you press the "auto scale" button. **Exact steps for others to reproduce the error** Open the attached blend file [mocap_tools_test.blend](https://archive.blender.org/developer/F119930/mocap_tools_test.blend). Select the right-hand armature, then shift-select the left-hand armature. In the object panel, click "Auto scale performer" a few times. **Expected behaviour:** the first click sets the correct scale, subsequent clicks do nothing as the scale is already correct. **Observed behaviour:** every click makes the performer skeleton change in size, and none of them is the expected size. **Patch** Here is my first patch to Blender ever: {[F119931](https://archive.blender.org/developer/F119931/fix_addon_mocap_autoscale.patch)}! Apart from fixing this bug, I've also simplified the code. There were a few things that were explicitly coded while there are Python builtins that perform the same operation (and do it faster).

inactive account commented

2014-10-27 15:21:52 +01:00

Changed status to: 'Open'

inactive account self-assigned this 2014-10-27 15:21:52 +01:00

inactive account commented

2014-10-27 15:21:52 +01:00

Added subscriber: @sybrenstuvel

inactive account changed title from ~~Mocap addon: auto-scale doesn't work~~ to Mocap addon: auto-scale doesn't work (patch attached)

2014-10-27 15:30:04 +01:00

inactive account was unassigned by Bastien Montagne

2014-10-27 16:52:04 +01:00

Bastien Montagne self-assigned this 2014-10-27 16:52:04 +01:00

Bastien Montagne commented

2014-10-29 12:16:22 +01:00

Hey Sybren, patch LGTM, I’d like to commit it with you as author (git allows that), but would need an email address for that, mind giving me one (would be a public mail, since it's available in git logs - we can also use a garbage fake mail like sybrenstuvel@foo.org if really needed)?

Hey Sybren, patch LGTM, I’d like to commit it with you as author (git allows that), but would need an email address for that, mind giving me one (would be a public mail, since it's available in git logs - we can also use a garbage fake mail like <sybrenstuvel@foo.org> if really needed)?

inactive account commented

2014-10-29 12:28:50 +01:00

Hi Bastien. Thanks for that, and feel free to use sybren@stuvel.eu.