Undoing 'create transformation orientation' makes selected transform orientation blank. #42468

New Issue

Stanislav Blinov · 2014-11-02T09:03:43+01:00

Stanislav Blinov commented

2014-11-02 09:03:43 +01:00

System Information
Linux 64bit

Blender Version
Broken: 2.72b, 2.71 (and lower?)

Short description of error

Creating custom transformation orientation can be undone, but doing so will set transformation orientation dropdown in 3D view header to blank value.

Exact steps for others to reproduce the error

Create new file
Run 'create transformation orientation' operator (ctrl+alt+space in default keymap): transformation orientation dropdown in 3D view header should change to show the name of newly created orientation
Undo (ctrl+z): transformation orientation dropdown becomes blank.

**System Information** Linux 64bit **Blender Version** Broken: 2.72b, 2.71 (and lower?) **Short description of error** Creating custom transformation orientation can be undone, but doing so will set transformation orientation dropdown in 3D view header to blank value. **Exact steps for others to reproduce the error** 1. Create new file 2. Run 'create transformation orientation' operator (ctrl+alt+space in default keymap): transformation orientation dropdown in 3D view header should change to show the name of newly created orientation 3. Undo (ctrl+z): transformation orientation dropdown becomes blank.

Stanislav Blinov commented

2014-11-02 09:03:43 +01:00

Changed status to: 'Open'

Stanislav Blinov commented

2014-11-02 09:03:43 +01:00

Added subscriber: @Stan_Pancakes

blender-admin commented

2014-11-02 09:03:43 +01:00

#46011 was marked as duplicate of this issue

Campbell Barton commented

2014-11-03 16:13:35 +01:00

Added subscriber: @ideasman42

Campbell Barton commented

2014-11-03 16:13:35 +01:00

The issue here is screen data is stored separate to blend-file data, so undo/redo can make them out-of-sync.

Sergey Sharybin commented

2014-12-30 17:26:47 +01:00

Added subscriber: @Sergey

Sergey Sharybin commented

2014-12-30 17:26:47 +01:00

@ideasman42, shall we run some sort of validation of the screen data after undo or we just mark the operator as non-undoable?

Campbell Barton commented

2015-03-10 01:07:30 +01:00

Cant really see a good solution here - making it non-undoable wont help since some other operation can push the undo stack.

We could just work-around the problem with a fallback - if the index is out of range use world-space, but even in this case undo will switch back and forget the space that was set previously...

Another way could be to store 2 indices's.

Index of built-in manipulator.
Index of custom manipulator.

Then if the index of the custom manipulator is out of range it can used the built-in value.
But this seems like a reasonable amount of effort just to workaround this bug.

Cant really see a good solution here - making it non-undoable wont help since some other operation can push the undo stack. We could just work-around the problem with a fallback - if the index is out of range use world-space, but even in this case undo will switch back and forget the space that was set previously... Another way could be to store 2 indices's. - Index of built-in manipulator. - Index of custom manipulator. Then if the index of the custom manipulator is out of range it can used the built-in value. But this seems like a reasonable amount of effort just to workaround this bug.

Sergey Sharybin commented

2015-03-10 17:53:03 +01:00

@ideasman42, think it's better to just clamp transform index and don't worry about previously used space. Would at least prevent inconsistent state of .blend file even tho wouldn't be totally nice solution from user's perspective. Further improvements could b then moved to TODO.

Campbell Barton commented

2015-03-11 04:51:20 +01:00

The reason I dont much like to clamp on undo, - is (undo/redo) will then change your manipulator.

Julian Eisel commented

2015-03-13 00:59:17 +01:00

Added subscriber: @JulianEisel

Julian Eisel commented

2015-03-13 00:59:17 +01:00

Ehh, would say this is a todo?

Campbell Barton commented

2015-03-16 04:32:58 +01:00

Looked into possible fix, but not really happy with it because its searching the list on each access. P210

Setting as TODO.

Looked into possible fix, but not really happy with it because its searching the list on each access. [P210](https://archive.blender.org/developer/P210.txt) Setting as TODO.

Bastien Montagne commented

2015-09-11 12:55:58 +02:00

Added subscribers: @mont29, @ZhangYu

Stanislav Blinov commented

2019-12-06 14:04:42 +01:00

I guess this one is now different: name seems to be kept, but the operation isn't undone (transform orientation remains after undo).

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Undoing 'create transformation orientation' makes selected transform orientation blank. #42468