Mocap addon: "Clean noise" didn't work properly. #42476

Closed
opened 2014-11-02 22:19:26 +01:00 by inactive account · 7 comments

Blender Version
Broken: 2.72

Short description of error
Mocap addon: "Clean noise" didn't work properly.
The comments describe it as a median filter, but the implementation was not a median filter. It also misses some spikes in the data, and depends on kernel sizes that may be hard to guess or understand the implications of.

This patch mocap-addon-cleanup.patch provides a simpler, more robust cleanup function, which doesn't depend on hard-to-guess filter sizes. It also fixes several PEP-8 violations in the modified code.

**Blender Version** Broken: 2.72 **Short description of error** Mocap addon: "Clean noise" didn't work properly. The comments describe it as a median filter, but the implementation was not a median filter. It also misses some spikes in the data, and depends on kernel sizes that may be hard to guess or understand the implications of. This patch [mocap-addon-cleanup.patch](https://archive.blender.org/developer/F121457/mocap-addon-cleanup.patch) provides a simpler, more robust cleanup function, which doesn't depend on hard-to-guess filter sizes. It also fixes several PEP-8 violations in the modified code.

Changed status to: 'Open'

Changed status to: 'Open'

Added subscriber: @sybrenstuvel

Added subscriber: @sybrenstuvel
Benjy Cook was assigned by Sergey Sharybin 2014-11-04 09:51:29 +01:00

Added subscribers: @mont29, @benjycook, @Sergey

Added subscribers: @mont29, @benjycook, @Sergey

@benjycook, are you still around to look into the patches? As a backup, maybe @mont29 wants to check on the code? :)

@benjycook, are you still around to look into the patches? As a backup, maybe @mont29 wants to check on the code? :)

This issue was referenced by 9d276937de

This issue was referenced by 9d276937de26f82a4bbaded388ed474b951f338a

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'

Closed by commit 9d276937de.

Closed by commit 9d276937de.
Sign in to join this conversation.
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons#42476
No description provided.