Advanced Camera Rigs Addon #43509

New Issue

Try to adhere to PEP8. There are unnecessarily long lines in the source. For example, a repetition of 19x False can also be written as 19 * [False].
The Camera.show_title_safe property is used in the GUI, but never registered.
The addon prevents selection of the camera. This makes it impossible to reach certain properties, which it circumvents by allowing the user to modify them in a non-standard panel. This makes the addon harder to use than necessary. Just locking the position/rotation/scale of the camera would probably be easier for the user, as the camera properties will remain in their known place. This also makes the addon more future-proof.
Usability will be improved by locking certain properties of certain bones; for example locking the Z-position of the armature object will allow easier dolly'ing.
The root bone's axes don't line up with the object axes (the ground plane lines up with X/Z instead of X/Y). This makes controlling the rig difficult.
It's unclear why the root bone extends downwards. This makes the relationship lines confusing.

It seems that this addon is the one you're referring to. If you indeed modified that addon, it's Very Bad to rip out the original authors' names and replace it with your own.

I've looked at the dolly rig, and it looks pretty useful. There are a few issues, though. - Try to adhere to PEP8. There are unnecessarily long lines in the source. For example, a repetition of 19x False can also be written as `19 * [False]`. - The `Camera.show_title_safe` property is used in the GUI, but never registered. - The addon prevents selection of the camera. This makes it impossible to reach certain properties, which it circumvents by allowing the user to modify them in a non-standard panel. This makes the addon harder to use than necessary. Just locking the position/rotation/scale of the camera would probably be easier for the user, as the camera properties will remain in their known place. This also makes the addon more future-proof. - Usability will be improved by locking certain properties of certain bones; for example locking the Z-position of the armature object will allow easier dolly'ing. - The root bone's axes don't line up with the object axes (the ground plane lines up with X/Z instead of X/Y). This makes controlling the rig difficult. - It's unclear why the root bone extends downwards. This makes the relationship lines confusing. It seems that [this addon](http://wiki.blender.org/index.php/Extensions:2.6/Py/Scripts/Rigging/Add_Camera_Rigs) is the one you're referring to. If you indeed modified that addon, it's Very Bad to rip out the original authors' names and replace it with your own.

Sybren A. Stüvel commented

2015-02-01 01:25:24 +01:00

Changed status from 'Archived' to: 'Open'

Sybren A. Stüvel reopened this issue

2015-02-01 01:25:24 +01:00

Sybren A. Stüvel commented

2015-02-01 01:25:24 +01:00

Reverting status change, was a mistake.

John Roper commented

2015-02-01 13:36:53 +01:00

I took main bits of code from the other addon, but I did not copy the entire script and rip out their names. You can select the camera object. To do this you need to get out of pose mode on ether of the armatures.

I am working on locking parts of the dolly armature right now. Already, parts of the Crane armature are locked.

I am not sure if this is the place to ask, but I was wondering if there was a way that I could have the menu options come up under the camera menu in the add menu.?

I took main bits of code from the other addon, but I did not copy the entire script and rip out their names. You can select the camera object. To do this you need to get out of pose mode on ether of the armatures. - I am working on locking parts of the dolly armature right now. Already, parts of the Crane armature are locked. I am not sure if this is the place to ask, but I was wondering if there was a way that I could have the menu options come up under the camera menu in the add menu.?

Sybren A. Stüvel commented

2015-02-01 15:54:54 +01:00

Please do give some credit to the original authors, as per the GPL license. It doesn't have to be in the bl_info dict.

If you're looking for inclusion of this addon in Blender, please address the issues I've noted so far. It does look like a nice addon, but it needs polishing.

Please do give some credit to the original authors, as per the GPL license. It doesn't have to be in the bl_info dict. If you're looking for inclusion of this addon in Blender, please address the issues I've noted so far. It does look like a nice addon, but it needs polishing.

John Roper commented

2015-02-01 21:36:50 +01:00

Added subscriber: @Ton

John Roper commented

2015-02-01 21:43:25 +01:00

To select the camera object, press 'T' to open up the right menu in the 3D window, and at the bottom (when the rig is selected) there is a menu for Advanced Camera Rig. Near the bottom, there is a button labeled, 'Lock Camera Select'. it is currently enabled. Click to dis-enable, and you will be able to select the camera.

John Roper commented

2015-02-01 21:58:30 +01:00

I have worked out the z axis lock and I have given credit to Wayne Dixon and Kris Wittig at the top of the file.advanced_camera_rigs_3.5.py

I have worked out the z axis lock and I have given credit to Wayne Dixon and Kris Wittig at the top of the file.[advanced_camera_rigs_3.5.py](https://archive.blender.org/developer/F140318/advanced_camera_rigs_3.5.py)

John Roper commented

2015-02-01 22:00:40 +01:00

Sorry, that was the wrong version of the script. Here it is.advanced_camera_rigs_3.5.py

Sorry, that was the wrong version of the script. Here it is.[advanced_camera_rigs_3.5.py](https://archive.blender.org/developer/F140320/advanced_camera_rigs_3.5.py)

John Roper commented

2015-02-01 22:12:41 +01:00

Blender will not allow me to reduce the lines of False because they tell which layer to put things on.

John Roper commented

2015-02-01 22:18:36 +01:00

The root bone extends downward because the side of that bone controls the size of the custom bone, and if I make it any smaller the custom control bone will be tiny.

John Roper commented

2015-02-01 22:22:50 +01:00

Ok, I have fixed everything that I can see and I am waiting for review. Thanks{F140323}

Ok, I have fixed everything that I can see and I am waiting for review. Thanks{[F140323](https://archive.blender.org/developer/F140323/advanced_camera_rigs_4.0.py)}

John Roper commented

2015-02-02 02:15:50 +01:00

Here is version 6.0.
advanced_camera_rigs_6.0.py

Here is version 6.0. [advanced_camera_rigs_6.0.py](https://archive.blender.org/developer/F140350/advanced_camera_rigs_6.0.py)

John Roper commented

2015-02-02 17:58:34 +01:00

Added subscriber: @kjym3

John Roper commented

2015-02-02 18:25:38 +01:00

I need this to be reviewed please.

Julian Eisel commented

2015-02-02 18:51:02 +01:00

Added subscribers: @BrendonMurphy, @ideasman42
Removed subscribers: @fsiddi, @Ton

Added subscribers: @BrendonMurphy, @ideasman42 Removed subscribers: @fsiddi, @Ton

John Roper commented

2015-02-02 18:55:05 +01:00

Added subscriber: @JulianEisel

Julian Eisel commented

2015-02-02 19:00:03 +01:00

Slow down, you can't expect to get a patch/addon reviewed after 3 days. We have a lot of patches waiting for review so you'll propably need some days of patience.
Also please don't set priority yourself (especially don't set it to high!!)

I don't know much about the add-on/bpy area, but from a quick look I'd say some work is needed to get this into master. I CCed two more people that are more advanced in this area or that may be a better help.

Slow down, you can't expect to get a patch/addon reviewed after 3 days. We have a lot of patches waiting for review so you'll propably need some days of patience. Also please don't set priority yourself (especially don't set it to high!!) I don't know much about the add-on/bpy area, but from a quick look I'd say some work is needed to get this into master. I CCed two more people that are more advanced in this area or that may be a better help.

Sybren A. Stüvel commented

2015-02-02 21:03:20 +01:00

Added subscriber: @JohnRoper

Sybren A. Stüvel commented

2015-02-02 21:03:20 +01:00

@JohnRoper Read https://www.python.org/dev/peps/pep-0008/ thoroghly. Adhering to those rules is a requirement to get code shipped with Blender. There is one exception, and that is that we accept up to 120 characters per line.

The other points I mentioned must also be fixed. Once an addon is included with Blender, a new version can be released every two months at the fastest. That means that any mistake or other issue with the addon cannot be addressed quickly. Because of this, we have to set high standards for acceptance; I'm sure you understand this.

Please also be aware that any comment or change on this task page results in an email to all subscribers. It's better to take it a bit slower, and collect more changes & text to post it in one go.

If you need any help with the coding, feel free to drop by on #blenderpython on IRC.

@JohnRoper Read https://www.python.org/dev/peps/pep-0008/ thoroghly. Adhering to those rules is a requirement to get code shipped with Blender. There is one exception, and that is that we accept up to 120 characters per line. The other points I mentioned must also be fixed. Once an addon is included with Blender, a new version can be released every two months at the fastest. That means that any mistake or other issue with the addon cannot be addressed quickly. Because of this, we have to set high standards for acceptance; I'm sure you understand this. Please also be aware that any comment or change on this task page results in an email to all subscribers. It's better to take it a bit slower, and collect more changes & text to post it in one go. If you need any help with the coding, feel free to drop by on #blenderpython on IRC.

John Roper commented

2015-02-27 17:11:26 +01:00

If I can get a good version in by tomorrow night will it be included in the next version? If it can I will do work on it, but it it will not I have other things to do.

Julian Eisel commented

2015-02-27 17:19:02 +01:00

Not in the next version, but there is definitely an interest in getting this in. Also keep in mind that even if you've addressed the raised concerns, it's likely that we will ask for other changes to be made. As I said, slow down, keep patience ;)

John Roper commented

2015-02-27 21:29:40 +01:00

I have been working all day on this and it is ready.

New Features

Fully PEP8 compliant code (http://pep8online.com/s/KkerKcpN)

3 full and working camera rigs

An option to make any camera 3D

A full documentation on my website

I am also working on a feature to add the node setup to composite the images into 3d form. Right now all that the addon does is create the 3D camera, the user has to do the rest.

Here it is - advanced_camera_rigs.py

I have been working all day on this and it is ready. **New Features** # Fully PEP8 compliant code (http://pep8online.com/s/KkerKcpN) # 3 full and working camera rigs # An option to make any camera 3D # A full documentation on my website I am also working on a feature to add the node setup to composite the images into 3d form. Right now all that the addon does is create the 3D camera, the user has to do the rest. Here it is - [advanced_camera_rigs.py](https://archive.blender.org/developer/F146173/advanced_camera_rigs.py)

John Roper commented

2015-02-28 13:02:31 +01:00

Here is version 10.5 which fixes the creation bug in my last release.
advanced_camera_rigs.py

Here is version 10.5 which fixes the creation bug in my last release. [advanced_camera_rigs.py](https://archive.blender.org/developer/F146301/advanced_camera_rigs.py)

Sybren A. Stüvel commented

2015-02-28 13:37:21 +01:00

Just an idea, but wouldn't it be easier to host your addon on Github, and then link to it from here? That'll save you from uploading new versions every time, and makes it easier for us to browse through the code and see what changed.

John Roper changed title from ~~Advanced Camera Rigs~~ to Camera and Lighting Rigs

2015-03-01 19:18:42 +01:00

John Roper commented

2015-03-01 19:19:31 +01:00

Bug fixes and BETA TESTING lighting rigs.
Renamed project
camera_and_lighting_rigs.py

Bug fixes and BETA TESTING lighting rigs. Renamed project [camera_and_lighting_rigs.py](https://archive.blender.org/developer/F146570/camera_and_lighting_rigs.py)

Sybren A. Stüvel commented

2015-03-01 19:21:34 +01:00

Please don't add features before you get the existing features fleshed out. As @JulianEisel already said - slow down, perfect, and have patience.

John Roper commented

2015-03-02 13:00:01 +01:00

Is there any thing that you want me to fix or add?

John Roper commented

2015-03-06 02:14:43 +01:00

v12.5 - camera_and_lighting_rigs.py

Fleshed out the code a little bit
Worked more with the lighting rigs
Bug Fixes

TODO -

Fix aim widget control
Get git up and running

v12.5 - [camera_and_lighting_rigs.py](https://archive.blender.org/developer/F147479/camera_and_lighting_rigs.py) - Fleshed out the code a little bit - Worked more with the lighting rigs - Bug Fixes TODO - - Fix aim widget control - Get git up and running

Sybren A. Stüvel commented

2015-03-06 10:02:27 +01:00

"Please don't add features before you get the existing features fleshed out." -- what I meant with that, is that you should remove the lighting rig from the code. Don't add things until the base functionality is good.

"Just an idea, but wouldn't it be easier to host your addon on Github, and then link to it from here?" -- please do this. There you can easily manage versions, keep lists of issues and TODOs, etc. It also makes our lives reviewing the code much easier.

"Please don't add features before you get the existing features fleshed out." -- what I meant with that, is that you should remove the lighting rig from the code. Don't add things until the base functionality is good. "Just an idea, but wouldn't it be easier to host your addon on Github, and then link to it from here?" -- please do this. There you can easily manage versions, keep lists of issues and TODOs, etc. It also makes our lives reviewing the code much easier.

John Roper commented

2015-03-06 23:05:34 +01:00

Github link -
http://www.github.com/johnroper100/camera-and-lighting-rigs/

Github link - http://www.github.com/johnroper100/camera-and-lighting-rigs/

John Roper commented

2015-03-15 12:26:12 +01:00

The aim widgets work!
It must have been something to do with the compound rig which I removed for good with the lighting rigs last night.

The aim widgets work! It must have been something to do with the compound rig which I removed for good with the lighting rigs last night.

John Roper changed title from ~~Camera and Lighting Rigs~~ to Advanced Camera Rigs Addon

2015-03-19 23:44:11 +01:00

John Roper commented

2015-03-19 23:44:57 +01:00

Final version is in the git repository.

Campbell Barton commented

2015-03-20 05:13:26 +01:00

Hi @JohnRoper, I've committed this into a temporary branch in the addons-contrib repo, this way its easier to do work with our review system.

You have been added as a committer to addons, but to commit you'll need to upload ssh keys.
You can continue development of the addon here, or in your own repo - its up to you, but becoming familiar with phabricator our git work-flow sooner then later is an advantage.

You can checkout addons-contrib, switch to branch temp-camera-rigs-advanced, and commit changes to the script (continue development there).
The addon is located in object_camera_rig_advanced/__init__.py, See: blender/blender-addons-contrib@ec4195e4f0

Addons Contrib:
https://developer.blender.org/diffusion/BAC/

Review:
https://developer.blender.org/D1192

Hi @JohnRoper, I've committed this into a temporary branch in the addons-contrib repo, this way its easier to do work with our review system. You have been added as a committer to addons, but to commit you'll need to upload ssh keys. You can continue development of the addon here, or in your own repo - its up to you, but becoming familiar with phabricator our git work-flow sooner then later is an advantage. You can checkout addons-contrib, switch to branch `temp-camera-rigs-advanced`, and commit changes to the script (continue development there). The addon is located in `object_camera_rig_advanced/__init__.py`, See: blender/blender-addons-contrib@ec4195e4f0 Addons Contrib: https://developer.blender.org/diffusion/BAC/ Review: https://developer.blender.org/D1192

Brendon Murphy commented

2015-09-10 10:57:21 +02:00

Added subscribers: @WayneDixon, @mont29

Brendon Murphy commented

2015-09-10 11:00:39 +02:00

Added subscriber: @John-44

Brendon Murphy commented

2015-09-10 11:00:39 +02:00

John roper(johnroper100)
hi, you really need to credit the original author in your file.
I've merged in the original task by the original author.
I would question the validity of the branch associated with this project.
changed priority to normal.

John roper(johnroper100) hi, you really need to credit the original author in your file. I've merged in the original task by the original author. I would question the validity of the branch associated with this project. changed priority to normal.

Wayne Dixon commented

2015-09-17 00:52:48 +02:00

I'm unsure why my task was ignored last year but it's good to see that something is actually happening with this.

Thanks for including me meta-acdrocto, and thanks for your work johnroper100

I'm unsure why my task was ignored last year but it's good to see that something is actually happening with this. Thanks for including me meta-acdrocto, and thanks for your work johnroper100

John Roper commented

2016-03-13 20:35:37 +01:00

Changed status from 'Open' to: 'Archived'

John Roper closed this issue

2016-03-13 20:35:37 +01:00

Brendon Murphy commented

2016-03-21 08:25:34 +01:00

Changed status from 'Archived' to: 'Open'

Brendon Murphy reopened this issue

2016-03-21 08:25:34 +01:00

John Roper was unassigned by Brendon Murphy

2016-03-21 08:25:34 +01:00